Blame SOURCES/0138-journal-file-protect-against-alloca-0.patch
|
 |
572a44 |
From d3bf15d0b7c461aae4d97fe6425a6f0cea277222 Mon Sep 17 00:00:00 2001
|
|
|
572a44 |
From: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
|
|
|
572a44 |
Date: Mon, 16 Dec 2013 23:35:30 +0100
|
|
|
572a44 |
Subject: [PATCH] journal-file: protect against alloca(0)
|
|
|
572a44 |
|
|
|
572a44 |
---
|
|
|
572a44 |
src/journal/journal-file.c | 3 ++-
|
|
|
572a44 |
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
572a44 |
|
|
|
572a44 |
diff --git a/src/journal/journal-file.c b/src/journal/journal-file.c
|
|
|
572a44 |
index 962cdd6..ebf72f3 100644
|
|
|
572a44 |
--- a/src/journal/journal-file.c
|
|
|
572a44 |
+++ b/src/journal/journal-file.c
|
|
|
572a44 |
@@ -2730,7 +2730,8 @@ int journal_file_copy_entry(JournalFile *from, JournalFile *to, Object *o, uint6
|
|
|
572a44 |
ts.realtime = le64toh(o->entry.realtime);
|
|
|
572a44 |
|
|
|
572a44 |
n = journal_file_entry_n_items(o);
|
|
|
572a44 |
- items = alloca(sizeof(EntryItem) * n);
|
|
|
572a44 |
+ /* alloca() can't take 0, hence let's allocate at least one */
|
|
|
572a44 |
+ items = alloca(sizeof(EntryItem) * MAX(1u, n));
|
|
|
572a44 |
|
|
|
572a44 |
for (i = 0; i < n; i++) {
|
|
|
572a44 |
uint64_t l, h;
|