richardphibel / rpms / systemd

Forked from rpms/systemd 2 years ago
Clone
9fc0f6
From 87f830a2046141ed917661a726c3ec38b4d15e89 Mon Sep 17 00:00:00 2001
9fc0f6
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
9fc0f6
Date: Fri, 11 Oct 2013 19:33:13 -0400
9fc0f6
Subject: [PATCH] Never call qsort on potentially NULL arrays
9fc0f6
9fc0f6
This extends 62678ded 'efi: never call qsort on potentially
9fc0f6
NULL arrays' to all other places where qsort is used and it
9fc0f6
is not obvious that the count is non-zero.
9fc0f6
---
9fc0f6
 src/shared/cgroup-show.c | 2 ++
9fc0f6
 1 file changed, 2 insertions(+)
9fc0f6
9fc0f6
diff --git a/src/shared/cgroup-show.c b/src/shared/cgroup-show.c
9fc0f6
index aa0f017..f6e56db 100644
9fc0f6
--- a/src/shared/cgroup-show.c
9fc0f6
+++ b/src/shared/cgroup-show.c
9fc0f6
@@ -44,6 +44,8 @@ static void show_pid_array(int pids[], unsigned n_pids, const char *prefix, unsi
9fc0f6
         unsigned i, m, pid_width;
9fc0f6
         pid_t biggest = 0;
9fc0f6
 
9fc0f6
+        assert(n_pids > 0);
9fc0f6
+
9fc0f6
         /* Filter duplicates */
9fc0f6
         m = 0;
9fc0f6
         for (i = 0; i < n_pids; i++) {