richardphibel / rpms / libdnf

Forked from rpms/libdnf 2 years ago
Clone
2e24b4
From eb7217d0a71b92ac0d8c3773caa1a2d3a2c20071 Mon Sep 17 00:00:00 2001
2e24b4
From: Jaroslav Mracek <jmracek@redhat.com>
2e24b4
Date: Thu, 13 May 2021 09:10:42 +0200
2e24b4
Subject: [PATCH 19/19] Remove redundant test
2e24b4
2e24b4
The test is identical to
2e24b4
testGetApplicablePackagesMultipleApplicableCollections().
2e24b4
---
2e24b4
 tests/libdnf/sack/AdvisoryTest.cpp | 11 -----------
2e24b4
 tests/libdnf/sack/AdvisoryTest.hpp |  2 --
2e24b4
 2 files changed, 13 deletions(-)
2e24b4
2e24b4
diff --git a/tests/libdnf/sack/AdvisoryTest.cpp b/tests/libdnf/sack/AdvisoryTest.cpp
2e24b4
index 1abf1a95..f5892634 100644
2e24b4
--- a/tests/libdnf/sack/AdvisoryTest.cpp
2e24b4
+++ b/tests/libdnf/sack/AdvisoryTest.cpp
2e24b4
@@ -91,17 +91,6 @@ void AdvisoryTest::testGetPackages()
2e24b4
     CPPUNIT_ASSERT(pkgsvector.size() == 4);
2e24b4
 }
2e24b4
 
2e24b4
-void AdvisoryTest::testGetApplicablePackagesModulesNotSetup()
2e24b4
-{
2e24b4
-    std::vector<libdnf::AdvisoryPkg> pkgsvector;
2e24b4
-
2e24b4
-    // When modules are not setup all advisory collections are applicable and we get all packages
2e24b4
-    advisory->getApplicablePackages(pkgsvector);
2e24b4
-    CPPUNIT_ASSERT_EQUAL(2, static_cast<int>(pkgsvector.size()));
2e24b4
-    CPPUNIT_ASSERT(!g_strcmp0(pkgsvector[0].getNameString(), "test-perl-DBI"));
2e24b4
-    CPPUNIT_ASSERT(!g_strcmp0(pkgsvector[1].getNameString(), "not-present"));
2e24b4
-}
2e24b4
-
2e24b4
 void AdvisoryTest::testGetApplicablePackagesModulesSetupNoneEnabled()
2e24b4
 {
2e24b4
     std::vector<libdnf::AdvisoryPkg> pkgsvector;
2e24b4
diff --git a/tests/libdnf/sack/AdvisoryTest.hpp b/tests/libdnf/sack/AdvisoryTest.hpp
2e24b4
index 6eb25a57..cb0d8c05 100644
2e24b4
--- a/tests/libdnf/sack/AdvisoryTest.hpp
2e24b4
+++ b/tests/libdnf/sack/AdvisoryTest.hpp
2e24b4
@@ -19,7 +19,6 @@ class AdvisoryTest : public CppUnit::TestCase
2e24b4
         CPPUNIT_TEST(testGetSeverity);
2e24b4
         CPPUNIT_TEST(testGetTitle);
2e24b4
         CPPUNIT_TEST(testGetPackages);
2e24b4
-        CPPUNIT_TEST(testGetApplicablePackagesModulesNotSetup);
2e24b4
         CPPUNIT_TEST(testGetApplicablePackagesModulesSetupNoneEnabled);
2e24b4
         CPPUNIT_TEST(testGetApplicablePackagesOneApplicableCollection);
2e24b4
         CPPUNIT_TEST(testGetApplicablePackagesMultipleApplicableCollections);
2e24b4
@@ -38,7 +37,6 @@ public:
2e24b4
     void testGetSeverity();
2e24b4
     void testGetTitle();
2e24b4
     void testGetPackages();
2e24b4
-    void testGetApplicablePackagesModulesNotSetup();
2e24b4
     void testGetApplicablePackagesModulesSetupNoneEnabled();
2e24b4
     void testGetApplicablePackagesOneApplicableCollection();
2e24b4
     void testGetApplicablePackagesMultipleApplicableCollections();
2e24b4
-- 
2e24b4
2.31.1
2e24b4