|
 |
379fd8 |
From eb7217d0a71b92ac0d8c3773caa1a2d3a2c20071 Mon Sep 17 00:00:00 2001
|
|
|
379fd8 |
From: Jaroslav Mracek <jmracek@redhat.com>
|
|
|
379fd8 |
Date: Thu, 13 May 2021 09:10:42 +0200
|
|
|
379fd8 |
Subject: [PATCH 19/19] Remove redundant test
|
|
|
379fd8 |
|
|
|
379fd8 |
The test is identical to
|
|
|
379fd8 |
testGetApplicablePackagesMultipleApplicableCollections().
|
|
|
379fd8 |
---
|
|
|
379fd8 |
tests/libdnf/sack/AdvisoryTest.cpp | 11 -----------
|
|
|
379fd8 |
tests/libdnf/sack/AdvisoryTest.hpp | 2 --
|
|
|
379fd8 |
2 files changed, 13 deletions(-)
|
|
|
379fd8 |
|
|
|
379fd8 |
diff --git a/tests/libdnf/sack/AdvisoryTest.cpp b/tests/libdnf/sack/AdvisoryTest.cpp
|
|
|
379fd8 |
index 1abf1a95..f5892634 100644
|
|
|
379fd8 |
--- a/tests/libdnf/sack/AdvisoryTest.cpp
|
|
|
379fd8 |
+++ b/tests/libdnf/sack/AdvisoryTest.cpp
|
|
|
379fd8 |
@@ -91,17 +91,6 @@ void AdvisoryTest::testGetPackages()
|
|
|
379fd8 |
CPPUNIT_ASSERT(pkgsvector.size() == 4);
|
|
|
379fd8 |
}
|
|
|
379fd8 |
|
|
|
379fd8 |
-void AdvisoryTest::testGetApplicablePackagesModulesNotSetup()
|
|
|
379fd8 |
-{
|
|
|
379fd8 |
- std::vector<libdnf::AdvisoryPkg> pkgsvector;
|
|
|
379fd8 |
-
|
|
|
379fd8 |
- // When modules are not setup all advisory collections are applicable and we get all packages
|
|
|
379fd8 |
- advisory->getApplicablePackages(pkgsvector);
|
|
|
379fd8 |
- CPPUNIT_ASSERT_EQUAL(2, static_cast<int>(pkgsvector.size()));
|
|
|
379fd8 |
- CPPUNIT_ASSERT(!g_strcmp0(pkgsvector[0].getNameString(), "test-perl-DBI"));
|
|
|
379fd8 |
- CPPUNIT_ASSERT(!g_strcmp0(pkgsvector[1].getNameString(), "not-present"));
|
|
|
379fd8 |
-}
|
|
|
379fd8 |
-
|
|
|
379fd8 |
void AdvisoryTest::testGetApplicablePackagesModulesSetupNoneEnabled()
|
|
|
379fd8 |
{
|
|
|
379fd8 |
std::vector<libdnf::AdvisoryPkg> pkgsvector;
|
|
|
379fd8 |
diff --git a/tests/libdnf/sack/AdvisoryTest.hpp b/tests/libdnf/sack/AdvisoryTest.hpp
|
|
|
379fd8 |
index 6eb25a57..cb0d8c05 100644
|
|
|
379fd8 |
--- a/tests/libdnf/sack/AdvisoryTest.hpp
|
|
|
379fd8 |
+++ b/tests/libdnf/sack/AdvisoryTest.hpp
|
|
|
379fd8 |
@@ -19,7 +19,6 @@ class AdvisoryTest : public CppUnit::TestCase
|
|
|
379fd8 |
CPPUNIT_TEST(testGetSeverity);
|
|
|
379fd8 |
CPPUNIT_TEST(testGetTitle);
|
|
|
379fd8 |
CPPUNIT_TEST(testGetPackages);
|
|
|
379fd8 |
- CPPUNIT_TEST(testGetApplicablePackagesModulesNotSetup);
|
|
|
379fd8 |
CPPUNIT_TEST(testGetApplicablePackagesModulesSetupNoneEnabled);
|
|
|
379fd8 |
CPPUNIT_TEST(testGetApplicablePackagesOneApplicableCollection);
|
|
|
379fd8 |
CPPUNIT_TEST(testGetApplicablePackagesMultipleApplicableCollections);
|
|
|
379fd8 |
@@ -38,7 +37,6 @@ public:
|
|
|
379fd8 |
void testGetSeverity();
|
|
|
379fd8 |
void testGetTitle();
|
|
|
379fd8 |
void testGetPackages();
|
|
|
379fd8 |
- void testGetApplicablePackagesModulesNotSetup();
|
|
|
379fd8 |
void testGetApplicablePackagesModulesSetupNoneEnabled();
|
|
|
379fd8 |
void testGetApplicablePackagesOneApplicableCollection();
|
|
|
379fd8 |
void testGetApplicablePackagesMultipleApplicableCollections();
|
|
|
379fd8 |
--
|
|
|
379fd8 |
2.31.1
|
|
|
379fd8 |
|