From de25a355f4b5a867264fd0d1686ca41f47881221 Mon Sep 17 00:00:00 2001 Message-Id: From: Cole Robinson Date: Tue, 11 Jul 2017 10:57:45 +0200 Subject: [PATCH] tests: qemuxml2argv: Drop old style serial testing These tests are exercising old style -serial command lines. That code will soon be removed, so drop these tests. Reviewed-by: Andrea Bolognani Signed-off-by: Cole Robinson (cherry picked from commit 9818c08eed7d28ff36a618f874ed75becfaf29ac) Conflicts: * tests/qemuxml2argvdata/qemuxml2argv-serial-dev.args, tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml, tests/qemuxml2argvdata/qemuxml2argv-serial-file.args, tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml, tests/qemuxml2argvdata/qemuxml2argv-serial-many.args, tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml, tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.args, tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml, tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.args, tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml, tests/qemuxml2argvdata/qemuxml2argv-serial-udp.args, tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml, tests/qemuxml2argvdata/qemuxml2argv-serial-unix.args, tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml, tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args, tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml: caused by e6e26a899df05e3c1b36c40eef5ba0a4b1e36f95 not being in the tree; resolved by removing the files regardless of their contents. Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1435681 Signed-off-by: Andrea Bolognani Signed-off-by: Jiri Denemark --- .../qemuxml2argvdata/qemuxml2argv-serial-dev.args | 24 ------------ tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml | 38 ------------------- .../qemuxml2argvdata/qemuxml2argv-serial-file.args | 24 ------------ .../qemuxml2argvdata/qemuxml2argv-serial-file.xml | 38 ------------------- .../qemuxml2argvdata/qemuxml2argv-serial-many.args | 25 ------------ .../qemuxml2argvdata/qemuxml2argv-serial-many.xml | 40 -------------------- .../qemuxml2argv-serial-tcp-telnet.args | 24 ------------ .../qemuxml2argv-serial-tcp-telnet.xml | 40 -------------------- .../qemuxml2argvdata/qemuxml2argv-serial-tcp.args | 24 ------------ tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml | 40 -------------------- .../qemuxml2argvdata/qemuxml2argv-serial-udp.args | 25 ------------ tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml | 44 ---------------------- .../qemuxml2argvdata/qemuxml2argv-serial-unix.args | 24 ------------ .../qemuxml2argvdata/qemuxml2argv-serial-unix.xml | 38 ------------------- tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args | 24 ------------ tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml | 36 ------------------ tests/qemuxml2argvtest.c | 9 ----- tests/qemuxml2xmltest.c | 9 ----- 18 files changed, 526 deletions(-) delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-dev.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-file.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-many.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-udp.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-unix.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.args deleted file mode 100644 index 609f34a51d..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.args +++ /dev/null @@ -1,24 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M pc \ --m 214 \ --smp 1,sockets=1,cores=1,threads=1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --nodefaults \ --chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ -server,nowait \ --mon chardev=charmonitor,id=monitor,mode=readline \ --no-acpi \ --boot c \ --usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ --serial /dev/ttyS2 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml b/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml deleted file mode 100644 index aa03ab814e..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml +++ /dev/null @@ -1,38 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219100 - 219100 - 1 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu - - - - -
- - - - - - - - - - - - - - - - - diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-file.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-file.args deleted file mode 100644 index aa4ca764fd..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-file.args +++ /dev/null @@ -1,24 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M pc \ --m 214 \ --smp 1,sockets=1,cores=1,threads=1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --nodefaults \ --chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ -server,nowait \ --mon chardev=charmonitor,id=monitor,mode=readline \ --no-acpi \ --boot c \ --usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ --serial file:/tmp/serial.log diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml b/tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml deleted file mode 100644 index a7596ad004..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml +++ /dev/null @@ -1,38 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219136 - 219136 - 1 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu - - - - -
- - - - - - - - - - - - - - - - - diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-many.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-many.args deleted file mode 100644 index 99ad62b046..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-many.args +++ /dev/null @@ -1,25 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M pc \ --m 214 \ --smp 1,sockets=1,cores=1,threads=1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --nodefaults \ --chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ -server,nowait \ --mon chardev=charmonitor,id=monitor,mode=readline \ --no-acpi \ --boot c \ --usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ --serial pty \ --serial file:/tmp/serial.log diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml b/tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml deleted file mode 100644 index 75d77ade24..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml +++ /dev/null @@ -1,40 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219136 - 219136 - 1 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu - - - - -
- - - - - - - - - - - - - - - - - - - diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.args deleted file mode 100644 index 7d6ac361d7..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.args +++ /dev/null @@ -1,24 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M pc \ --m 214 \ --smp 1,sockets=1,cores=1,threads=1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --nodefaults \ --chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ -server,nowait \ --mon chardev=charmonitor,id=monitor,mode=readline \ --no-acpi \ --boot c \ --usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ --serial telnet:127.0.0.1:9999,server,nowait diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml deleted file mode 100644 index 48037bb19a..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml +++ /dev/null @@ -1,40 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219100 - 219100 - 1 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu - - - - -
- - - - - - - - - - - - - - - - - - - diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.args deleted file mode 100644 index ec000e9949..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.args +++ /dev/null @@ -1,24 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M pc \ --m 214 \ --smp 1,sockets=1,cores=1,threads=1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --nodefaults \ --chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ -server,nowait \ --mon chardev=charmonitor,id=monitor,mode=readline \ --no-acpi \ --boot c \ --usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ --serial tcp:127.0.0.1:9999 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml deleted file mode 100644 index ba0c2895f5..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml +++ /dev/null @@ -1,40 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219100 - 219100 - 1 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu - - - - -
- - - - - - - - - - - - - - - - - - - diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.args deleted file mode 100644 index 4731e28490..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.args +++ /dev/null @@ -1,25 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M pc \ --m 214 \ --smp 1,sockets=1,cores=1,threads=1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --nodefaults \ --chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ -server,nowait \ --mon chardev=charmonitor,id=monitor,mode=readline \ --no-acpi \ --boot c \ --usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ --serial udp:127.0.0.1:9998@127.0.0.1:9999 \ --serial udp::9999@:0 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml b/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml deleted file mode 100644 index 61661e7c4f..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml +++ /dev/null @@ -1,44 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219136 - 219136 - 1 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu - - - - -
- - - - - - - - - - - - - - - - - - - - - - - diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.args deleted file mode 100644 index 7828afcdc3..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.args +++ /dev/null @@ -1,24 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M pc \ --m 214 \ --smp 1,sockets=1,cores=1,threads=1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --nodefaults \ --chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ -server,nowait \ --mon chardev=charmonitor,id=monitor,mode=readline \ --no-acpi \ --boot c \ --usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ --serial unix:/tmp/serial.sock diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml b/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml deleted file mode 100644 index 6789e2da1c..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml +++ /dev/null @@ -1,38 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219136 - 219136 - 1 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu - - - - -
- - - - - - - - - - - - - - - - - diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args deleted file mode 100644 index 760da03dff..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args +++ /dev/null @@ -1,24 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M pc \ --m 214 \ --smp 1,sockets=1,cores=1,threads=1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --nodefaults \ --chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ -server,nowait \ --mon chardev=charmonitor,id=monitor,mode=readline \ --no-acpi \ --boot c \ --usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ --serial vc diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml b/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml deleted file mode 100644 index 69ce1ba224..0000000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml +++ /dev/null @@ -1,36 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219100 - 219100 - 1 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu - - - - -
- - - - - - - - - - - - - - - diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 3e029224dc..f647251e8e 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1176,17 +1176,8 @@ mymain(void) QEMU_CAPS_DEVICE_VFIO_PCI); - DO_TEST("serial-vc", NONE); - DO_TEST("serial-pty", NONE); - DO_TEST("serial-dev", NONE); - DO_TEST("serial-file", NONE); DO_TEST("serial-file-log", QEMU_CAPS_CHARDEV, QEMU_CAPS_CHARDEV_FILE_APPEND, QEMU_CAPS_CHARDEV_LOGFILE); - DO_TEST("serial-unix", NONE); - DO_TEST("serial-tcp", NONE); - DO_TEST("serial-udp", NONE); - DO_TEST("serial-tcp-telnet", NONE); - DO_TEST("serial-many", NONE); DO_TEST("serial-spiceport", QEMU_CAPS_CHARDEV, QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_DEVICE_VIDEO_PRIMARY, diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index fe4fd6afa2..73bc87f87c 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -536,17 +536,8 @@ mymain(void) DO_TEST("net-mtu", NONE); DO_TEST("net-coalesce", NONE); - DO_TEST("serial-vc", NONE); - DO_TEST("serial-pty", NONE); - DO_TEST("serial-dev", NONE); - DO_TEST("serial-file", NONE); - DO_TEST("serial-unix", NONE); - DO_TEST("serial-tcp", NONE); - DO_TEST("serial-udp", NONE); - DO_TEST("serial-tcp-telnet", NONE); DO_TEST("serial-tcp-tlsx509-chardev", NONE); DO_TEST("serial-tcp-tlsx509-chardev-notls", NONE); - DO_TEST("serial-many", NONE); DO_TEST("serial-spiceport", NONE); DO_TEST("serial-spiceport-nospice", NONE); DO_TEST("console-compat", NONE); -- 2.13.3