From 9787da1f764c3a2fcccaf5f4dd5227dab5abb82d Mon Sep 17 00:00:00 2001 Message-Id: <9787da1f764c3a2fcccaf5f4dd5227dab5abb82d.1379597660.git.jdenemar@redhat.com> From: Peter Krempa Date: Tue, 17 Sep 2013 10:19:33 +0200 Subject: [PATCH] qemu: Use "migratable" XML definition when doing external checkpoints In the original implementation of external checkpoints I've mistakenly used the live definition to be stored in the save image. The normal approach is to use the "migratable" definition. This was discovered when commit 07966f6a8b5ccb5bb4c716b25deb8ba2e572cc67 changed the behavior to use a converted XML from the user to do the compatibility check to fix problem when using the regular machine saving. As the previous patch added a compatibility layer, we can now change the type of the XML in the image. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1008340 (cherry picked from commit 1b7bfa65e36996fc3a204452d2a844ab9f4b52b3) --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9b9732d..71d773c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12427,7 +12427,7 @@ qemuDomainSnapshotCreateActiveExternal(virConnectPtr conn, JOB_MASK(QEMU_JOB_SUSPEND) | JOB_MASK(QEMU_JOB_MIGRATION_OP)); - if (!(xml = qemuDomainDefFormatLive(driver, vm->def, true, false))) + if (!(xml = qemuDomainDefFormatLive(driver, vm->def, true, true))) goto endjob; if ((ret = qemuDomainSaveMemory(driver, vm, snap->def->file, -- 1.8.3.2