From 07cefaf0d0ab324d95e4e0cc1f75004dec487365 Mon Sep 17 00:00:00 2001 Message-Id: <07cefaf0d0ab324d95e4e0cc1f75004dec487365.1381871411.git.jdenemar@redhat.com> From: Michal Privoznik Date: Wed, 2 Oct 2013 11:04:07 +0200 Subject: [PATCH] virNetDevBandwidthEqual: Make it more robust https://bugzilla.redhat.com/show_bug.cgi?id=1014503 So far the virNetDevBandwidthEqual() expected both ->in and ->out items to be allocated for both @a and @b compared. This is not necessary true for all our code. For instance, running 'update-device' twice over a NIC with the very same XML results in SIGSEGV-ing in this function. Signed-off-by: Michal Privoznik (cherry picked from commit ee02fbc8e4a24c1347761ceff2ddb2c108e9611c) Signed-off-by: Jiri Denemark --- src/util/virnetdevbandwidth.c | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c index 42b0a50..17f4fa3 100644 --- a/src/util/virnetdevbandwidth.c +++ b/src/util/virnetdevbandwidth.c @@ -335,16 +335,30 @@ virNetDevBandwidthEqual(virNetDevBandwidthPtr a, return false; /* in */ - if (a->in->average != b->in->average || - a->in->peak != b->in->peak || - a->in->burst != b->in->burst) + if (a->in) { + if (!b->in) + return false; + + if (a->in->average != b->in->average || + a->in->peak != b->in->peak || + a->in->burst != b->in->burst) + return false; + } else if (b->in) { return false; + } /*out*/ - if (a->out->average != b->out->average || - a->out->peak != b->out->peak || - a->out->burst != b->out->burst) + if (a->out) { + if (!b->out) + return false; + + if (a->out->average != b->out->average || + a->out->peak != b->out->peak || + a->out->burst != b->out->burst) + return false; + } else if (b->out) { return false; + } return true; } -- 1.8.3.2