From 405530fa1be17ff5b8dcff6785b67c63eebf49f7 Mon Sep 17 00:00:00 2001 Message-Id: <405530fa1be17ff5b8dcff6785b67c63eebf49f7.1379193141.git.jdenemar@redhat.com> From: "Liuji (Jeremy)" Date: Wed, 11 Sep 2013 09:58:51 +0200 Subject: [PATCH] virDomainDefParseXML: set the argument of virBitmapFree to NULL after calling virBitmapFree https://bugzilla.redhat.com/show_bug.cgi?id=1006722 After freeing the bitmap pointer, it must set the pointer to NULL. This will avoid any other use of the freed memory of the bitmap pointer. https://bugzilla.redhat.com/show_bug.cgi?id=1006710 Signed-off-by: Liuji (Jeremy) (cherry picked from commit ef5d51d491356f1f4287aa3a8b908b183b6dd9aa) --- src/conf/domain_conf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d6b4ea7..566940c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11251,8 +11251,10 @@ virDomainDefParseXML(xmlDocPtr xml, } /* Ignore 'nodeset' if 'placement' is 'auto' finally */ - if (placement_mode == VIR_NUMA_TUNE_MEM_PLACEMENT_MODE_AUTO) + if (placement_mode == VIR_NUMA_TUNE_MEM_PLACEMENT_MODE_AUTO) { virBitmapFree(def->numatune.memory.nodemask); + def->numatune.memory.nodemask = NULL; + } /* Copy 'placement' of to if its 'placement' * is not specified and 'placement' of is specified. -- 1.8.3.2