|
 |
c480ed |
From 2b04ec4cfae111f315514395030ab1106b6370da Mon Sep 17 00:00:00 2001
|
|
|
c480ed |
Message-Id: <2b04ec4cfae111f315514395030ab1106b6370da@dist-git>
|
|
|
c480ed |
From: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
|
|
|
c480ed |
Date: Fri, 16 Aug 2019 16:01:55 +0200
|
|
|
c480ed |
Subject: [PATCH] virdbus: Grab a ref as long as the while loop is executed
|
|
|
c480ed |
MIME-Version: 1.0
|
|
|
c480ed |
Content-Type: text/plain; charset=UTF-8
|
|
|
c480ed |
Content-Transfer-Encoding: 8bit
|
|
|
c480ed |
|
|
|
c480ed |
Grab a ref for info->bus (a DBus connection) as long as the while loop
|
|
|
c480ed |
is running. With the grabbed reference it is ensured that info->bus
|
|
|
c480ed |
isn't freed as long as the while loop is executed. This is necessary
|
|
|
c480ed |
as it's allowed to drop the last ref for the bus connection in a
|
|
|
c480ed |
handler.
|
|
|
c480ed |
|
|
|
c480ed |
There was already a bug of this kind in libdbus itself:
|
|
|
c480ed |
https://bugs.freedesktop.org/show_bug.cgi?id=15635.
|
|
|
c480ed |
|
|
|
c480ed |
Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
|
|
|
c480ed |
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
|
|
|
c480ed |
Reviewed-by: John Ferlan <jferlan@redhat.com>
|
|
|
c480ed |
(cherry picked from commit 6707ffd11c1d8940ca7dfa7aaef707a60ef6756e)
|
|
|
c480ed |
|
|
|
c480ed |
RHEL-8.1.0: https://bugzilla.redhat.com/show_bug.cgi?id=1741900
|
|
|
c480ed |
Signed-off-by: Ján Tomko <jtomko@redhat.com>
|
|
|
c480ed |
Message-Id: <9656cea8218d901d5e44a157362cd0f009ff1a7d.1565964111.git.jtomko@redhat.com>
|
|
|
c480ed |
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
c480ed |
---
|
|
|
c480ed |
src/util/virdbus.c | 2 ++
|
|
|
c480ed |
1 file changed, 2 insertions(+)
|
|
|
c480ed |
|
|
|
c480ed |
diff --git a/src/util/virdbus.c b/src/util/virdbus.c
|
|
|
c480ed |
index ba8b684f17..d0e2c76e48 100644
|
|
|
c480ed |
--- a/src/util/virdbus.c
|
|
|
c480ed |
+++ b/src/util/virdbus.c
|
|
|
c480ed |
@@ -198,8 +198,10 @@ static void virDBusWatchCallback(int fdatch ATTRIBUTE_UNUSED,
|
|
|
c480ed |
|
|
|
c480ed |
(void)dbus_watch_handle(watch, dbus_flags);
|
|
|
c480ed |
|
|
|
c480ed |
+ dbus_connection_ref(info->bus);
|
|
|
c480ed |
while (dbus_connection_dispatch(info->bus) == DBUS_DISPATCH_DATA_REMAINS)
|
|
|
c480ed |
/* keep dispatching while data remains */;
|
|
|
c480ed |
+ dbus_connection_unref(info->bus);
|
|
|
c480ed |
}
|
|
|
c480ed |
|
|
|
c480ed |
|
|
|
c480ed |
--
|
|
|
c480ed |
2.22.1
|
|
|
c480ed |
|