render / rpms / libvirt

Forked from rpms/libvirt 5 months ago
Clone
Pablo Greco 40546a
From 518ed664601680039546889ea3ebb9a957f26e16 Mon Sep 17 00:00:00 2001
Pablo Greco 40546a
Message-Id: <518ed664601680039546889ea3ebb9a957f26e16@dist-git>
Pablo Greco 40546a
From: Pavel Hrdina <phrdina@redhat.com>
Pablo Greco 40546a
Date: Mon, 1 Jul 2019 17:07:48 +0200
Pablo Greco 40546a
Subject: [PATCH] vircgroup: introduce virCgroupV2(Set|Get)CpuCfsQuota
Pablo Greco 40546a
MIME-Version: 1.0
Pablo Greco 40546a
Content-Type: text/plain; charset=UTF-8
Pablo Greco 40546a
Content-Transfer-Encoding: 8bit
Pablo Greco 40546a
Pablo Greco 40546a
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Pablo Greco 40546a
(cherry picked from commit 8e2c887ffa552b59a3dd80fa73ee60791c960565)
Pablo Greco 40546a
Pablo Greco 40546a
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1689297
Pablo Greco 40546a
Pablo Greco 40546a
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Pablo Greco 40546a
Message-Id: <7fe344c65f7394026a2d9feb45920cd177f5f71c.1561993100.git.phrdina@redhat.com>
Pablo Greco 40546a
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Pablo Greco 40546a
---
Pablo Greco 40546a
 src/util/vircgroupv2.c | 52 ++++++++++++++++++++++++++++++++++++++++++
Pablo Greco 40546a
 1 file changed, 52 insertions(+)
Pablo Greco 40546a
Pablo Greco 40546a
diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c
Pablo Greco 40546a
index 876785e4e1..a0a7e55493 100644
Pablo Greco 40546a
--- a/src/util/vircgroupv2.c
Pablo Greco 40546a
+++ b/src/util/vircgroupv2.c
Pablo Greco 40546a
@@ -1391,6 +1391,56 @@ virCgroupV2GetCpuCfsPeriod(virCgroupPtr group,
Pablo Greco 40546a
 }
Pablo Greco 40546a
 
Pablo Greco 40546a
 
Pablo Greco 40546a
+static int
Pablo Greco 40546a
+virCgroupV2SetCpuCfsQuota(virCgroupPtr group,
Pablo Greco 40546a
+                          long long cfs_quota)
Pablo Greco 40546a
+{
Pablo Greco 40546a
+    /* The cfs_quota should be greater or equal than 1ms */
Pablo Greco 40546a
+    if (cfs_quota >= 0 &&
Pablo Greco 40546a
+        (cfs_quota < 1000 ||
Pablo Greco 40546a
+         cfs_quota > ULLONG_MAX / 1000)) {
Pablo Greco 40546a
+        virReportError(VIR_ERR_INVALID_ARG,
Pablo Greco 40546a
+                       _("cfs_quota '%lld' must be in range (1000, %llu)"),
Pablo Greco 40546a
+                       cfs_quota, ULLONG_MAX / 1000);
Pablo Greco 40546a
+        return -1;
Pablo Greco 40546a
+    }
Pablo Greco 40546a
+
Pablo Greco 40546a
+    if (cfs_quota == ULLONG_MAX / 1000) {
Pablo Greco 40546a
+        return virCgroupSetValueStr(group,
Pablo Greco 40546a
+                                    VIR_CGROUP_CONTROLLER_CPU,
Pablo Greco 40546a
+                                    "cpu.max", "max");
Pablo Greco 40546a
+    }
Pablo Greco 40546a
+
Pablo Greco 40546a
+    return virCgroupSetValueI64(group,
Pablo Greco 40546a
+                                VIR_CGROUP_CONTROLLER_CPU,
Pablo Greco 40546a
+                                "cpu.max", cfs_quota);
Pablo Greco 40546a
+}
Pablo Greco 40546a
+
Pablo Greco 40546a
+
Pablo Greco 40546a
+static int
Pablo Greco 40546a
+virCgroupV2GetCpuCfsQuota(virCgroupPtr group,
Pablo Greco 40546a
+                          long long *cfs_quota)
Pablo Greco 40546a
+{
Pablo Greco 40546a
+    VIR_AUTOFREE(char *) str = NULL;
Pablo Greco 40546a
+
Pablo Greco 40546a
+    if (virCgroupGetValueStr(group, VIR_CGROUP_CONTROLLER_CPU,
Pablo Greco 40546a
+                             "cpu.max", &str) < 0) {
Pablo Greco 40546a
+        return -1;
Pablo Greco 40546a
+    }
Pablo Greco 40546a
+
Pablo Greco 40546a
+    if (STREQLEN(str, "max", 3))
Pablo Greco 40546a
+        *cfs_quota = ULLONG_MAX / 1000;
Pablo Greco 40546a
+
Pablo Greco 40546a
+    if (virStrToLong_ll(str, NULL, 10, cfs_quota) < 0) {
Pablo Greco 40546a
+        virReportError(VIR_ERR_INTERNAL_ERROR,
Pablo Greco 40546a
+                       _("Failed to parse value '%s' from cpu.max."), str);
Pablo Greco 40546a
+        return -1;
Pablo Greco 40546a
+    }
Pablo Greco 40546a
+
Pablo Greco 40546a
+    return 0;
Pablo Greco 40546a
+}
Pablo Greco 40546a
+
Pablo Greco 40546a
+
Pablo Greco 40546a
 virCgroupBackend virCgroupV2Backend = {
Pablo Greco 40546a
     .type = VIR_CGROUP_BACKEND_TYPE_V2,
Pablo Greco 40546a
 
Pablo Greco 40546a
@@ -1443,6 +1493,8 @@ virCgroupBackend virCgroupV2Backend = {
Pablo Greco 40546a
     .getCpuShares = virCgroupV2GetCpuShares,
Pablo Greco 40546a
     .setCpuCfsPeriod = virCgroupV2SetCpuCfsPeriod,
Pablo Greco 40546a
     .getCpuCfsPeriod = virCgroupV2GetCpuCfsPeriod,
Pablo Greco 40546a
+    .setCpuCfsQuota = virCgroupV2SetCpuCfsQuota,
Pablo Greco 40546a
+    .getCpuCfsQuota = virCgroupV2GetCpuCfsQuota,
Pablo Greco 40546a
 };
Pablo Greco 40546a
 
Pablo Greco 40546a
 
Pablo Greco 40546a
-- 
Pablo Greco 40546a
2.22.0
Pablo Greco 40546a