|
 |
c313de |
From e8af2c7b172894ae3cfacd6de98b01af63947b05 Mon Sep 17 00:00:00 2001
|
|
|
c313de |
Message-Id: <e8af2c7b172894ae3cfacd6de98b01af63947b05@dist-git>
|
|
|
c313de |
From: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c313de |
Date: Mon, 1 Jul 2019 17:07:04 +0200
|
|
|
c313de |
Subject: [PATCH] vircgroup: extract virCgroupV1(Set|Get)CpusetMemoryMigrate
|
|
|
c313de |
MIME-Version: 1.0
|
|
|
c313de |
Content-Type: text/plain; charset=UTF-8
|
|
|
c313de |
Content-Transfer-Encoding: 8bit
|
|
|
c313de |
|
|
|
c313de |
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
|
|
|
c313de |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
c313de |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c313de |
(cherry picked from commit 7f3aedacac33fd4775d7def3734422108d6cd93e)
|
|
|
c313de |
|
|
|
c313de |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1689297
|
|
|
c313de |
|
|
|
c313de |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c313de |
Message-Id: <0067ed0a20d90451ab63112dc273ddb8344569ca.1561993100.git.phrdina@redhat.com>
|
|
|
c313de |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
c313de |
---
|
|
|
c313de |
src/util/vircgroup.c | 13 ++-----------
|
|
|
c313de |
src/util/vircgroupbackend.h | 10 ++++++++++
|
|
|
c313de |
src/util/vircgroupv1.c | 27 +++++++++++++++++++++++++++
|
|
|
c313de |
3 files changed, 39 insertions(+), 11 deletions(-)
|
|
|
c313de |
|
|
|
c313de |
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
|
|
|
c313de |
index 700e597157..1a5ed472df 100644
|
|
|
c313de |
--- a/src/util/vircgroup.c
|
|
|
c313de |
+++ b/src/util/vircgroup.c
|
|
|
c313de |
@@ -1742,10 +1742,7 @@ virCgroupGetCpusetMems(virCgroupPtr group, char **mems)
|
|
|
c313de |
int
|
|
|
c313de |
virCgroupSetCpusetMemoryMigrate(virCgroupPtr group, bool migrate)
|
|
|
c313de |
{
|
|
|
c313de |
- return virCgroupSetValueStr(group,
|
|
|
c313de |
- VIR_CGROUP_CONTROLLER_CPUSET,
|
|
|
c313de |
- "cpuset.memory_migrate",
|
|
|
c313de |
- migrate ? "1" : "0");
|
|
|
c313de |
+ VIR_CGROUP_BACKEND_CALL(group, setCpusetMemoryMigrate, -1, migrate);
|
|
|
c313de |
}
|
|
|
c313de |
|
|
|
c313de |
|
|
|
c313de |
@@ -1760,13 +1757,7 @@ virCgroupSetCpusetMemoryMigrate(virCgroupPtr group, bool migrate)
|
|
|
c313de |
int
|
|
|
c313de |
virCgroupGetCpusetMemoryMigrate(virCgroupPtr group, bool *migrate)
|
|
|
c313de |
{
|
|
|
c313de |
- unsigned long long value = 0;
|
|
|
c313de |
- int ret = virCgroupGetValueU64(group,
|
|
|
c313de |
- VIR_CGROUP_CONTROLLER_CPUSET,
|
|
|
c313de |
- "cpuset.memory_migrate",
|
|
|
c313de |
- &value);
|
|
|
c313de |
- *migrate = !!value;
|
|
|
c313de |
- return ret;
|
|
|
c313de |
+ VIR_CGROUP_BACKEND_CALL(group, getCpusetMemoryMigrate, -1, migrate);
|
|
|
c313de |
}
|
|
|
c313de |
|
|
|
c313de |
|
|
|
c313de |
diff --git a/src/util/vircgroupbackend.h b/src/util/vircgroupbackend.h
|
|
|
c313de |
index 35221e90df..d4e4c4a6cc 100644
|
|
|
c313de |
--- a/src/util/vircgroupbackend.h
|
|
|
c313de |
+++ b/src/util/vircgroupbackend.h
|
|
|
c313de |
@@ -332,6 +332,14 @@ typedef int
|
|
|
c313de |
(*virCgroupGetCpusetMemsCB)(virCgroupPtr group,
|
|
|
c313de |
char **mems);
|
|
|
c313de |
|
|
|
c313de |
+typedef int
|
|
|
c313de |
+(*virCgroupSetCpusetMemoryMigrateCB)(virCgroupPtr group,
|
|
|
c313de |
+ bool migrate);
|
|
|
c313de |
+
|
|
|
c313de |
+typedef int
|
|
|
c313de |
+(*virCgroupGetCpusetMemoryMigrateCB)(virCgroupPtr group,
|
|
|
c313de |
+ bool *migrate);
|
|
|
c313de |
+
|
|
|
c313de |
struct _virCgroupBackend {
|
|
|
c313de |
virCgroupBackendType type;
|
|
|
c313de |
|
|
|
c313de |
@@ -404,6 +412,8 @@ struct _virCgroupBackend {
|
|
|
c313de |
|
|
|
c313de |
virCgroupSetCpusetMemsCB setCpusetMems;
|
|
|
c313de |
virCgroupGetCpusetMemsCB getCpusetMems;
|
|
|
c313de |
+ virCgroupSetCpusetMemoryMigrateCB setCpusetMemoryMigrate;
|
|
|
c313de |
+ virCgroupGetCpusetMemoryMigrateCB getCpusetMemoryMigrate;
|
|
|
c313de |
};
|
|
|
c313de |
typedef struct _virCgroupBackend virCgroupBackend;
|
|
|
c313de |
typedef virCgroupBackend *virCgroupBackendPtr;
|
|
|
c313de |
diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c
|
|
|
c313de |
index be9a6b82b4..3a41899dd8 100644
|
|
|
c313de |
--- a/src/util/vircgroupv1.c
|
|
|
c313de |
+++ b/src/util/vircgroupv1.c
|
|
|
c313de |
@@ -1971,6 +1971,31 @@ virCgroupV1GetCpusetMems(virCgroupPtr group,
|
|
|
c313de |
}
|
|
|
c313de |
|
|
|
c313de |
|
|
|
c313de |
+static int
|
|
|
c313de |
+virCgroupV1SetCpusetMemoryMigrate(virCgroupPtr group,
|
|
|
c313de |
+ bool migrate)
|
|
|
c313de |
+{
|
|
|
c313de |
+ return virCgroupSetValueStr(group,
|
|
|
c313de |
+ VIR_CGROUP_CONTROLLER_CPUSET,
|
|
|
c313de |
+ "cpuset.memory_migrate",
|
|
|
c313de |
+ migrate ? "1" : "0");
|
|
|
c313de |
+}
|
|
|
c313de |
+
|
|
|
c313de |
+
|
|
|
c313de |
+static int
|
|
|
c313de |
+virCgroupV1GetCpusetMemoryMigrate(virCgroupPtr group,
|
|
|
c313de |
+ bool *migrate)
|
|
|
c313de |
+{
|
|
|
c313de |
+ unsigned long long value = 0;
|
|
|
c313de |
+ int ret = virCgroupGetValueU64(group,
|
|
|
c313de |
+ VIR_CGROUP_CONTROLLER_CPUSET,
|
|
|
c313de |
+ "cpuset.memory_migrate",
|
|
|
c313de |
+ &value);
|
|
|
c313de |
+ *migrate = !!value;
|
|
|
c313de |
+ return ret;
|
|
|
c313de |
+}
|
|
|
c313de |
+
|
|
|
c313de |
+
|
|
|
c313de |
virCgroupBackend virCgroupV1Backend = {
|
|
|
c313de |
.type = VIR_CGROUP_BACKEND_TYPE_V1,
|
|
|
c313de |
|
|
|
c313de |
@@ -2041,6 +2066,8 @@ virCgroupBackend virCgroupV1Backend = {
|
|
|
c313de |
|
|
|
c313de |
.setCpusetMems = virCgroupV1SetCpusetMems,
|
|
|
c313de |
.getCpusetMems = virCgroupV1GetCpusetMems,
|
|
|
c313de |
+ .setCpusetMemoryMigrate = virCgroupV1SetCpusetMemoryMigrate,
|
|
|
c313de |
+ .getCpusetMemoryMigrate = virCgroupV1GetCpusetMemoryMigrate,
|
|
|
c313de |
};
|
|
|
c313de |
|
|
|
c313de |
|
|
|
c313de |
--
|
|
|
c313de |
2.22.0
|
|
|
c313de |
|