|
 |
c313de |
From 88322908f3dfad6217b1c2a2a0f8968b079d0795 Mon Sep 17 00:00:00 2001
|
|
|
c313de |
Message-Id: <88322908f3dfad6217b1c2a2a0f8968b079d0795@dist-git>
|
|
|
c313de |
From: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c313de |
Date: Mon, 1 Jul 2019 17:06:00 +0200
|
|
|
c313de |
Subject: [PATCH] vircgroup: Remove virCgroupAddTaskController
|
|
|
c313de |
MIME-Version: 1.0
|
|
|
c313de |
Content-Type: text/plain; charset=UTF-8
|
|
|
c313de |
Content-Transfer-Encoding: 8bit
|
|
|
c313de |
|
|
|
c313de |
There is no need for this function, both of the checks are done
|
|
|
c313de |
later by virCgroupGetControllerPath.
|
|
|
c313de |
|
|
|
c313de |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c313de |
(cherry picked from commit db868852fdb32c76955c925dcbd92b2d6d9bfeb2)
|
|
|
c313de |
|
|
|
c313de |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1689297
|
|
|
c313de |
|
|
|
c313de |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c313de |
Message-Id: <b6c7c27ed52a39343d7d0f14feab71726ff0c279.1561993099.git.phrdina@redhat.com>
|
|
|
c313de |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
c313de |
---
|
|
|
c313de |
src/util/vircgroup.c | 31 +------------------------------
|
|
|
c313de |
1 file changed, 1 insertion(+), 30 deletions(-)
|
|
|
c313de |
|
|
|
c313de |
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
|
|
|
c313de |
index 5adf9d3c11..a94f958d75 100644
|
|
|
c313de |
--- a/src/util/vircgroup.c
|
|
|
c313de |
+++ b/src/util/vircgroup.c
|
|
|
c313de |
@@ -1128,35 +1128,6 @@ virCgroupNew(pid_t pid,
|
|
|
c313de |
}
|
|
|
c313de |
|
|
|
c313de |
|
|
|
c313de |
-/**
|
|
|
c313de |
- * virCgroupAddTaskController:
|
|
|
c313de |
- *
|
|
|
c313de |
- * @group: The cgroup to add a task to
|
|
|
c313de |
- * @pid: The pid of the task to add
|
|
|
c313de |
- * @controller: The cgroup controller to be operated on
|
|
|
c313de |
- *
|
|
|
c313de |
- * Returns: 0 on success or -1 on error
|
|
|
c313de |
- */
|
|
|
c313de |
-static int
|
|
|
c313de |
-virCgroupAddTaskController(virCgroupPtr group, pid_t pid, int controller)
|
|
|
c313de |
-{
|
|
|
c313de |
- if (controller < 0 || controller >= VIR_CGROUP_CONTROLLER_LAST) {
|
|
|
c313de |
- virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
c313de |
- _("Controller %d out of range"), controller);
|
|
|
c313de |
- return -1;
|
|
|
c313de |
- }
|
|
|
c313de |
-
|
|
|
c313de |
- if (!group->controllers[controller].mountPoint) {
|
|
|
c313de |
- virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
c313de |
- _("Controller '%s' not mounted"),
|
|
|
c313de |
- virCgroupControllerTypeToString(controller));
|
|
|
c313de |
- return -1;
|
|
|
c313de |
- }
|
|
|
c313de |
-
|
|
|
c313de |
- return virCgroupSetValueI64(group, controller, "tasks", pid);
|
|
|
c313de |
-}
|
|
|
c313de |
-
|
|
|
c313de |
-
|
|
|
c313de |
static int
|
|
|
c313de |
virCgroupAddTaskInternal(virCgroupPtr group, pid_t pid, bool withSystemd)
|
|
|
c313de |
{
|
|
|
c313de |
@@ -1174,7 +1145,7 @@ virCgroupAddTaskInternal(virCgroupPtr group, pid_t pid, bool withSystemd)
|
|
|
c313de |
if (i == VIR_CGROUP_CONTROLLER_SYSTEMD && !withSystemd)
|
|
|
c313de |
continue;
|
|
|
c313de |
|
|
|
c313de |
- if (virCgroupAddTaskController(group, pid, i) < 0)
|
|
|
c313de |
+ if (virCgroupSetValueI64(group, i, "tasks", pid) < 0)
|
|
|
c313de |
goto cleanup;
|
|
|
c313de |
}
|
|
|
c313de |
|
|
|
c313de |
--
|
|
|
c313de |
2.22.0
|
|
|
c313de |
|