|
 |
99cbc7 |
From 580641d2514592b4e21f49309c9f852165788fc7 Mon Sep 17 00:00:00 2001
|
|
|
99cbc7 |
Message-Id: <580641d2514592b4e21f49309c9f852165788fc7@dist-git>
|
|
|
99cbc7 |
From: Michal Privoznik <mprivozn@redhat.com>
|
|
|
99cbc7 |
Date: Tue, 4 Sep 2018 10:41:02 +0200
|
|
|
99cbc7 |
Subject: [PATCH] virDomainNetDefCheckABIStability: Check for MTU change too
|
|
|
99cbc7 |
MIME-Version: 1.0
|
|
|
99cbc7 |
Content-Type: text/plain; charset=UTF-8
|
|
|
99cbc7 |
Content-Transfer-Encoding: 8bit
|
|
|
99cbc7 |
|
|
|
99cbc7 |
RHEL-7.6: https://bugzilla.redhat.com/show_bug.cgi?id=1623157
|
|
|
99cbc7 |
RHEL-8.0: https://bugzilla.redhat.com/show_bug.cgi?id=1623158
|
|
|
99cbc7 |
|
|
|
99cbc7 |
Changing MTU on a running guest is not possible and trying to do
|
|
|
99cbc7 |
so made us face many problems. That's why we forbid it in
|
|
|
99cbc7 |
5f44d7e357f61f7. However, there is still one possible path where
|
|
|
99cbc7 |
users can sneak in change: migration XML.
|
|
|
99cbc7 |
|
|
|
99cbc7 |
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
99cbc7 |
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
99cbc7 |
(cherry picked from commit 4ea3693104c03ac40a6595f5b9bcda58fa18afe7)
|
|
|
99cbc7 |
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
99cbc7 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
99cbc7 |
---
|
|
|
99cbc7 |
src/conf/domain_conf.c | 7 +++++++
|
|
|
99cbc7 |
1 file changed, 7 insertions(+)
|
|
|
99cbc7 |
|
|
|
99cbc7 |
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
|
|
|
99cbc7 |
index 49b0a59918..ed9687fde9 100644
|
|
|
99cbc7 |
--- a/src/conf/domain_conf.c
|
|
|
99cbc7 |
+++ b/src/conf/domain_conf.c
|
|
|
99cbc7 |
@@ -21609,6 +21609,13 @@ virDomainNetDefCheckABIStability(virDomainNetDefPtr src,
|
|
|
99cbc7 |
return false;
|
|
|
99cbc7 |
}
|
|
|
99cbc7 |
|
|
|
99cbc7 |
+ if (src->mtu != dst->mtu) {
|
|
|
99cbc7 |
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
99cbc7 |
+ _("Target network card MTU %d does not match source %d"),
|
|
|
99cbc7 |
+ dst->mtu, src->mtu);
|
|
|
99cbc7 |
+ return false;
|
|
|
99cbc7 |
+ }
|
|
|
99cbc7 |
+
|
|
|
99cbc7 |
if (src->virtio && dst->virtio &&
|
|
|
99cbc7 |
!virDomainVirtioOptionsCheckABIStability(src->virtio, dst->virtio))
|
|
|
99cbc7 |
return false;
|
|
|
99cbc7 |
--
|
|
|
99cbc7 |
2.18.0
|
|
|
99cbc7 |
|