|
 |
982648 |
From 2c55b2cc4900b59217e808e75af2ef7012846a4b Mon Sep 17 00:00:00 2001
|
|
|
982648 |
Message-Id: <2c55b2cc4900b59217e808e75af2ef7012846a4b@dist-git>
|
|
|
982648 |
From: Pavel Hrdina <phrdina@redhat.com>
|
|
|
982648 |
Date: Mon, 13 Aug 2018 18:16:09 +0200
|
|
|
982648 |
Subject: [PATCH] tests: rename hugepages-pages into hugepages-numa-nodeset
|
|
|
982648 |
MIME-Version: 1.0
|
|
|
982648 |
Content-Type: text/plain; charset=UTF-8
|
|
|
982648 |
Content-Transfer-Encoding: 8bit
|
|
|
982648 |
|
|
|
982648 |
Remove unnecessary XML elements as well.
|
|
|
982648 |
|
|
|
982648 |
<numatune> for numa guest is tested by numatune-memnode test.
|
|
|
982648 |
|
|
|
982648 |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
982648 |
(cherry picked from commit a83461b09af48dd22ebf7794e66268244387e3f1)
|
|
|
982648 |
|
|
|
982648 |
Conflicts:
|
|
|
982648 |
tests/qemuxml2argvdata/hugepages-numa-nodeset.args
|
|
|
982648 |
- missing upstream commit <caccbba64a>
|
|
|
982648 |
|
|
|
982648 |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591235
|
|
|
982648 |
|
|
|
982648 |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
982648 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
982648 |
---
|
|
|
982648 |
...s-pages.args => hugepages-numa-nodeset.args} | 17 +++++------------
|
|
|
982648 |
...ges-pages.xml => hugepages-numa-nodeset.xml} | 12 +-----------
|
|
|
982648 |
tests/qemuxml2argvtest.c | 2 +-
|
|
|
982648 |
...ges-pages.xml => hugepages-numa-nodeset.xml} | 17 +----------------
|
|
|
982648 |
tests/qemuxml2xmltest.c | 2 +-
|
|
|
982648 |
5 files changed, 9 insertions(+), 41 deletions(-)
|
|
|
982648 |
rename tests/qemuxml2argvdata/{hugepages-pages.args => hugepages-numa-nodeset.args} (77%)
|
|
|
982648 |
rename tests/qemuxml2argvdata/{hugepages-pages.xml => hugepages-numa-nodeset.xml} (74%)
|
|
|
982648 |
rename tests/qemuxml2xmloutdata/{hugepages-pages.xml => hugepages-numa-nodeset.xml} (66%)
|
|
|
982648 |
|
|
|
982648 |
diff --git a/tests/qemuxml2argvdata/hugepages-pages.args b/tests/qemuxml2argvdata/hugepages-numa-nodeset.args
|
|
|
982648 |
similarity index 77%
|
|
|
982648 |
rename from tests/qemuxml2argvdata/hugepages-pages.args
|
|
|
982648 |
rename to tests/qemuxml2argvdata/hugepages-numa-nodeset.args
|
|
|
982648 |
index 7ece0272a0..22f0e605fe 100644
|
|
|
982648 |
--- a/tests/qemuxml2argvdata/hugepages-pages.args
|
|
|
982648 |
+++ b/tests/qemuxml2argvdata/hugepages-numa-nodeset.args
|
|
|
982648 |
@@ -11,20 +11,16 @@ QEMU_AUDIO_DRV=none \
|
|
|
982648 |
-m 4096 \
|
|
|
982648 |
-smp 4,sockets=4,cores=1,threads=1 \
|
|
|
982648 |
-object memory-backend-file,id=ram-node0,prealloc=yes,\
|
|
|
982648 |
-mem-path=/dev/hugepages1G/libvirt/qemu/-1-QEMUGuest1,size=1073741824,\
|
|
|
982648 |
-host-nodes=0-3,policy=bind \
|
|
|
982648 |
+mem-path=/dev/hugepages1G/libvirt/qemu/-1-QEMUGuest1,size=1073741824 \
|
|
|
982648 |
-numa node,nodeid=0,cpus=0,memdev=ram-node0 \
|
|
|
982648 |
-object memory-backend-file,id=ram-node1,prealloc=yes,\
|
|
|
982648 |
-mem-path=/dev/hugepages2M/libvirt/qemu/-1-QEMUGuest1,size=1073741824,\
|
|
|
982648 |
-host-nodes=0-3,policy=bind \
|
|
|
982648 |
+mem-path=/dev/hugepages2M/libvirt/qemu/-1-QEMUGuest1,size=1073741824 \
|
|
|
982648 |
-numa node,nodeid=1,cpus=1,memdev=ram-node1 \
|
|
|
982648 |
-object memory-backend-file,id=ram-node2,prealloc=yes,\
|
|
|
982648 |
-mem-path=/dev/hugepages1G/libvirt/qemu/-1-QEMUGuest1,size=1073741824,\
|
|
|
982648 |
-host-nodes=0-3,policy=bind \
|
|
|
982648 |
+mem-path=/dev/hugepages1G/libvirt/qemu/-1-QEMUGuest1,size=1073741824 \
|
|
|
982648 |
-numa node,nodeid=2,cpus=2,memdev=ram-node2 \
|
|
|
982648 |
-object memory-backend-file,id=ram-node3,prealloc=yes,\
|
|
|
982648 |
-mem-path=/dev/hugepages1G/libvirt/qemu/-1-QEMUGuest1,size=1073741824,\
|
|
|
982648 |
-host-nodes=3,policy=bind \
|
|
|
982648 |
+mem-path=/dev/hugepages1G/libvirt/qemu/-1-QEMUGuest1,size=1073741824 \
|
|
|
982648 |
-numa node,nodeid=3,cpus=3,memdev=ram-node3 \
|
|
|
982648 |
-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
|
|
|
982648 |
-display none \
|
|
|
982648 |
@@ -37,7 +33,4 @@ server,nowait \
|
|
|
982648 |
-no-shutdown \
|
|
|
982648 |
-no-acpi \
|
|
|
982648 |
-boot c \
|
|
|
982648 |
--usb \
|
|
|
982648 |
--drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \
|
|
|
982648 |
--device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \
|
|
|
982648 |
--device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3
|
|
|
982648 |
+-usb
|
|
|
982648 |
diff --git a/tests/qemuxml2argvdata/hugepages-pages.xml b/tests/qemuxml2argvdata/hugepages-numa-nodeset.xml
|
|
|
982648 |
similarity index 74%
|
|
|
982648 |
rename from tests/qemuxml2argvdata/hugepages-pages.xml
|
|
|
982648 |
rename to tests/qemuxml2argvdata/hugepages-numa-nodeset.xml
|
|
|
982648 |
index f9270782d4..e81fa44d58 100644
|
|
|
982648 |
--- a/tests/qemuxml2argvdata/hugepages-pages.xml
|
|
|
982648 |
+++ b/tests/qemuxml2argvdata/hugepages-numa-nodeset.xml
|
|
|
982648 |
@@ -10,10 +10,6 @@
|
|
|
982648 |
</hugepages>
|
|
|
982648 |
</memoryBacking>
|
|
|
982648 |
<vcpu placement='static'>4</vcpu>
|
|
|
982648 |
- <numatune>
|
|
|
982648 |
- <memory mode='strict' nodeset='0-3'/>
|
|
|
982648 |
- <memnode cellid='3' mode='strict' nodeset='3'/>
|
|
|
982648 |
- </numatune>
|
|
|
982648 |
<os>
|
|
|
982648 |
<type arch='i686' machine='pc'>hvm</type>
|
|
|
982648 |
<boot dev='hd'/>
|
|
|
982648 |
@@ -32,16 +28,10 @@
|
|
|
982648 |
<on_crash>destroy</on_crash>
|
|
|
982648 |
<devices>
|
|
|
982648 |
<emulator>/usr/bin/qemu-system-i686</emulator>
|
|
|
982648 |
- <disk type='block' device='disk'>
|
|
|
982648 |
- <source dev='/dev/HostVG/QEMUGuest1'/>
|
|
|
982648 |
- <target dev='hda' bus='ide'/>
|
|
|
982648 |
- <address type='drive' controller='0' bus='0' target='0' unit='0'/>
|
|
|
982648 |
- </disk>
|
|
|
982648 |
<controller type='usb' index='0'/>
|
|
|
982648 |
- <controller type='ide' index='0'/>
|
|
|
982648 |
<controller type='pci' index='0' model='pci-root'/>
|
|
|
982648 |
<input type='mouse' bus='ps2'/>
|
|
|
982648 |
<input type='keyboard' bus='ps2'/>
|
|
|
982648 |
- <memballoon model='virtio'/>
|
|
|
982648 |
+ <memballoon model='none'/>
|
|
|
982648 |
</devices>
|
|
|
982648 |
</domain>
|
|
|
982648 |
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
|
|
|
982648 |
index ea26d17a63..3bb5efbd8d 100644
|
|
|
982648 |
--- a/tests/qemuxml2argvtest.c
|
|
|
982648 |
+++ b/tests/qemuxml2argvtest.c
|
|
|
982648 |
@@ -954,7 +954,7 @@ mymain(void)
|
|
|
982648 |
DO_TEST("hugepages-numa-default-dimm",
|
|
|
982648 |
QEMU_CAPS_DEVICE_PC_DIMM,
|
|
|
982648 |
QEMU_CAPS_OBJECT_MEMORY_FILE);
|
|
|
982648 |
- DO_TEST("hugepages-pages",
|
|
|
982648 |
+ DO_TEST("hugepages-numa-nodeset",
|
|
|
982648 |
QEMU_CAPS_OBJECT_MEMORY_RAM,
|
|
|
982648 |
QEMU_CAPS_OBJECT_MEMORY_FILE);
|
|
|
982648 |
DO_TEST("hugepages-pages2", QEMU_CAPS_OBJECT_MEMORY_RAM,
|
|
|
982648 |
diff --git a/tests/qemuxml2xmloutdata/hugepages-pages.xml b/tests/qemuxml2xmloutdata/hugepages-numa-nodeset.xml
|
|
|
982648 |
similarity index 66%
|
|
|
982648 |
rename from tests/qemuxml2xmloutdata/hugepages-pages.xml
|
|
|
982648 |
rename to tests/qemuxml2xmloutdata/hugepages-numa-nodeset.xml
|
|
|
982648 |
index 498610a217..affd124048 100644
|
|
|
982648 |
--- a/tests/qemuxml2xmloutdata/hugepages-pages.xml
|
|
|
982648 |
+++ b/tests/qemuxml2xmloutdata/hugepages-numa-nodeset.xml
|
|
|
982648 |
@@ -10,10 +10,6 @@
|
|
|
982648 |
</hugepages>
|
|
|
982648 |
</memoryBacking>
|
|
|
982648 |
<vcpu placement='static'>4</vcpu>
|
|
|
982648 |
- <numatune>
|
|
|
982648 |
- <memory mode='strict' nodeset='0-3'/>
|
|
|
982648 |
- <memnode cellid='3' mode='strict' nodeset='3'/>
|
|
|
982648 |
- </numatune>
|
|
|
982648 |
<os>
|
|
|
982648 |
<type arch='i686' machine='pc'>hvm</type>
|
|
|
982648 |
<boot dev='hd'/>
|
|
|
982648 |
@@ -32,23 +28,12 @@
|
|
|
982648 |
<on_crash>destroy</on_crash>
|
|
|
982648 |
<devices>
|
|
|
982648 |
<emulator>/usr/bin/qemu-system-i686</emulator>
|
|
|
982648 |
- <disk type='block' device='disk'>
|
|
|
982648 |
- <driver name='qemu' type='raw'/>
|
|
|
982648 |
- <source dev='/dev/HostVG/QEMUGuest1'/>
|
|
|
982648 |
- <target dev='hda' bus='ide'/>
|
|
|
982648 |
- <address type='drive' controller='0' bus='0' target='0' unit='0'/>
|
|
|
982648 |
- </disk>
|
|
|
982648 |
<controller type='usb' index='0'>
|
|
|
982648 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>
|
|
|
982648 |
</controller>
|
|
|
982648 |
- <controller type='ide' index='0'>
|
|
|
982648 |
- <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
|
|
|
982648 |
- </controller>
|
|
|
982648 |
<controller type='pci' index='0' model='pci-root'/>
|
|
|
982648 |
<input type='mouse' bus='ps2'/>
|
|
|
982648 |
<input type='keyboard' bus='ps2'/>
|
|
|
982648 |
- <memballoon model='virtio'>
|
|
|
982648 |
- <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
|
|
|
982648 |
- </memballoon>
|
|
|
982648 |
+ <memballoon model='none'/>
|
|
|
982648 |
</devices>
|
|
|
982648 |
</domain>
|
|
|
982648 |
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
|
|
|
982648 |
index b4bd9ebc4c..2c3d16495e 100644
|
|
|
982648 |
--- a/tests/qemuxml2xmltest.c
|
|
|
982648 |
+++ b/tests/qemuxml2xmltest.c
|
|
|
982648 |
@@ -333,7 +333,7 @@ mymain(void)
|
|
|
982648 |
DO_TEST("pages-discard", NONE);
|
|
|
982648 |
DO_TEST("hugepages-default", NONE);
|
|
|
982648 |
DO_TEST("hugepages-numa-default-dimm", NONE);
|
|
|
982648 |
- DO_TEST("hugepages-pages", NONE);
|
|
|
982648 |
+ DO_TEST("hugepages-numa-nodeset", NONE);
|
|
|
982648 |
DO_TEST("hugepages-pages2", NONE);
|
|
|
982648 |
DO_TEST("hugepages-pages3", NONE);
|
|
|
982648 |
DO_TEST("hugepages-pages4", NONE);
|
|
|
982648 |
--
|
|
|
982648 |
2.18.0
|
|
|
982648 |
|