render / rpms / libvirt

Forked from rpms/libvirt 5 months ago
Clone
0a7476
From 47ef8016cca25db8da44b13df031afba739be066 Mon Sep 17 00:00:00 2001
0a7476
Message-Id: <47ef8016cca25db8da44b13df031afba739be066@dist-git>
0a7476
From: Michal Privoznik <mprivozn@redhat.com>
0a7476
Date: Wed, 3 Apr 2019 12:38:58 +0200
0a7476
Subject: [PATCH] src: Document autostart for session demon
0a7476
MIME-Version: 1.0
0a7476
Content-Type: text/plain; charset=UTF-8
0a7476
Content-Transfer-Encoding: 8bit
0a7476
0a7476
https://bugzilla.redhat.com/show_bug.cgi?id=1501450
0a7476
0a7476
The autostart under session daemon might not behave as you'd
0a7476
expect it to behave. This patch is inspired by latest
0a7476
libvirt-users discussion:
0a7476
0a7476
https://www.redhat.com/archives/libvirt-users/2018-December/msg00047.html
0a7476
0a7476
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
0a7476
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
0a7476
(cherry picked from commit 61b4e8aaf1bce07f282c152de556c3d6aa8d65be)
0a7476
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
0a7476
Message-Id: <44fd61a0ba2340e2c3802e42e6fbae08e6750a1d.1554287931.git.mprivozn@redhat.com>
0a7476
Reviewed-by: Erik Skultety <eskultet@redhat.com>
0a7476
---
0a7476
 src/libvirt-domain.c | 5 +++++
0a7476
 1 file changed, 5 insertions(+)
0a7476
0a7476
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
0a7476
index ad0ded9ee3..5f7f0bfeba 100644
0a7476
--- a/src/libvirt-domain.c
0a7476
+++ b/src/libvirt-domain.c
0a7476
@@ -6690,6 +6690,11 @@ virDomainCreateWithFiles(virDomainPtr domain, unsigned int nfiles,
0a7476
  * configured to be automatically started when the host
0a7476
  * machine boots.
0a7476
  *
0a7476
+ * Please note that this might result in unexpected behaviour if
0a7476
+ * used for some session URIs. Since the session daemon is started
0a7476
+ * with --timeout it comes and goes and as it does so it
0a7476
+ * autostarts domains which might have been shut off recently.
0a7476
+ *
0a7476
  * Returns -1 in case of error, 0 in case of success
0a7476
  */
0a7476
 int
0a7476
-- 
0a7476
2.21.0
0a7476