render / rpms / libvirt

Forked from rpms/libvirt 5 months ago
Clone
a41c76
From ec3392c1d5a9886279ee086ee3d421106b9b1e32 Mon Sep 17 00:00:00 2001
a41c76
Message-Id: <ec3392c1d5a9886279ee086ee3d421106b9b1e32@dist-git>
a41c76
From: Peter Krempa <pkrempa@redhat.com>
a41c76
Date: Mon, 16 Mar 2020 22:12:18 +0100
a41c76
Subject: [PATCH] qemuCheckpointDiscardBitmaps: Use correct field for
a41c76
 checkpoint bitmap name
a41c76
MIME-Version: 1.0
a41c76
Content-Type: text/plain; charset=UTF-8
a41c76
Content-Transfer-Encoding: 8bit
a41c76
a41c76
The code deleting checkpoints needs the name of the parent checkpoint's
a41c76
disk's bitmap but was using the disk alias instead. This would create
a41c76
wrong bitmaps after deleting some checkpoints.
a41c76
a41c76
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
a41c76
Reviewed-by: Eric Blake <eblake@redhat.com>
a41c76
(cherry picked from commit 0ce8b0fbe2d0cbaf26da0402270720b776ebfb0f)
a41c76
https://bugzilla.redhat.com/show_bug.cgi?id=1799013
a41c76
Message-Id: <c32db1af44e71870d172233acdfddf050ed73441.1584391727.git.pkrempa@redhat.com>
a41c76
Reviewed-by: Ján Tomko <jtomko@redhat.com>
a41c76
---
a41c76
 src/qemu/qemu_checkpoint.c | 2 +-
a41c76
 1 file changed, 1 insertion(+), 1 deletion(-)
a41c76
a41c76
diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
a41c76
index 6e3a432022..19822bd74d 100644
a41c76
--- a/src/qemu/qemu_checkpoint.c
a41c76
+++ b/src/qemu/qemu_checkpoint.c
a41c76
@@ -285,7 +285,7 @@ qemuCheckpointDiscardBitmaps(virDomainObjPtr vm,
a41c76
          * ancestor. */
a41c76
         if ((parentchkdisk = qemuCheckpointFindActiveDiskInParent(vm, parent,
a41c76
                                                                   chkdisk->name)))
a41c76
-            parentbitmap = parentchkdisk->name;
a41c76
+            parentbitmap = parentchkdisk->bitmap;
a41c76
 
a41c76
         if (qemuCheckpointDiscardDiskBitmaps(domdisk->src, blockNamedNodeData,
a41c76
                                              chkdisk->bitmap, parentbitmap,
a41c76
-- 
a41c76
2.25.1
a41c76