|
 |
fbe740 |
From 74ee4616dd3159f4456ec9d4fd22b4604394440b Mon Sep 17 00:00:00 2001
|
|
|
fbe740 |
Message-Id: <74ee4616dd3159f4456ec9d4fd22b4604394440b@dist-git>
|
|
|
fbe740 |
From: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Date: Mon, 16 Mar 2020 22:12:17 +0100
|
|
|
fbe740 |
Subject: [PATCH] qemuCheckpointDiscardBitmaps: Reopen images for bitmap
|
|
|
fbe740 |
modifications
|
|
|
fbe740 |
MIME-Version: 1.0
|
|
|
fbe740 |
Content-Type: text/plain; charset=UTF-8
|
|
|
fbe740 |
Content-Transfer-Encoding: 8bit
|
|
|
fbe740 |
|
|
|
fbe740 |
Qemu's bitmap APIs don't reopen the appropriate images read-write for
|
|
|
fbe740 |
modification. It's libvirt's duty to reopen them via blockdev-reopen
|
|
|
fbe740 |
if we wish to modify the bitmaps.
|
|
|
fbe740 |
|
|
|
fbe740 |
Use the new helpers to reopen the images for bitmap manipulation.
|
|
|
fbe740 |
|
|
|
fbe740 |
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
fbe740 |
(cherry picked from commit c6d117528cc0ddb325abd67d69b6d4ebc1bfe608)
|
|
|
fbe740 |
https://bugzilla.redhat.com/show_bug.cgi?id=1799013
|
|
|
fbe740 |
Message-Id: <c5378d64ab79d29e62b5b65d1566825b5bc88eff.1584391727.git.pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
fbe740 |
---
|
|
|
fbe740 |
src/qemu/qemu_checkpoint.c | 7 +++++++
|
|
|
fbe740 |
1 file changed, 7 insertions(+)
|
|
|
fbe740 |
|
|
|
fbe740 |
diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
|
|
|
fbe740 |
index fe54af74ec..6e3a432022 100644
|
|
|
fbe740 |
--- a/src/qemu/qemu_checkpoint.c
|
|
|
fbe740 |
+++ b/src/qemu/qemu_checkpoint.c
|
|
|
fbe740 |
@@ -302,6 +302,10 @@ qemuCheckpointDiscardBitmaps(virDomainObjPtr vm,
|
|
|
fbe740 |
false, false, false) < 0)
|
|
|
fbe740 |
goto relabel;
|
|
|
fbe740 |
|
|
|
fbe740 |
+ if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV_REOPEN) &&
|
|
|
fbe740 |
+ qemuBlockReopenReadWrite(vm, src, QEMU_ASYNC_JOB_NONE) < 0)
|
|
|
fbe740 |
+ goto relabel;
|
|
|
fbe740 |
+
|
|
|
fbe740 |
relabelimages = g_slist_prepend(relabelimages, src);
|
|
|
fbe740 |
}
|
|
|
fbe740 |
|
|
|
fbe740 |
@@ -314,6 +318,9 @@ qemuCheckpointDiscardBitmaps(virDomainObjPtr vm,
|
|
|
fbe740 |
for (next = relabelimages; next; next = next->next) {
|
|
|
fbe740 |
virStorageSourcePtr src = next->data;
|
|
|
fbe740 |
|
|
|
fbe740 |
+ if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV_REOPEN))
|
|
|
fbe740 |
+ ignore_value(qemuBlockReopenReadOnly(vm, src, QEMU_ASYNC_JOB_NONE));
|
|
|
fbe740 |
+
|
|
|
fbe740 |
ignore_value(qemuDomainStorageSourceAccessAllow(driver, vm, src,
|
|
|
fbe740 |
true, false, false));
|
|
|
fbe740 |
}
|
|
|
fbe740 |
--
|
|
|
fbe740 |
2.25.1
|
|
|
fbe740 |
|