|
 |
acda74 |
From e0e6c7375855e09c45591d0b5ab23cddaa230ad8 Mon Sep 17 00:00:00 2001
|
|
|
acda74 |
Message-Id: <e0e6c7375855e09c45591d0b5ab23cddaa230ad8@dist-git>
|
|
|
acda74 |
From: Peter Krempa <pkrempa@redhat.com>
|
|
|
acda74 |
Date: Thu, 19 Jan 2023 15:18:45 +0100
|
|
|
acda74 |
Subject: [PATCH] qemu: Remove 'memAliasOrderMismatch' field from VM private
|
|
|
acda74 |
data
|
|
|
acda74 |
|
|
|
acda74 |
The field is no longer used so we can remove it and the code filling it.
|
|
|
acda74 |
|
|
|
acda74 |
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
|
acda74 |
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
|
|
|
acda74 |
(cherry picked from commit 5764930463eb8f450e45fa982651ef6b7a7afd7c)
|
|
|
acda74 |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2158701
|
|
|
acda74 |
---
|
|
|
acda74 |
src/qemu/qemu_domain.h | 3 ---
|
|
|
acda74 |
src/qemu/qemu_process.c | 24 ------------------------
|
|
|
acda74 |
2 files changed, 27 deletions(-)
|
|
|
acda74 |
|
|
|
acda74 |
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
|
|
|
acda74 |
index 08430b67b9..eca5404cdc 100644
|
|
|
acda74 |
--- a/src/qemu/qemu_domain.h
|
|
|
acda74 |
+++ b/src/qemu/qemu_domain.h
|
|
|
acda74 |
@@ -177,9 +177,6 @@ struct _qemuDomainObjPrivate {
|
|
|
acda74 |
uint8_t *masterKey;
|
|
|
acda74 |
size_t masterKeyLen;
|
|
|
acda74 |
|
|
|
acda74 |
- /* note whether memory device alias does not correspond to slot number */
|
|
|
acda74 |
- bool memAliasOrderMismatch;
|
|
|
acda74 |
-
|
|
|
acda74 |
/* for migrations using TLS with a secret (not to be saved in our */
|
|
|
acda74 |
/* private XML). */
|
|
|
acda74 |
qemuDomainSecretInfo *migSecinfo;
|
|
|
acda74 |
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
|
|
|
acda74 |
index ee9f0784d3..29716ecb19 100644
|
|
|
acda74 |
--- a/src/qemu/qemu_process.c
|
|
|
acda74 |
+++ b/src/qemu/qemu_process.c
|
|
|
acda74 |
@@ -3896,28 +3896,6 @@ qemuDomainPerfRestart(virDomainObj *vm)
|
|
|
acda74 |
}
|
|
|
acda74 |
|
|
|
acda74 |
|
|
|
acda74 |
-static void
|
|
|
acda74 |
-qemuProcessReconnectCheckMemAliasOrderMismatch(virDomainObj *vm)
|
|
|
acda74 |
-{
|
|
|
acda74 |
- size_t i;
|
|
|
acda74 |
- int aliasidx;
|
|
|
acda74 |
- virDomainDef *def = vm->def;
|
|
|
acda74 |
- qemuDomainObjPrivate *priv = vm->privateData;
|
|
|
acda74 |
-
|
|
|
acda74 |
- if (!virDomainDefHasMemoryHotplug(def) || def->nmems == 0)
|
|
|
acda74 |
- return;
|
|
|
acda74 |
-
|
|
|
acda74 |
- for (i = 0; i < def->nmems; i++) {
|
|
|
acda74 |
- aliasidx = qemuDomainDeviceAliasIndex(&def->mems[i]->info, "dimm");
|
|
|
acda74 |
-
|
|
|
acda74 |
- if (def->mems[i]->info.addr.dimm.slot != aliasidx) {
|
|
|
acda74 |
- priv->memAliasOrderMismatch = true;
|
|
|
acda74 |
- break;
|
|
|
acda74 |
- }
|
|
|
acda74 |
- }
|
|
|
acda74 |
-}
|
|
|
acda74 |
-
|
|
|
acda74 |
-
|
|
|
acda74 |
static bool
|
|
|
acda74 |
qemuProcessDomainMemoryDefNeedHugepagesPath(const virDomainMemoryDef *mem,
|
|
|
acda74 |
const long system_pagesize)
|
|
|
acda74 |
@@ -9091,8 +9069,6 @@ qemuProcessReconnect(void *opaque)
|
|
|
acda74 |
if (qemuProcessRefreshFdsetIndex(obj) < 0)
|
|
|
acda74 |
goto error;
|
|
|
acda74 |
|
|
|
acda74 |
- qemuProcessReconnectCheckMemAliasOrderMismatch(obj);
|
|
|
acda74 |
-
|
|
|
acda74 |
if (qemuConnectAgent(driver, obj) < 0)
|
|
|
acda74 |
goto error;
|
|
|
acda74 |
|
|
|
acda74 |
--
|
|
|
acda74 |
2.39.1
|
|
|
acda74 |
|