|
 |
404507 |
From bda9cc7585816a5233beba2661510ecc4d69c4e2 Mon Sep 17 00:00:00 2001
|
|
|
404507 |
Message-Id: <bda9cc7585816a5233beba2661510ecc4d69c4e2@dist-git>
|
|
|
404507 |
From: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
|
|
|
404507 |
Date: Wed, 7 Feb 2018 14:16:02 +0100
|
|
|
404507 |
Subject: [PATCH] qemu: Limit refresh of CPU halted state to s390
|
|
|
404507 |
|
|
|
404507 |
Refreshing the halted state can cause VM performance issues. Since
|
|
|
404507 |
s390 is currently the only architecture with a known interest in
|
|
|
404507 |
the halted state, we're avoiding to call QEMU on other platforms.
|
|
|
404507 |
|
|
|
404507 |
Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
|
|
|
404507 |
(cherry picked from commit 818a29e0c7d6840e87e9ca6019b9f0bc1983566e)
|
|
|
404507 |
|
|
|
404507 |
https://bugzilla.redhat.com/show_bug.cgi?id=1534585
|
|
|
404507 |
---
|
|
|
404507 |
src/qemu/qemu_domain.c | 5 +++++
|
|
|
404507 |
1 file changed, 5 insertions(+)
|
|
|
404507 |
|
|
|
404507 |
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
|
|
|
404507 |
index e87c7d030c..0f7f3b7f50 100644
|
|
|
404507 |
--- a/src/qemu/qemu_domain.c
|
|
|
404507 |
+++ b/src/qemu/qemu_domain.c
|
|
|
404507 |
@@ -7989,6 +7989,11 @@ qemuDomainRefreshVcpuHalted(virQEMUDriverPtr driver,
|
|
|
404507 |
if (vm->def->virtType == VIR_DOMAIN_VIRT_QEMU)
|
|
|
404507 |
return 0;
|
|
|
404507 |
|
|
|
404507 |
+ /* The halted state is interresting only on s390(x). On other platforms
|
|
|
404507 |
+ * the data would be stale at the time when it would be used. */
|
|
|
404507 |
+ if (!ARCH_IS_S390(vm->def->os.arch))
|
|
|
404507 |
+ return 0;
|
|
|
404507 |
+
|
|
|
404507 |
if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
|
|
|
404507 |
return -1;
|
|
|
404507 |
|
|
|
404507 |
--
|
|
|
404507 |
2.16.1
|
|
|
404507 |
|