render / rpms / libvirt

Forked from rpms/libvirt 10 months ago
Clone
edecca
From 748e6ba76086dbb122d6cd750ced935405194fc5 Mon Sep 17 00:00:00 2001
edecca
Message-Id: <748e6ba76086dbb122d6cd750ced935405194fc5@dist-git>
edecca
From: Andrea Bolognani <abologna@redhat.com>
edecca
Date: Mon, 17 Sep 2018 18:00:53 +0200
edecca
Subject: [PATCH] qemu: Don't check for /dev/kvm presence
edecca
edecca
The file being present doesn't necessarily mean anything these
edecca
days, as it's created independently of whether the kvm module
edecca
has been loaded[1]; moreover, we're already gathering all the
edecca
information we need through QMP, so poking the filesystem at
edecca
all is entirely unnecessary.
edecca
edecca
[1] https://github.com/systemd/systemd/commit/d35d6249d5a7ed3228
edecca
edecca
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
edecca
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
edecca
(cherry picked from commit 2f8b91ee74ff617aba322d034119427cad977af9)
edecca
edecca
https://bugzilla.redhat.com/show_bug.cgi?id=1629862
edecca
edecca
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
edecca
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
edecca
---
edecca
 src/qemu/qemu_capabilities.c | 5 ++---
edecca
 1 file changed, 2 insertions(+), 3 deletions(-)
edecca
edecca
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
edecca
index c7ece21dd2..5fd10c2d40 100644
edecca
--- a/src/qemu/qemu_capabilities.c
edecca
+++ b/src/qemu/qemu_capabilities.c
edecca
@@ -832,9 +832,8 @@ virQEMUCapsInitGuestFromBinary(virCapsPtr caps,
edecca
     if (!binary)
edecca
         return 0;
edecca
 
edecca
-    if (virFileExists("/dev/kvm") &&
edecca
-        (virQEMUCapsGet(qemubinCaps, QEMU_CAPS_KVM) ||
edecca
-         kvmbin))
edecca
+    if (virQEMUCapsGet(qemubinCaps, QEMU_CAPS_KVM) ||
edecca
+        kvmbin)
edecca
         haskvm = true;
edecca
 
edecca
     if (virQEMUCapsGetMachineTypesCaps(qemubinCaps, &nmachines, &machines) < 0)
edecca
-- 
edecca
2.19.1
edecca