render / rpms / libvirt

Forked from rpms/libvirt 7 months ago
Clone
e6dfe8
From 442ccfef325b73b201332c89cc53421f8299998e Mon Sep 17 00:00:00 2001
e6dfe8
Message-Id: <442ccfef325b73b201332c89cc53421f8299998e@dist-git>
e6dfe8
From: Jiri Denemark <jdenemar@redhat.com>
e6dfe8
Date: Thu, 22 Feb 2018 13:22:39 +0100
e6dfe8
Subject: [PATCH] lxc: Drop useless check in live device update
e6dfe8
MIME-Version: 1.0
e6dfe8
Content-Type: text/plain; charset=UTF-8
e6dfe8
Content-Transfer-Encoding: 8bit
e6dfe8
e6dfe8
Checking the new device definition makes little sense when lxc driver
e6dfe8
does not support live device update at all.
e6dfe8
e6dfe8
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
e6dfe8
(cherry picked from commit e3497f3fc895c427ce35188f3ddb2bb47a853be9)
e6dfe8
e6dfe8
https://bugzilla.redhat.com/show_bug.cgi?id=1557922
e6dfe8
e6dfe8
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
e6dfe8
Reviewed-by: Ján Tomko <jtomko@redhat.com>
e6dfe8
---
e6dfe8
 src/lxc/lxc_driver.c | 3 ---
e6dfe8
 1 file changed, 3 deletions(-)
e6dfe8
e6dfe8
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
e6dfe8
index b3f6f064f3..7829ef8618 100644
e6dfe8
--- a/src/lxc/lxc_driver.c
e6dfe8
+++ b/src/lxc/lxc_driver.c
e6dfe8
@@ -4910,9 +4910,6 @@ static int lxcDomainUpdateDeviceFlags(virDomainPtr dom,
e6dfe8
     }
e6dfe8
 
e6dfe8
     if (flags & VIR_DOMAIN_AFFECT_LIVE) {
e6dfe8
-        if (virDomainDefCompatibleDevice(vm->def, dev_copy) < 0)
e6dfe8
-            goto endjob;
e6dfe8
-
e6dfe8
         virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
e6dfe8
                        _("Unable to modify live devices"));
e6dfe8
 
e6dfe8
-- 
e6dfe8
2.17.0
e6dfe8