render / rpms / libvirt

Forked from rpms/libvirt 9 months ago
Clone
acda74
From 31f2edcd7f42cda4173eabad879bfc318c202c9e Mon Sep 17 00:00:00 2001
acda74
Message-Id: <31f2edcd7f42cda4173eabad879bfc318c202c9e@dist-git>
acda74
From: Pavel Hrdina <phrdina@redhat.com>
acda74
Date: Tue, 17 Jan 2023 10:33:22 +0100
acda74
Subject: [PATCH] docs: document correct cpu shares limits with both cgroups v1
acda74
 and v2
acda74
acda74
The limits are different with cgroups v1 and v2 but our XML
acda74
documentation and virsh manpage mentioned only cgroups v1 limits without
acda74
explicitly saying it only applies to cgroups v1.
acda74
acda74
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
acda74
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
acda74
(cherry picked from commit ead6e1b00285cbd98e0f0727efb8adcb29ebc1ba)
acda74
acda74
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2037998
acda74
acda74
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
acda74
---
acda74
 docs/formatdomain.rst   | 2 +-
acda74
 docs/manpages/virsh.rst | 3 ++-
acda74
 2 files changed, 3 insertions(+), 2 deletions(-)
acda74
acda74
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
acda74
index 490a954745..8fc8aeb928 100644
acda74
--- a/docs/formatdomain.rst
acda74
+++ b/docs/formatdomain.rst
acda74
@@ -849,7 +849,7 @@ CPU Tuning
acda74
    There is no unit for the value, it's a relative measure based on the setting
acda74
    of other VM, e.g. A VM configured with value 2048 will get twice as much CPU
acda74
    time as a VM configured with value 1024. The value should be in range
acda74
-   [2, 262144]. :since:`Since 0.9.0`
acda74
+   [2, 262144] using cgroups v1, [1, 10000] using cgroups v2. :since:`Since 0.9.0`
acda74
 ``period``
acda74
    The optional ``period`` element specifies the enforcement interval (unit:
acda74
    microseconds). Within ``period``, each vCPU of the domain will not be allowed
acda74
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
acda74
index 88b7fa1da8..d5b614dc03 100644
acda74
--- a/docs/manpages/virsh.rst
acda74
+++ b/docs/manpages/virsh.rst
acda74
@@ -4054,7 +4054,8 @@ If *--config* is specified, affect the next start of a persistent guest.
acda74
 If *--current* is specified, it is equivalent to either *--live* or
acda74
 *--config*, depending on the current state of the guest.
acda74
 
acda74
-``Note``: The cpu_shares parameter has a valid value range of 2-262144.
acda74
+``Note``: The cpu_shares parameter has a valid value range of 2-262144
acda74
+with cgroups v1, 1-10000 with cgroups v2.
acda74
 
acda74
 ``Note``: The weight and cap parameters are defined only for the
acda74
 XEN_CREDIT scheduler.
acda74
-- 
acda74
2.39.1
acda74