render / rpms / libvirt

Forked from rpms/libvirt 9 months ago
Clone
43fe83
From 681c50c34fb55f06d4a41f12dc84c4c6e6f22bfb Mon Sep 17 00:00:00 2001
43fe83
Message-Id: <681c50c34fb55f06d4a41f12dc84c4c6e6f22bfb.1377873642.git.jdenemar@redhat.com>
43fe83
From: Michal Privoznik <mprivozn@redhat.com>
43fe83
Date: Mon, 26 Aug 2013 17:41:46 +0200
43fe83
Subject: [PATCH] docs: Discourage users to set hard_limit
43fe83
43fe83
https://bugzilla.redhat.com/show_bug.cgi?id=1001143
43fe83
43fe83
In one of my previous patches I am removing the hard_limit heuristic to
43fe83
guess the correct value if none set. However, it turned out, this limit
43fe83
is hard to guess even for users. We should advise them to not set the
43fe83
limit as their domains may be OOM killed. Sigh.
43fe83
(cherry picked from commit 09adfdc62de2bbba71580839f735ec07a356c762)
43fe83
---
43fe83
 docs/formatdomain.html.in | 6 +++++-
43fe83
 1 file changed, 5 insertions(+), 1 deletion(-)
43fe83
43fe83
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
43fe83
index a1803df..fb4238e 100644
43fe83
--- a/docs/formatdomain.html.in
43fe83
+++ b/docs/formatdomain.html.in
43fe83
@@ -676,7 +676,11 @@
43fe83
       
hard_limit
43fe83
       
The optional hard_limit element is the maximum memory
43fe83
         the guest can use. The units for this value are kibibytes (i.e. blocks
43fe83
-        of 1024 bytes)
43fe83
+        of 1024 bytes). However, users of QEMU and KVM are strongly
43fe83
+        advised not to set this limit as domain may get killed by the kernel.
43fe83
+        To determine the memory needed for a process to run is
43fe83
+        
43fe83
+        undecidable problem.
43fe83
       
soft_limit
43fe83
       
The optional soft_limit element is the memory limit to
43fe83
         enforce during memory contention. The units for this value are
43fe83
-- 
43fe83
1.8.3.2
43fe83