render / rpms / libvirt

Forked from rpms/libvirt 5 months ago
Clone
397dc2
From b91bb231645300a29ab82994a003ba22835ee994 Mon Sep 17 00:00:00 2001
397dc2
Message-Id: <b91bb231645300a29ab82994a003ba22835ee994@dist-git>
397dc2
From: Jiri Denemark <jdenemar@redhat.com>
397dc2
Date: Thu, 8 Oct 2020 18:01:26 +0200
397dc2
Subject: [PATCH] cpu_map: Remove monitor feature from EPYC-Rome
397dc2
MIME-Version: 1.0
397dc2
Content-Type: text/plain; charset=UTF-8
397dc2
Content-Transfer-Encoding: 8bit
397dc2
397dc2
The feature is filtered by KVM and never automatically enabled. So even
397dc2
though QEMU definition of EPYC-Rome contains this feature, the guest
397dc2
won't see it. Also domain capabilities will show it as disabled for KVM
397dc2
domains. Thus the feature should not really be included in our
397dc2
definition of EPYC-Rome.
397dc2
397dc2
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
397dc2
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
397dc2
(cherry picked from commit 3bf6f9fe22dfbd3c1dcc614b31f2f4fe8b71a2f2)
397dc2
397dc2
https://bugzilla.redhat.com/show_bug.cgi?id=1861506
397dc2
397dc2
Conflicts:
397dc2
	tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml
397dc2
	tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml
397dc2
	tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml
397dc2
	tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml
397dc2
	tests/domaincapsdata/qemu_5.1.0.x86_64.xml
397dc2
	tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml
397dc2
	tests/domaincapsdata/qemu_5.2.0.x86_64.xml
397dc2
            - not present downstream
397dc2
397dc2
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
397dc2
Message-Id: <74b9257f49925312b025a99dd934a9613ca295d4.1602172344.git.jdenemar@redhat.com>
397dc2
Reviewed-by: Ján Tomko <jtomko@redhat.com>
397dc2
---
397dc2
 src/cpu_map/x86_EPYC-Rome.xml                              | 1 -
397dc2
 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 +
397dc2
 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml  | 1 +
397dc2
 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml  | 1 -
397dc2
 4 files changed, 2 insertions(+), 2 deletions(-)
397dc2
397dc2
diff --git a/src/cpu_map/x86_EPYC-Rome.xml b/src/cpu_map/x86_EPYC-Rome.xml
397dc2
index 99fc015fdd..e54d0a48d8 100644
397dc2
--- a/src/cpu_map/x86_EPYC-Rome.xml
397dc2
+++ b/src/cpu_map/x86_EPYC-Rome.xml
397dc2
@@ -37,7 +37,6 @@
397dc2
     <feature name='misalignsse'/>
397dc2
     <feature name='mmx'/>
397dc2
     <feature name='mmxext'/>
397dc2
-    <feature name='monitor'/>
397dc2
     <feature name='movbe'/>
397dc2
     <feature name='msr'/>
397dc2
     <feature name='mtrr'/>
397dc2
diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
397dc2
index cb2caab6f5..6d95b508b2 100644
397dc2
--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
397dc2
+++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
397dc2
@@ -2,6 +2,7 @@
397dc2
   <model fallback='forbid'>EPYC-Rome</model>
397dc2
   <vendor>AMD</vendor>
397dc2
   <feature policy='require' name='ht'/>
397dc2
+  <feature policy='require' name='monitor'/>
397dc2
   <feature policy='require' name='osxsave'/>
397dc2
   <feature policy='require' name='cmt'/>
397dc2
   <feature policy='require' name='xsaves'/>
397dc2
diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
397dc2
index b6784f9eba..65eaeabdd0 100644
397dc2
--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
397dc2
+++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
397dc2
@@ -3,6 +3,7 @@
397dc2
   <model>EPYC-Rome</model>
397dc2
   <vendor>AMD</vendor>
397dc2
   <feature name='ht'/>
397dc2
+  <feature name='monitor'/>
397dc2
   <feature name='osxsave'/>
397dc2
   <feature name='cmt'/>
397dc2
   <feature name='xsaves'/>
397dc2
diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
397dc2
index 86466c0547..febfdfcf2b 100644
397dc2
--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
397dc2
+++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
397dc2
@@ -17,5 +17,4 @@
397dc2
   <feature policy='require' name='skip-l1dfl-vmentry'/>
397dc2
   <feature policy='require' name='mds-no'/>
397dc2
   <feature policy='require' name='pschange-mc-no'/>
397dc2
-  <feature policy='disable' name='monitor'/>
397dc2
 </cpu>
397dc2
-- 
397dc2
2.29.2
397dc2