|
 |
b971b8 |
From 2145d7b6f4370dfcd7dadae7daf544767cde0392 Mon Sep 17 00:00:00 2001
|
|
|
b971b8 |
Message-Id: <2145d7b6f4370dfcd7dadae7daf544767cde0392@dist-git>
|
|
|
b971b8 |
From: Jiri Denemark <jdenemar@redhat.com>
|
|
|
b971b8 |
Date: Tue, 26 May 2020 10:58:51 +0200
|
|
|
b971b8 |
Subject: [PATCH] cpu: Change control flow in virCPUUpdateLive
|
|
|
b971b8 |
MIME-Version: 1.0
|
|
|
b971b8 |
Content-Type: text/plain; charset=UTF-8
|
|
|
b971b8 |
Content-Transfer-Encoding: 8bit
|
|
|
b971b8 |
|
|
|
b971b8 |
The updateLive CPU sub-driver function is supposed to be called only for
|
|
|
b971b8 |
a subset of CPU definitions. Let's make it more obvious by turning a
|
|
|
b971b8 |
negative test and return into a positive check.
|
|
|
b971b8 |
|
|
|
b971b8 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
b971b8 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
b971b8 |
(cherry picked from commit 68c0b85ecb07c8cefcf4f4a2ffc28e123baa9e8c)
|
|
|
b971b8 |
|
|
|
b971b8 |
https://bugzilla.redhat.com/show_bug.cgi?id=1839999
|
|
|
b971b8 |
|
|
|
b971b8 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
b971b8 |
Message-Id: <2633727669ca50970bd10abe9b045e24b76028d1.1590483392.git.jdenemar@redhat.com>
|
|
|
b971b8 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
b971b8 |
---
|
|
|
b971b8 |
src/cpu/cpu.c | 11 ++++++-----
|
|
|
b971b8 |
1 file changed, 6 insertions(+), 5 deletions(-)
|
|
|
b971b8 |
|
|
|
b971b8 |
diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
|
|
|
b971b8 |
index ae3a0acc10..1cb2dd04f4 100644
|
|
|
b971b8 |
--- a/src/cpu/cpu.c
|
|
|
b971b8 |
+++ b/src/cpu/cpu.c
|
|
|
b971b8 |
@@ -647,13 +647,14 @@ virCPUUpdateLive(virArch arch,
|
|
|
b971b8 |
if (!driver->updateLive)
|
|
|
b971b8 |
return 1;
|
|
|
b971b8 |
|
|
|
b971b8 |
- if (cpu->mode != VIR_CPU_MODE_CUSTOM)
|
|
|
b971b8 |
- return 1;
|
|
|
b971b8 |
+ if (cpu->mode == VIR_CPU_MODE_CUSTOM) {
|
|
|
b971b8 |
+ if (driver->updateLive(cpu, dataEnabled, dataDisabled) < 0)
|
|
|
b971b8 |
+ return -1;
|
|
|
b971b8 |
|
|
|
b971b8 |
- if (driver->updateLive(cpu, dataEnabled, dataDisabled) < 0)
|
|
|
b971b8 |
- return -1;
|
|
|
b971b8 |
+ return 0;
|
|
|
b971b8 |
+ }
|
|
|
b971b8 |
|
|
|
b971b8 |
- return 0;
|
|
|
b971b8 |
+ return 1;
|
|
|
b971b8 |
}
|
|
|
b971b8 |
|
|
|
b971b8 |
|
|
|
b971b8 |
--
|
|
|
b971b8 |
2.26.2
|
|
|
b971b8 |
|