|
 |
a41c76 |
From f9fdeb29a61a98868d1a9f5284a85c57f826d6d1 Mon Sep 17 00:00:00 2001
|
|
|
a41c76 |
Message-Id: <f9fdeb29a61a98868d1a9f5284a85c57f826d6d1@dist-git>
|
|
|
a41c76 |
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
|
|
|
a41c76 |
Date: Fri, 13 Mar 2020 13:08:08 +0100
|
|
|
a41c76 |
Subject: [PATCH] conf: do not generate machine names ending with a dash
|
|
|
a41c76 |
MIME-Version: 1.0
|
|
|
a41c76 |
Content-Type: text/plain; charset=UTF-8
|
|
|
a41c76 |
Content-Transfer-Encoding: 8bit
|
|
|
a41c76 |
|
|
|
a41c76 |
As of systemd commit:
|
|
|
a41c76 |
|
|
|
a41c76 |
commit d65652f1f21a4b0c59711320f34266c635393c89
|
|
|
a41c76 |
Author: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
|
|
|
a41c76 |
CommitDate: 2018-12-10 09:56:56 +0100
|
|
|
a41c76 |
|
|
|
a41c76 |
Partially unify hostname_is_valid() and dns_name_is_valid()
|
|
|
a41c76 |
|
|
|
a41c76 |
Dashes are no longer allowed at the end of machine names.
|
|
|
a41c76 |
|
|
|
a41c76 |
Trim the trailing dashes from the generated name before passing
|
|
|
a41c76 |
it to machined.
|
|
|
a41c76 |
|
|
|
a41c76 |
Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1790409
|
|
|
a41c76 |
|
|
|
a41c76 |
Signed-off-by: Ján Tomko <jtomko@redhat.com>
|
|
|
a41c76 |
Reviewed-by: Erik Skultety <eskultet@redhat.com>
|
|
|
a41c76 |
(cherry picked from commit 45464db8ba502764cf37ec9335770248bdb3d9a8)
|
|
|
a41c76 |
|
|
|
a41c76 |
Prerequisite for: https://bugzilla.redhat.com/show_bug.cgi?id=1808499
|
|
|
a41c76 |
|
|
|
a41c76 |
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
a41c76 |
Message-Id: <ae17f80d69ee7772d32dd5c34c332be6b77e7afb.1584101247.git.mprivozn@redhat.com>
|
|
|
a41c76 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
a41c76 |
---
|
|
|
a41c76 |
src/conf/domain_conf.c | 3 +++
|
|
|
a41c76 |
tests/virsystemdtest.c | 4 ++++
|
|
|
a41c76 |
2 files changed, 7 insertions(+)
|
|
|
a41c76 |
|
|
|
a41c76 |
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
|
|
|
a41c76 |
index 77e3d25a2d..4b297c96bc 100644
|
|
|
a41c76 |
--- a/src/conf/domain_conf.c
|
|
|
a41c76 |
+++ b/src/conf/domain_conf.c
|
|
|
a41c76 |
@@ -30708,6 +30708,9 @@ virDomainMachineNameAppendValid(virBufferPtr buf,
|
|
|
a41c76 |
|
|
|
a41c76 |
virBufferAddChar(buf, *name);
|
|
|
a41c76 |
}
|
|
|
a41c76 |
+
|
|
|
a41c76 |
+ /* trailing dashes are not allowed */
|
|
|
a41c76 |
+ virBufferTrimChars(buf, "-");
|
|
|
a41c76 |
}
|
|
|
a41c76 |
|
|
|
a41c76 |
#undef HOSTNAME_CHARS
|
|
|
a41c76 |
diff --git a/tests/virsystemdtest.c b/tests/virsystemdtest.c
|
|
|
a41c76 |
index 9b95ca6789..26876850b8 100644
|
|
|
a41c76 |
--- a/tests/virsystemdtest.c
|
|
|
a41c76 |
+++ b/tests/virsystemdtest.c
|
|
|
a41c76 |
@@ -740,6 +740,10 @@ mymain(void)
|
|
|
a41c76 |
"qemu-7-123456789012345678901234567890123456789012345678901234567");
|
|
|
a41c76 |
TEST_MACHINE("123456789012345678901234567890123456789012345678901234567890", 8,
|
|
|
a41c76 |
"qemu-8-123456789012345678901234567890123456789012345678901234567");
|
|
|
a41c76 |
+ TEST_MACHINE("kstest-network-device-default-httpks_(c9eed63e-981e-48ec-acdc-56b3f8c5f678)", 100,
|
|
|
a41c76 |
+ "qemu-100-kstest-network-device-default-httpksc9eed63e-981e-48ec");
|
|
|
a41c76 |
+ TEST_MACHINE("kstest-network-device-default-httpks_(c9eed63e-981e-48ec--cdc-56b3f8c5f678)", 10,
|
|
|
a41c76 |
+ "qemu-10-kstest-network-device-default-httpksc9eed63e-981e-48ec");
|
|
|
a41c76 |
|
|
|
a41c76 |
# define TESTS_PM_SUPPORT_HELPER(name, function) \
|
|
|
a41c76 |
do { \
|
|
|
a41c76 |
--
|
|
|
a41c76 |
2.25.1
|
|
|
a41c76 |
|