render / rpms / libvirt

Forked from rpms/libvirt 4 months ago
Clone
9c6c51
From 254da75ea1a9c2cade909534153f444bb8981c2a Mon Sep 17 00:00:00 2001
9c6c51
Message-Id: <254da75ea1a9c2cade909534153f444bb8981c2a@dist-git>
9c6c51
From: John Ferlan <jferlan@redhat.com>
9c6c51
Date: Mon, 27 Aug 2018 08:27:47 -0400
9c6c51
Subject: [PATCH] access: Fix nwfilter-binding ACL access API name generation
9c6c51
MIME-Version: 1.0
9c6c51
Content-Type: text/plain; charset=UTF-8
9c6c51
Content-Transfer-Encoding: 8bit
9c6c51
9c6c51
https://bugzilla.redhat.com/show_bug.cgi?id=1611320
9c6c51
9c6c51
Generation of the ACL API policy is a "automated process"
9c6c51
based on this perl script which "worked" with the changes to
9c6c51
add nwfilter binding API's because they had the "nwfilter"
9c6c51
prefix; however, the generated output name was incorrect
9c6c51
based on the remote protocol algorithm which expected to
9c6c51
generate names such as 'nwfilter-binding.action' instead
9c6c51
of 'nwfilter.binding-action'.
9c6c51
9c6c51
This effectively changes src/access/org.libvirt.api.policy entries:
9c6c51
9c6c51
  org.libvirt.api.nwfilter.binding-create ==>
9c6c51
      org.libvirt.api.nwfilter-binding.create
9c6c51
9c6c51
  org.libvirt.api.nwfilter.binding-delete ==>
9c6c51
      org.libvirt.api.nwfilter-binding.delete
9c6c51
9c6c51
  org.libvirt.api.nwfilter.binding-getattr ==>
9c6c51
      org.libvirt.api.nwfilter-binding.getattr
9c6c51
9c6c51
  org.libvirt.api.nwfilter.binding-read ==>
9c6c51
      org.libvirt.api.nwfilter-binding.read
9c6c51
9c6c51
Signed-off-by: John Ferlan <jferlan@redhat.com>
9c6c51
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
9c6c51
(cherry picked from commit 6ef65e3c96d5d1f16a16daca83b81b818d461e64)
9c6c51
https: //bugzilla.redhat.com/show_bug.cgi?id=1622540
9c6c51
Reviewed-by: Erik Skultety <eskultet@redhat.com>
9c6c51
---
9c6c51
 src/access/genpolkit.pl | 4 ++--
9c6c51
 1 file changed, 2 insertions(+), 2 deletions(-)
9c6c51
9c6c51
diff --git a/src/access/genpolkit.pl b/src/access/genpolkit.pl
9c6c51
index 968cb8c55c..e074c90eb6 100755
9c6c51
--- a/src/access/genpolkit.pl
9c6c51
+++ b/src/access/genpolkit.pl
9c6c51
@@ -22,8 +22,8 @@ use warnings;
9c6c51
 
9c6c51
 my @objects = (
9c6c51
     "CONNECT", "DOMAIN", "INTERFACE",
9c6c51
-    "NETWORK","NODE_DEVICE", "NWFILTER",
9c6c51
-     "SECRET", "STORAGE_POOL", "STORAGE_VOL",
9c6c51
+    "NETWORK","NODE_DEVICE", "NWFILTER_BINDING", "NWFILTER",
9c6c51
+    "SECRET", "STORAGE_POOL", "STORAGE_VOL",
9c6c51
     );
9c6c51
 
9c6c51
 my $objects = join ("|", @objects);
9c6c51
-- 
9c6c51
2.18.0
9c6c51