|
Daniel P. Berrangé |
48941c |
From ec92abee2851344e4e8c108a26b5cec594561ff4 Mon Sep 17 00:00:00 2001
|
|
Daniel P. Berrangé |
48941c |
From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
|
|
Daniel P. Berrangé |
48941c |
Date: Mon, 5 Mar 2018 12:46:16 +0000
|
|
Daniel P. Berrangé |
48941c |
Subject: [PATCH] tests: force use of "NORMAL" TLS priority in test suite
|
|
Daniel P. Berrangé |
48941c |
MIME-Version: 1.0
|
|
Daniel P. Berrangé |
48941c |
Content-Type: text/plain; charset=UTF-8
|
|
Daniel P. Berrangé |
48941c |
Content-Transfer-Encoding: 8bit
|
|
Daniel P. Berrangé |
48941c |
|
|
Daniel P. Berrangé |
48941c |
When generating certificates we rely on GNUTLS' built-in default setup
|
|
Daniel P. Berrangé |
48941c |
for the ciphers used in the certs. We then currently run with the distro
|
|
Daniel P. Berrangé |
48941c |
specific TLS priority setup which can be much stronger, to the extent
|
|
Daniel P. Berrangé |
48941c |
that the certificates we generate are considered untrustworthy. We don't
|
|
Daniel P. Berrangé |
48941c |
care about the quality of the ciphers we use in the test suite, so just
|
|
Daniel P. Berrangé |
48941c |
force the priority to "NORMAL" which should ensure our certs are
|
|
Daniel P. Berrangé |
48941c |
accepted by GNUTLS.
|
|
Daniel P. Berrangé |
48941c |
|
|
Daniel P. Berrangé |
48941c |
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
Daniel P. Berrangé |
48941c |
---
|
|
Daniel P. Berrangé |
48941c |
tests/virnettlscontexttest.c | 4 ++--
|
|
Daniel P. Berrangé |
48941c |
tests/virnettlssessiontest.c | 4 ++--
|
|
Daniel P. Berrangé |
48941c |
2 files changed, 4 insertions(+), 4 deletions(-)
|
|
Daniel P. Berrangé |
48941c |
|
|
Daniel P. Berrangé |
48941c |
diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c
|
|
Daniel P. Berrangé |
48941c |
index 089c10e964..86647f3014 100644
|
|
Daniel P. Berrangé |
48941c |
--- a/tests/virnettlscontexttest.c
|
|
Daniel P. Berrangé |
48941c |
+++ b/tests/virnettlscontexttest.c
|
|
Daniel P. Berrangé |
48941c |
@@ -72,7 +72,7 @@ static int testTLSContextInit(const void *opaque)
|
|
Daniel P. Berrangé |
48941c |
data->crt,
|
|
Daniel P. Berrangé |
48941c |
KEYFILE,
|
|
Daniel P. Berrangé |
48941c |
NULL,
|
|
Daniel P. Berrangé |
48941c |
- NULL,
|
|
Daniel P. Berrangé |
48941c |
+ "NORMAL",
|
|
Daniel P. Berrangé |
48941c |
true,
|
|
Daniel P. Berrangé |
48941c |
true);
|
|
Daniel P. Berrangé |
48941c |
} else {
|
|
Daniel P. Berrangé |
48941c |
@@ -80,7 +80,7 @@ static int testTLSContextInit(const void *opaque)
|
|
Daniel P. Berrangé |
48941c |
NULL,
|
|
Daniel P. Berrangé |
48941c |
data->crt,
|
|
Daniel P. Berrangé |
48941c |
KEYFILE,
|
|
Daniel P. Berrangé |
48941c |
- NULL,
|
|
Daniel P. Berrangé |
48941c |
+ "NORMAL",
|
|
Daniel P. Berrangé |
48941c |
true,
|
|
Daniel P. Berrangé |
48941c |
true);
|
|
Daniel P. Berrangé |
48941c |
}
|
|
Daniel P. Berrangé |
48941c |
diff --git a/tests/virnettlssessiontest.c b/tests/virnettlssessiontest.c
|
|
Daniel P. Berrangé |
48941c |
index 6d639e5b16..7e85607181 100644
|
|
Daniel P. Berrangé |
48941c |
--- a/tests/virnettlssessiontest.c
|
|
Daniel P. Berrangé |
48941c |
+++ b/tests/virnettlssessiontest.c
|
|
Daniel P. Berrangé |
48941c |
@@ -113,7 +113,7 @@ static int testTLSSessionInit(const void *opaque)
|
|
Daniel P. Berrangé |
48941c |
data->servercrt,
|
|
Daniel P. Berrangé |
48941c |
KEYFILE,
|
|
Daniel P. Berrangé |
48941c |
data->wildcards,
|
|
Daniel P. Berrangé |
48941c |
- NULL,
|
|
Daniel P. Berrangé |
48941c |
+ "NORMAL",
|
|
Daniel P. Berrangé |
48941c |
false,
|
|
Daniel P. Berrangé |
48941c |
true);
|
|
Daniel P. Berrangé |
48941c |
|
|
Daniel P. Berrangé |
48941c |
@@ -121,7 +121,7 @@ static int testTLSSessionInit(const void *opaque)
|
|
Daniel P. Berrangé |
48941c |
NULL,
|
|
Daniel P. Berrangé |
48941c |
data->clientcrt,
|
|
Daniel P. Berrangé |
48941c |
KEYFILE,
|
|
Daniel P. Berrangé |
48941c |
- NULL,
|
|
Daniel P. Berrangé |
48941c |
+ "NORMAL",
|
|
Daniel P. Berrangé |
48941c |
false,
|
|
Daniel P. Berrangé |
48941c |
true);
|
|
Daniel P. Berrangé |
48941c |
|
|
Daniel P. Berrangé |
48941c |
--
|
|
Daniel P. Berrangé |
48941c |
2.14.3
|
|
Daniel P. Berrangé |
48941c |
|