|
 |
63d87e |
From d25dc10aa262b33794f16b75a0ada3aad507abe7 Mon Sep 17 00:00:00 2001
|
|
|
63d87e |
From: Laszlo Ersek <lersek@redhat.com>
|
|
|
63d87e |
Date: Fri, 31 Jan 2020 12:42:43 +0100
|
|
|
63d87e |
Subject: [PATCH 07/12] SecurityPkg/DxeImageVerificationHandler: remove
|
|
|
63d87e |
superfluous Status setting
|
|
|
63d87e |
MIME-Version: 1.0
|
|
|
63d87e |
Content-Type: text/plain; charset=UTF-8
|
|
|
63d87e |
Content-Transfer-Encoding: 8bit
|
|
|
63d87e |
|
|
|
63d87e |
RH-Author: Laszlo Ersek <lersek@redhat.com>
|
|
|
63d87e |
Message-id: <20200131124248.22369-8-lersek@redhat.com>
|
|
|
63d87e |
Patchwork-id: 93617
|
|
|
63d87e |
O-Subject: [RHEL-8.2.0 edk2 PATCH 07/12] SecurityPkg/DxeImageVerificationHandler: remove superfluous Status setting
|
|
|
63d87e |
Bugzilla: 1751993
|
|
|
63d87e |
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
|
63d87e |
RH-Acked-by: Vitaly Kuznetsov <vkuznets@redhat.com>
|
|
|
63d87e |
|
|
|
63d87e |
After the final "IsVerified" check, we set "Status" to EFI_ACCESS_DENIED.
|
|
|
63d87e |
This is superfluous, as "Status" already carries EFI_ACCESS_DENIED value
|
|
|
63d87e |
there, from the top of the function. Remove the assignment.
|
|
|
63d87e |
|
|
|
63d87e |
Functionally, this change is a no-op.
|
|
|
63d87e |
|
|
|
63d87e |
Cc: Chao Zhang <chao.b.zhang@intel.com>
|
|
|
63d87e |
Cc: Jian J Wang <jian.j.wang@intel.com>
|
|
|
63d87e |
Cc: Jiewen Yao <jiewen.yao@intel.com>
|
|
|
63d87e |
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
|
|
|
63d87e |
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
63d87e |
Message-Id: <20200116190705.18816-7-lersek@redhat.com>
|
|
|
63d87e |
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
|
|
|
63d87e |
[lersek@redhat.com: push with Mike's R-b due to Chinese New Year
|
|
|
63d87e |
Holiday: <https://edk2.groups.io/g/devel/message/53429>; msgid
|
|
|
63d87e |
<d3fbb76dabed4e1987c512c328c82810@intel.com>]
|
|
|
63d87e |
(cherry picked from commit 12a4ef58a8b1f8610f6f7cd3ffb973f924f175fb)
|
|
|
63d87e |
|
|
|
63d87e |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
63d87e |
---
|
|
|
63d87e |
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 1 -
|
|
|
63d87e |
1 file changed, 1 deletion(-)
|
|
|
63d87e |
|
|
|
63d87e |
diff --git a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c
|
|
|
63d87e |
index 5f09a66..6ccce1f 100644
|
|
|
63d87e |
--- a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c
|
|
|
63d87e |
+++ b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c
|
|
|
63d87e |
@@ -1853,7 +1853,6 @@ DxeImageVerificationHandler (
|
|
|
63d87e |
if (IsVerified) {
|
|
|
63d87e |
return EFI_SUCCESS;
|
|
|
63d87e |
}
|
|
|
63d87e |
- Status = EFI_ACCESS_DENIED;
|
|
|
63d87e |
if (Action == EFI_IMAGE_EXECUTION_AUTH_SIG_FAILED || Action == EFI_IMAGE_EXECUTION_AUTH_SIG_FOUND) {
|
|
|
63d87e |
//
|
|
|
63d87e |
// Get image hash value as signature of executable.
|
|
|
63d87e |
--
|
|
|
63d87e |
1.8.3.1
|
|
|
63d87e |
|