philipp / rpms / dhcp

Forked from rpms/dhcp 4 years ago
Clone
324fcf
diff -up dhcp-4.3.3b1/client/clparse.c.cloexec dhcp-4.3.3b1/client/clparse.c
324fcf
--- dhcp-4.3.3b1/client/clparse.c.cloexec	2015-08-10 10:46:20.264755543 +0200
324fcf
+++ dhcp-4.3.3b1/client/clparse.c	2015-08-10 10:46:20.274755510 +0200
324fcf
@@ -247,7 +247,7 @@ int read_client_conf_file (const char *n
324fcf
 	int token;
324fcf
 	isc_result_t status;
324fcf
 
324fcf
-	if ((file = open (name, O_RDONLY)) < 0)
324fcf
+	if ((file = open (name, O_RDONLY | O_CLOEXEC)) < 0)
324fcf
 		return uerr2isc (errno);
324fcf
 
324fcf
 	cfile = NULL;
324fcf
@@ -323,7 +323,7 @@ void read_client_leases ()
324fcf
 
324fcf
 	/* Open the lease file.   If we can't open it, just return -
324fcf
 	   we can safely trust the server to remember our state. */
324fcf
-	if ((file = open (path_dhclient_db, O_RDONLY)) < 0)
324fcf
+	if ((file = open (path_dhclient_db, O_RDONLY | O_CLOEXEC)) < 0)
324fcf
 		return;
324fcf
 
324fcf
 	cfile = NULL;
324fcf
diff -up dhcp-4.3.3b1/client/dhclient.c.cloexec dhcp-4.3.3b1/client/dhclient.c
324fcf
--- dhcp-4.3.3b1/client/dhclient.c.cloexec	2015-08-10 10:46:20.260755556 +0200
324fcf
+++ dhcp-4.3.3b1/client/dhclient.c	2015-08-10 10:46:20.275755506 +0200
324fcf
@@ -153,11 +153,11 @@ main(int argc, char **argv) {
324fcf
 	/* Make sure that file descriptors 0 (stdin), 1, (stdout), and
324fcf
 	   2 (stderr) are open. To do this, we assume that when we
324fcf
 	   open a file the lowest available file descriptor is used. */
324fcf
-	fd = open("/dev/null", O_RDWR);
324fcf
+	fd = open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
 	if (fd == 0)
324fcf
-		fd = open("/dev/null", O_RDWR);
324fcf
+		fd = open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
 	if (fd == 1)
324fcf
-		fd = open("/dev/null", O_RDWR);
324fcf
+		fd = open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
 	if (fd == 2)
324fcf
 		log_perror = 0; /* No sense logging to /dev/null. */
324fcf
 	else if (fd != -1)
324fcf
@@ -519,7 +519,7 @@ main(int argc, char **argv) {
324fcf
 		long temp;
324fcf
 		int e;
324fcf
 
324fcf
-		if ((pidfd = fopen(path_dhclient_pid, "r")) != NULL) {
324fcf
+		if ((pidfd = fopen(path_dhclient_pid, "re")) != NULL) {
324fcf
 			e = fscanf(pidfd, "%ld\n", &temp);
324fcf
 			oldpid = (pid_t)temp;
324fcf
 
324fcf
@@ -574,7 +574,7 @@ main(int argc, char **argv) {
324fcf
 					strncpy(new_path_dhclient_pid, path_dhclient_pid, pfx);
324fcf
 					sprintf(new_path_dhclient_pid + pfx, "-%s.pid", ip->name);
324fcf
 
324fcf
-					if ((pidfd = fopen(new_path_dhclient_pid, "r")) != NULL) {
324fcf
+					if ((pidfd = fopen(new_path_dhclient_pid, "re")) != NULL) {
324fcf
 						e = fscanf(pidfd, "%ld\n", &temp);
324fcf
 						oldpid = (pid_t)temp;
324fcf
 
324fcf
@@ -599,7 +599,7 @@ main(int argc, char **argv) {
324fcf
 		int dhc_running = 0;
324fcf
 		char procfn[256] = "";
324fcf
 
324fcf
-		if ((pidfp = fopen(path_dhclient_pid, "r")) != NULL) {
324fcf
+		if ((pidfp = fopen(path_dhclient_pid, "re")) != NULL) {
324fcf
 			if ((fscanf(pidfp, "%ld", &temp)==1) && ((dhcpid=(pid_t)temp) > 0)) {
324fcf
 				snprintf(procfn,256,"/proc/%u",dhcpid);
324fcf
 				dhc_running = (access(procfn, F_OK) == 0);
324fcf
@@ -3120,7 +3120,7 @@ void rewrite_client_leases ()
324fcf
 
324fcf
 	if (leaseFile != NULL)
324fcf
 		fclose (leaseFile);
324fcf
-	leaseFile = fopen (path_dhclient_db, "w");
324fcf
+	leaseFile = fopen (path_dhclient_db, "we");
324fcf
 	if (leaseFile == NULL) {
324fcf
 		log_error ("can't create %s: %m", path_dhclient_db);
324fcf
 		return;
324fcf
@@ -3313,7 +3313,7 @@ write_duid(struct data_string *duid)
324fcf
 		return DHCP_R_INVALIDARG;
324fcf
 
324fcf
 	if (leaseFile == NULL) {	/* XXX? */
324fcf
-		leaseFile = fopen(path_dhclient_db, "w");
324fcf
+		leaseFile = fopen(path_dhclient_db, "we");
324fcf
 		if (leaseFile == NULL) {
324fcf
 			log_error("can't create %s: %m", path_dhclient_db);
324fcf
 			return ISC_R_IOERROR;
324fcf
@@ -3493,7 +3493,7 @@ int write_client_lease (client, lease, r
324fcf
 		return 1;
324fcf
 
324fcf
 	if (leaseFile == NULL) {	/* XXX */
324fcf
-		leaseFile = fopen (path_dhclient_db, "w");
324fcf
+		leaseFile = fopen (path_dhclient_db, "we");
324fcf
 		if (leaseFile == NULL) {
324fcf
 			log_error ("can't create %s: %m", path_dhclient_db);
324fcf
 			return 0;
324fcf
@@ -4011,9 +4011,9 @@ void go_daemon ()
324fcf
 	(void) close(2);
324fcf
 
324fcf
 	/* Reopen them on /dev/null. */
324fcf
-	(void) open("/dev/null", O_RDWR);
324fcf
-	(void) open("/dev/null", O_RDWR);
324fcf
-	(void) open("/dev/null", O_RDWR);
324fcf
+	(void) open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
+	(void) open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
+	(void) open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
 
324fcf
 	write_client_pid_file ();
324fcf
 
324fcf
@@ -4030,14 +4030,14 @@ void write_client_pid_file ()
324fcf
 		return;
324fcf
 	}
324fcf
 
324fcf
-	pfdesc = open (path_dhclient_pid, O_CREAT | O_TRUNC | O_WRONLY, 0644);
324fcf
+	pfdesc = open (path_dhclient_pid, O_CREAT | O_TRUNC | O_WRONLY | O_CLOEXEC, 0644);
324fcf
 
324fcf
 	if (pfdesc < 0) {
324fcf
 		log_error ("Can't create %s: %m", path_dhclient_pid);
324fcf
 		return;
324fcf
 	}
324fcf
 
324fcf
-	pf = fdopen (pfdesc, "w");
324fcf
+	pf = fdopen (pfdesc, "we");
324fcf
 	if (!pf) {
324fcf
 		close(pfdesc);
324fcf
 		log_error ("Can't fdopen %s: %m", path_dhclient_pid);
324fcf
diff -up dhcp-4.3.3b1/common/bpf.c.cloexec dhcp-4.3.3b1/common/bpf.c
324fcf
--- dhcp-4.3.3b1/common/bpf.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/common/bpf.c	2015-08-10 10:46:20.275755506 +0200
324fcf
@@ -95,7 +95,7 @@ int if_register_bpf (info)
324fcf
 	for (b = 0; 1; b++) {
324fcf
 		/* %Audit% 31 bytes max. %2004.06.17,Safe% */
324fcf
 		sprintf(filename, BPF_FORMAT, b);
324fcf
-		sock = open (filename, O_RDWR, 0);
324fcf
+		sock = open (filename, O_RDWR | O_CLOEXEC, 0);
324fcf
 		if (sock < 0) {
324fcf
 			if (errno == EBUSY) {
324fcf
 				continue;
324fcf
diff -up dhcp-4.3.3b1/common/dlpi.c.cloexec dhcp-4.3.3b1/common/dlpi.c
324fcf
--- dhcp-4.3.3b1/common/dlpi.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/common/dlpi.c	2015-08-10 10:46:20.275755506 +0200
324fcf
@@ -804,7 +804,7 @@ dlpiopen(const char *ifname) {
324fcf
 	}
324fcf
 	*dp = '\0';
324fcf
 	
324fcf
-	return open (devname, O_RDWR, 0);
324fcf
+	return open (devname, O_RDWR | O_CLOEXEC, 0);
324fcf
 }
324fcf
 
324fcf
 /*
324fcf
diff -up dhcp-4.3.3b1/common/nit.c.cloexec dhcp-4.3.3b1/common/nit.c
324fcf
--- dhcp-4.3.3b1/common/nit.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/common/nit.c	2015-08-10 10:46:20.275755506 +0200
324fcf
@@ -75,7 +75,7 @@ int if_register_nit (info)
324fcf
 	struct strioctl sio;
324fcf
 
324fcf
 	/* Open a NIT device */
324fcf
-	sock = open ("/dev/nit", O_RDWR);
324fcf
+	sock = open ("/dev/nit", O_RDWR | O_CLOEXEC);
324fcf
 	if (sock < 0)
324fcf
 		log_fatal ("Can't open NIT device for %s: %m", info -> name);
324fcf
 
324fcf
diff -up dhcp-4.3.3b1/common/resolv.c.cloexec dhcp-4.3.3b1/common/resolv.c
324fcf
--- dhcp-4.3.3b1/common/resolv.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/common/resolv.c	2015-08-10 10:46:20.276755503 +0200
324fcf
@@ -44,7 +44,7 @@ void read_resolv_conf (parse_time)
324fcf
 	struct domain_search_list *dp, *dl, *nd;
324fcf
 	isc_result_t status;
324fcf
 
324fcf
-	if ((file = open (path_resolv_conf, O_RDONLY)) < 0) {
324fcf
+	if ((file = open (path_resolv_conf, O_RDONLY | O_CLOEXEC)) < 0) {
324fcf
 		log_error ("Can't open %s: %m", path_resolv_conf);
324fcf
 		return;
324fcf
 	}
324fcf
diff -up dhcp-4.3.3b1/common/upf.c.cloexec dhcp-4.3.3b1/common/upf.c
324fcf
--- dhcp-4.3.3b1/common/upf.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/common/upf.c	2015-08-10 10:46:20.276755503 +0200
324fcf
@@ -71,7 +71,7 @@ int if_register_upf (info)
324fcf
 		/* %Audit% Cannot exceed 36 bytes. %2004.06.17,Safe% */
324fcf
 		sprintf(filename, "/dev/pf/pfilt%d", b);
324fcf
 
324fcf
-		sock = open (filename, O_RDWR, 0);
324fcf
+		sock = open (filename, O_RDWR | O_CLOEXEC, 0);
324fcf
 		if (sock < 0) {
324fcf
 			if (errno == EBUSY) {
324fcf
 				continue;
324fcf
diff -up dhcp-4.3.3b1/omapip/trace.c.cloexec dhcp-4.3.3b1/omapip/trace.c
324fcf
--- dhcp-4.3.3b1/omapip/trace.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/omapip/trace.c	2015-08-10 10:46:20.276755503 +0200
324fcf
@@ -138,10 +138,10 @@ isc_result_t trace_begin (const char *fi
324fcf
 		return DHCP_R_INVALIDARG;
324fcf
 	}
324fcf
 
324fcf
-	traceoutfile = open (filename, O_CREAT | O_WRONLY | O_EXCL, 0600);
324fcf
+	traceoutfile = open (filename, O_CREAT | O_WRONLY | O_EXCL | O_CLOEXEC, 0600);
324fcf
 	if (traceoutfile < 0 && errno == EEXIST) {
324fcf
 		log_error ("WARNING: Overwriting trace file \"%s\"", filename);
324fcf
-		traceoutfile = open (filename, O_WRONLY | O_EXCL | O_TRUNC,
324fcf
+		traceoutfile = open (filename, O_WRONLY | O_EXCL | O_TRUNC | O_CLOEXEC,
324fcf
 				     0600);
324fcf
 	}
324fcf
 
324fcf
@@ -429,7 +429,7 @@ void trace_file_replay (const char *file
324fcf
 	isc_result_t result;
324fcf
 	int len;
324fcf
 
324fcf
-	traceinfile = fopen (filename, "r");
324fcf
+	traceinfile = fopen (filename, "re");
324fcf
 	if (!traceinfile) {
324fcf
 		log_error("Can't open tracefile %s: %m", filename);
324fcf
 		return;
324fcf
diff -up dhcp-4.3.3b1/relay/dhcrelay.c.cloexec dhcp-4.3.3b1/relay/dhcrelay.c
324fcf
--- dhcp-4.3.3b1/relay/dhcrelay.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/relay/dhcrelay.c	2015-08-10 10:46:20.276755503 +0200
324fcf
@@ -187,11 +187,11 @@ main(int argc, char **argv) {
324fcf
 	/* Make sure that file descriptors 0(stdin), 1,(stdout), and
324fcf
 	   2(stderr) are open. To do this, we assume that when we
324fcf
 	   open a file the lowest available file descriptor is used. */
324fcf
-	fd = open("/dev/null", O_RDWR);
324fcf
+	fd = open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
 	if (fd == 0)
324fcf
-		fd = open("/dev/null", O_RDWR);
324fcf
+		fd = open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
 	if (fd == 1)
324fcf
-		fd = open("/dev/null", O_RDWR);
324fcf
+		fd = open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
 	if (fd == 2)
324fcf
 		log_perror = 0; /* No sense logging to /dev/null. */
324fcf
 	else if (fd != -1)
324fcf
@@ -558,13 +558,13 @@ main(int argc, char **argv) {
324fcf
 
324fcf
 		if (no_pid_file == ISC_FALSE) {
324fcf
 			pfdesc = open(path_dhcrelay_pid,
324fcf
-				      O_CREAT | O_TRUNC | O_WRONLY, 0644);
324fcf
+				      O_CREAT | O_TRUNC | O_WRONLY | O_CLOEXEC, 0644);
324fcf
 
324fcf
 			if (pfdesc < 0) {
324fcf
 				log_error("Can't create %s: %m",
324fcf
 					  path_dhcrelay_pid);
324fcf
 			} else {
324fcf
-				pf = fdopen(pfdesc, "w");
324fcf
+				pf = fdopen(pfdesc, "we");
324fcf
 				if (!pf)
324fcf
 					log_error("Can't fdopen %s: %m",
324fcf
 						  path_dhcrelay_pid);
324fcf
diff -up dhcp-4.3.3b1/server/confpars.c.cloexec dhcp-4.3.3b1/server/confpars.c
324fcf
--- dhcp-4.3.3b1/server/confpars.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/server/confpars.c	2015-08-10 10:46:20.277755500 +0200
324fcf
@@ -111,7 +111,7 @@ isc_result_t read_conf_file (const char
324fcf
 	}
324fcf
 #endif
324fcf
 
324fcf
-	if ((file = open (filename, O_RDONLY)) < 0) {
324fcf
+	if ((file = open (filename, O_RDONLY | O_CLOEXEC)) < 0) {
324fcf
 		if (leasep) {
324fcf
 			log_error ("Can't open lease database %s: %m --",
324fcf
 				   path_dhcpd_db);
324fcf
diff -up dhcp-4.3.3b1/server/db.c.cloexec dhcp-4.3.3b1/server/db.c
324fcf
--- dhcp-4.3.3b1/server/db.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/server/db.c	2015-08-10 10:47:32.644518358 +0200
324fcf
@@ -1072,7 +1072,7 @@ void db_startup (testp)
324fcf
 	}
324fcf
 #endif
324fcf
 	if (!testp) {
324fcf
-		db_file = fopen (path_dhcpd_db, "a");
324fcf
+		db_file = fopen (path_dhcpd_db, "ae");
324fcf
 		if (!db_file)
324fcf
 			log_fatal ("Can't open %s for append.", path_dhcpd_db);
324fcf
 		expire_all_pools ();
324fcf
@@ -1120,7 +1120,7 @@ int new_lease_file ()
324fcf
 		     path_dhcpd_db, (int)t) >= sizeof newfname)
324fcf
 		log_fatal("new_lease_file: lease file path too long");
324fcf
 
324fcf
-	db_fd = open (newfname, O_WRONLY | O_TRUNC | O_CREAT, 0664);
324fcf
+	db_fd = open (newfname, O_WRONLY | O_TRUNC | O_CREAT | O_CLOEXEC, 0664);
324fcf
 	if (db_fd < 0) {
324fcf
 		log_error ("Can't create new lease file: %m");
324fcf
 		return 0;
324fcf
@@ -1141,7 +1141,7 @@ int new_lease_file ()
324fcf
 	}
324fcf
 #endif /* PARANOIA */
324fcf
 
324fcf
-	if ((new_db_file = fdopen(db_fd, "w")) == NULL) {
324fcf
+	if ((new_db_file = fdopen(db_fd, "we")) == NULL) {
324fcf
 		log_error("Can't fdopen new lease file: %m");
324fcf
 		close(db_fd);
324fcf
 		goto fdfail;
324fcf
diff -up dhcp-4.3.3b1/server/dhcpd.c.cloexec dhcp-4.3.3b1/server/dhcpd.c
324fcf
--- dhcp-4.3.3b1/server/dhcpd.c.cloexec	2015-07-30 15:17:16.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/server/dhcpd.c	2015-08-10 10:46:20.278755497 +0200
324fcf
@@ -194,11 +194,11 @@ main(int argc, char **argv) {
324fcf
         /* Make sure that file descriptors 0 (stdin), 1, (stdout), and
324fcf
            2 (stderr) are open. To do this, we assume that when we
324fcf
            open a file the lowest available file descriptor is used. */
324fcf
-        fd = open("/dev/null", O_RDWR);
324fcf
+        fd = open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
         if (fd == 0)
324fcf
-                fd = open("/dev/null", O_RDWR);
324fcf
+                fd = open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
         if (fd == 1)
324fcf
-                fd = open("/dev/null", O_RDWR);
324fcf
+                fd = open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
         if (fd == 2)
324fcf
                 log_perror = 0; /* No sense logging to /dev/null. */
324fcf
         else if (fd != -1)
324fcf
@@ -743,7 +743,7 @@ main(int argc, char **argv) {
324fcf
 	 * appropriate.
324fcf
 	 */
324fcf
 	if (no_pid_file == ISC_FALSE) {
324fcf
-		i = open(path_dhcpd_pid, O_WRONLY|O_CREAT|O_TRUNC, 0644);
324fcf
+		i = open(path_dhcpd_pid, O_WRONLY|O_CREAT|O_TRUNC|O_CLOEXEC, 0644);
324fcf
 		if (i >= 0) {
324fcf
 			sprintf(pbuf, "%d\n", (int) getpid());
324fcf
 			IGNORE_RET(write(i, pbuf, strlen(pbuf)));
324fcf
@@ -787,9 +787,9 @@ main(int argc, char **argv) {
324fcf
                 (void) close(2);
324fcf
 
324fcf
                 /* Reopen them on /dev/null. */
324fcf
-                (void) open("/dev/null", O_RDWR);
324fcf
-                (void) open("/dev/null", O_RDWR);
324fcf
-                (void) open("/dev/null", O_RDWR);
324fcf
+                (void) open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
+                (void) open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
+                (void) open("/dev/null", O_RDWR | O_CLOEXEC);
324fcf
                 log_perror = 0; /* No sense logging to /dev/null. */
324fcf
 
324fcf
        		IGNORE_RET (chdir("/"));
324fcf
diff -up dhcp-4.3.3b1/server/ldap.c.cloexec dhcp-4.3.3b1/server/ldap.c
324fcf
--- dhcp-4.3.3b1/server/ldap.c.cloexec	2015-07-30 21:03:40.000000000 +0200
324fcf
+++ dhcp-4.3.3b1/server/ldap.c	2015-08-10 10:46:20.279755493 +0200
324fcf
@@ -1442,7 +1442,7 @@ ldap_start (void)
324fcf
 
324fcf
   if (ldap_debug_file != NULL && ldap_debug_fd == -1)
324fcf
     {
324fcf
-      if ((ldap_debug_fd = open (ldap_debug_file, O_CREAT | O_TRUNC | O_WRONLY,
324fcf
+      if ((ldap_debug_fd = open (ldap_debug_file, O_CREAT | O_TRUNC | O_WRONLY | O_CLOEXEC,
324fcf
                                  S_IRUSR | S_IWUSR)) < 0)
324fcf
         log_error ("Error opening debug LDAP log file %s: %s", ldap_debug_file,
324fcf
                    strerror (errno));