philipp / rpms / dhcp

Forked from rpms/dhcp 4 years ago
Clone

Blame SOURCES/dhcp-4.2.4-P1-interval.patch

45d60a
diff -up dhcp-4.2.4/common/dispatch.c.foo dhcp-4.2.4/common/dispatch.c
45d60a
--- dhcp-4.2.4/common/dispatch.c.foo	2012-07-26 21:31:43.875349675 -0500
45d60a
+++ dhcp-4.2.4/common/dispatch.c	2012-07-26 21:39:14.961710319 -0500
45d60a
@@ -324,7 +324,20 @@ void add_timeout (when, where, what, ref
45d60a
 	q->next  = timeouts;
45d60a
 	timeouts = q;
45d60a
 
45d60a
-	isc_interval_set(&interval, sec & DHCP_SEC_MAX, usec * 1000);
45d60a
+	/* isc_time_nowplusinterval() is not safe with 64-bit time_t and will
45d60a
+	 * return an error for sufficiently large intervals.  We have to limit
45d60a
+	 * the interval to INT_MAX or less to ensure the interval doesn't
45d60a
+	 * overflow 32 bits, since the returned isc_time_t fields are
45d60a
+	 * 32-bit unsigned ints.
45d60a
+	 *
45d60a
+	 * HACK: The 9 is a magic number of seconds, since some time may have
45d60a
+	 * gone by since the last call to gettimeofday() and the one in
45d60a
+	 * isc_time_nowplusinterval().
45d60a
+	 */
45d60a
+	if (sec > TIME_MAX)
45d60a
+		sec = TIME_MAX - 9;
45d60a
+
45d60a
+	isc_interval_set(&interval, sec, usec * 1000);
45d60a
 	status = isc_time_nowplusinterval(&expires, &interval);
45d60a
 	if (status != ISC_R_SUCCESS) {
45d60a
 		/*