From 999042579802d0443307ed18e8bb0b993c102c95 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 18 Jan 2017 17:08:19 +0100 Subject: [PATCH] Use proper logging for error messages https://fedorahosted.org/freeipa/ticket/6588r Reviewed-By: Stanislav Laznicka --- ipaserver/install/replication.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ipaserver/install/replication.py b/ipaserver/install/replication.py index be4de6dd0037a028bcaf1743be74a80855ba3541..1f437dad4ed850ebfd59fe9f72a5127df8f56f3e 100644 --- a/ipaserver/install/replication.py +++ b/ipaserver/install/replication.py @@ -171,7 +171,7 @@ def wait_for_entry(connection, dn, timeout=7200, attr='', quiet=True): except errors.NotFound: pass # no entry yet except Exception as e: # badness - print("\nError reading entry", dn, e) + root_logger.error("Error reading entry %s: %s", dn, e) break if not entry: if not quiet: @@ -180,11 +180,13 @@ def wait_for_entry(connection, dn, timeout=7200, attr='', quiet=True): time.sleep(1) if not entry and int(time.time()) > timeout: - print("\nwait_for_entry timeout for %s for %s" % (connection, dn)) + root_logger.error( + "wait_for_entry timeout for %s for %s", connection, dn) elif entry and not quiet: - print("\nThe waited for entry is:", entry) + root_logger.error("The waited for entry is: %s", entry) elif not entry: - print("\nError: could not read entry %s from %s" % (dn, connection)) + root_logger.error( + "Error: could not read entry %s from %s", dn, connection) class ReplicationManager(object): -- 2.9.3