|
 |
483b06 |
From 23030ef4f4faa9bf3ee13d13dedb2e0a21da1f2a Mon Sep 17 00:00:00 2001
|
|
|
483b06 |
From: Florence Blanc-Renaud <flo@redhat.com>
|
|
|
483b06 |
Date: Wed, 3 May 2017 10:21:12 +0200
|
|
|
483b06 |
Subject: [PATCH] ipa-server-install with external CA: fix pkinit cert issuance
|
|
|
483b06 |
|
|
|
483b06 |
ipa-server-install with external CA fails to issue pkinit certs.
|
|
|
483b06 |
This happens because the installer calls
|
|
|
483b06 |
krb = krbinstance.KrbInstance(fstore)
|
|
|
483b06 |
then
|
|
|
483b06 |
krb.enable_ssl()
|
|
|
483b06 |
and in this code path self.config_pkinit is set to None, leading to a wrong
|
|
|
483b06 |
code path.
|
|
|
483b06 |
|
|
|
483b06 |
The fix initializes the required fields of the krbinstance before calling
|
|
|
483b06 |
krb.enable_ssl.
|
|
|
483b06 |
|
|
|
483b06 |
https://pagure.io/freeipa/issue/6921
|
|
|
483b06 |
|
|
|
483b06 |
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
|
|
|
483b06 |
Reviewed-By: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
483b06 |
---
|
|
|
483b06 |
ipaserver/install/krbinstance.py | 8 ++++++++
|
|
|
483b06 |
ipaserver/install/server/install.py | 4 ++++
|
|
|
483b06 |
2 files changed, 12 insertions(+)
|
|
|
483b06 |
|
|
|
483b06 |
diff --git a/ipaserver/install/krbinstance.py b/ipaserver/install/krbinstance.py
|
|
|
483b06 |
index 76ac3029ca6d1cbdd85c6ced6272c6f9a21f04a1..2f14ff592064d3446f73b31e615b2de88d6d786c 100644
|
|
|
483b06 |
--- a/ipaserver/install/krbinstance.py
|
|
|
483b06 |
+++ b/ipaserver/install/krbinstance.py
|
|
|
483b06 |
@@ -108,6 +108,14 @@ class KrbInstance(service.Service):
|
|
|
483b06 |
suffix = ipautil.dn_attribute_property('_suffix')
|
|
|
483b06 |
subject_base = ipautil.dn_attribute_property('_subject_base')
|
|
|
483b06 |
|
|
|
483b06 |
+ def init_info(self, realm_name, host_name, setup_pkinit=False,
|
|
|
483b06 |
+ subject_base=None):
|
|
|
483b06 |
+ self.fqdn = host_name
|
|
|
483b06 |
+ self.realm = realm_name
|
|
|
483b06 |
+ self.suffix = ipautil.realm_to_suffix(realm_name)
|
|
|
483b06 |
+ self.subject_base = subject_base
|
|
|
483b06 |
+ self.config_pkinit = setup_pkinit
|
|
|
483b06 |
+
|
|
|
483b06 |
def get_realm_suffix(self):
|
|
|
483b06 |
return DN(('cn', self.realm), ('cn', 'kerberos'), self.suffix)
|
|
|
483b06 |
|
|
|
483b06 |
diff --git a/ipaserver/install/server/install.py b/ipaserver/install/server/install.py
|
|
|
483b06 |
index b360e0532ce1b9b729be1cc2398cb2b46620901c..0ce60e964cb210708e56fb43a5b70f8e3405caf2 100644
|
|
|
483b06 |
--- a/ipaserver/install/server/install.py
|
|
|
483b06 |
+++ b/ipaserver/install/server/install.py
|
|
|
483b06 |
@@ -768,6 +768,10 @@ def install(installer):
|
|
|
483b06 |
setup_pkinit=not options.no_pkinit,
|
|
|
483b06 |
pkcs12_info=pkinit_pkcs12_info,
|
|
|
483b06 |
subject_base=options.subject_base)
|
|
|
483b06 |
+ else:
|
|
|
483b06 |
+ krb.init_info(realm_name, host_name,
|
|
|
483b06 |
+ setup_pkinit=not options.no_pkinit,
|
|
|
483b06 |
+ subject_base=options.subject_base)
|
|
|
483b06 |
|
|
|
483b06 |
if setup_ca:
|
|
|
483b06 |
if not options.external_cert_files and options.external_ca:
|
|
|
483b06 |
--
|
|
|
483b06 |
2.12.2
|
|
|
483b06 |
|