pgreco / rpms / ipa

Forked from forks/areguera/rpms/ipa 4 years ago
Clone
f65af0
From fd54380d684494e13d8e797b17412a6713937b95 Mon Sep 17 00:00:00 2001
f65af0
From: =?UTF-8?q?Tibor=20Dudl=C3=A1k?= <tdudlak@redhat.com>
f65af0
Date: Thu, 2 Aug 2018 18:05:51 +0200
f65af0
Subject: [PATCH] Re-open the ldif file to prevent error message
f65af0
f65af0
There was an issue with ipa-server-upgrade and it was
f65af0
showing an error while upgrading:
f65af0
DN... does not exists or haven't been updated, caused
f65af0
by not moving pointer to file begining when re-reading.
f65af0
f65af0
Resolves: https://pagure.io/freeipa/issue/7644
f65af0
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
f65af0
Reviewed-By: Christian Heimes <cheimes@redhat.com>
f65af0
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
f65af0
---
f65af0
 ipaserver/install/upgradeinstance.py | 21 +++++++++++++--------
f65af0
 1 file changed, 13 insertions(+), 8 deletions(-)
f65af0
f65af0
diff --git a/ipaserver/install/upgradeinstance.py b/ipaserver/install/upgradeinstance.py
f65af0
index 19a06a0a84536cb548822e47038142e97d8bee39..cb83d7bb1817d1fd9a36f2e97a5cc80bf806cabd 100644
f65af0
--- a/ipaserver/install/upgradeinstance.py
f65af0
+++ b/ipaserver/install/upgradeinstance.py
f65af0
@@ -237,17 +237,22 @@ class IPAUpgrade(service.Service):
f65af0
 
f65af0
     def __disable_schema_compat(self):
f65af0
         ldif_outfile = "%s.modified.out" % self.filename
f65af0
+
f65af0
+        with open(self.filename, "r") as in_file:
f65af0
+            parser = GetEntryFromLDIF(in_file, entries_dn=[COMPAT_DN])
f65af0
+            parser.parse()
f65af0
+
f65af0
+        try:
f65af0
+            compat_entry = parser.get_results()[COMPAT_DN]
f65af0
+        except KeyError:
f65af0
+            return
f65af0
+
f65af0
+        if not compat_entry.get('nsslapd-pluginEnabled'):
f65af0
+            return
f65af0
+
f65af0
         with open(ldif_outfile, "w") as out_file:
f65af0
             with open(self.filename, "r") as in_file:
f65af0
-                parser = GetEntryFromLDIF(in_file, entries_dn=[COMPAT_DN])
f65af0
-                parser.parse()
f65af0
-                try:
f65af0
-                    compat_entry = parser.get_results()[COMPAT_DN]
f65af0
-                except KeyError:
f65af0
-                    return
f65af0
                 parser = installutils.ModifyLDIF(in_file, out_file)
f65af0
-                if not compat_entry.get('nsslapd-pluginEnabled'):
f65af0
-                    return
f65af0
                 parser.remove_value(COMPAT_DN, "nsslapd-pluginEnabled")
f65af0
                 parser.remove_value(COMPAT_DN, "nsslapd-pluginenabled")
f65af0
                 parser.add_value(COMPAT_DN, "nsslapd-pluginEnabled",
f65af0
-- 
f65af0
2.17.1
f65af0