From 11c4a7b38a6aeef51b075d70e5aca36c42398842 Mon Sep 17 00:00:00 2001 From: Qu Wenruo Date: Mon, 20 Jul 2020 20:51:09 +0800 Subject: [PATCH 2/2] btrfs-progs: tests: add convert test case for multiply overflow The new test case will test whether btrfs-convert can handle 64G ext* fs. This exercise the cctx->total_bytes calculation where multiplying 4K (unsigned int) and 16777216 (u32) could lead to bit overflow for unsigned int and got 0, and screw up later free space calculation. Signed-off-by: Qu Wenruo Signed-off-by: David Sterba (cherry picked from commit 61f41474469b0b0fba9ec1978dfa91d9cbc6c914) --- .../018-fs-size-overflow/test.sh | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100755 tests/convert-tests/018-fs-size-overflow/test.sh diff --git a/tests/convert-tests/018-fs-size-overflow/test.sh b/tests/convert-tests/018-fs-size-overflow/test.sh new file mode 100755 index 00000000..d819f695 --- /dev/null +++ b/tests/convert-tests/018-fs-size-overflow/test.sh @@ -0,0 +1,19 @@ +#!/bin/bash +# Check if btrfs-convert can handle an ext4 fs whose size is 64G. +# That fs size could trigger a multiply overflow and screw up free space +# calculation + +source "$TEST_TOP/common" +source "$TEST_TOP/common.convert" + +setup_root_helper +prepare_test_dev 64g +check_prereq btrfs-convert +check_global_prereq mke2fs + +convert_test_prep_fs ext4 mke2fs -t ext4 -b 4096 +run_check_umount_test_dev + +# Unpatched btrfs-convert would fail half way due to corrupted free space +# cache tree +convert_test_do_convert -- 2.26.2