olga / rpms / glibc

Forked from rpms/glibc 5 years ago
Clone

Blame SOURCES/glibc-rh1659438-32.patch

077c9d
commit 581a051c2e09a847332d4750f6132de0f0ad15b6
077c9d
Author: Stefan Liebler <stli@linux.ibm.com>
077c9d
Date:   Tue Dec 18 13:57:16 2018 +0100
077c9d
077c9d
    S390: Refactor memchr ifunc handling.
077c9d
    
077c9d
    The ifunc handling for memchr is adjusted in order to omit ifunc
077c9d
    variants if those will never be used as the minimum architecture level
077c9d
    already supports newer CPUs by default.
077c9d
    Glibc internal calls will then also use the "newer" ifunc variant.
077c9d
    
077c9d
    Note: The fallback s390-32/s390-64 ifunc variants with srst instruction
077c9d
    are now moved to the unified memchr-z900.S file which can be used for
077c9d
    31/64bit. The s390-32/s390-64 files multiarch/memchr.c and memchr.S
077c9d
    are deleted.
077c9d
    
077c9d
    ChangeLog:
077c9d
    
077c9d
            * sysdeps/s390/multiarch/Makefile
077c9d
            (sysdep_routines): Remove memchr variants.
077c9d
            * sysdeps/s390/Makefile (sysdep_routines): Add memchr variants.
077c9d
            * sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
            (__libc_ifunc_impl_list): Refactor ifunc handling for memchr.
077c9d
            * sysdeps/s390/multiarch/memchr-vx.S: Move to ...
077c9d
            * sysdeps/s390/memchr-vx.S: ... here and adjust ifunc handling.
077c9d
            * sysdeps/s390/multiarch/memchr.c: Move to ...
077c9d
            * sysdeps/s390/memchr.c: ... here and adjust ifunc handling.
077c9d
            * sysdeps/s390/ifunc-memchr.h: New file.
077c9d
            * sysdeps/s390/s390-64/memchr.S: Move to ...
077c9d
            * sysdeps/s390/memchr-z900.S: ... here and adjust to be usable
077c9d
            for 31/64bit and ifunc handling.
077c9d
            * sysdeps/s390/s390-32/multiarch/memchr.c: Delete file.
077c9d
            * sysdeps/s390/s390-64/multiarch/memchr.c: Likewise.
077c9d
            * sysdeps/s390/s390-32/memchr.S: Likewise.
077c9d
077c9d
diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
077c9d
index 092d55826fbd15a5..816b2fccdc75e4cf 100644
077c9d
--- a/sysdeps/s390/Makefile
077c9d
+++ b/sysdeps/s390/Makefile
077c9d
@@ -52,5 +52,6 @@ sysdep_routines += bzero memset memset-z900 \
077c9d
 		   strrchr strrchr-vx strrchr-c \
077c9d
 		   strspn strspn-vx strspn-c \
077c9d
 		   strpbrk strpbrk-vx strpbrk-c \
077c9d
-		   strcspn strcspn-vx strcspn-c
077c9d
+		   strcspn strcspn-vx strcspn-c \
077c9d
+		   memchr memchr-vx memchr-z900
077c9d
 endif
077c9d
diff --git a/sysdeps/s390/ifunc-memchr.h b/sysdeps/s390/ifunc-memchr.h
077c9d
new file mode 100644
077c9d
index 0000000000000000..5d1327b45353322b
077c9d
--- /dev/null
077c9d
+++ b/sysdeps/s390/ifunc-memchr.h
077c9d
@@ -0,0 +1,52 @@
077c9d
+/* memchr variant information on S/390 version.
077c9d
+   Copyright (C) 2018 Free Software Foundation, Inc.
077c9d
+   This file is part of the GNU C Library.
077c9d
+
077c9d
+   The GNU C Library is free software; you can redistribute it and/or
077c9d
+   modify it under the terms of the GNU Lesser General Public
077c9d
+   License as published by the Free Software Foundation; either
077c9d
+   version 2.1 of the License, or (at your option) any later version.
077c9d
+
077c9d
+   The GNU C Library is distributed in the hope that it will be useful,
077c9d
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
+   Lesser General Public License for more details.
077c9d
+
077c9d
+   You should have received a copy of the GNU Lesser General Public
077c9d
+   License along with the GNU C Library; if not, see
077c9d
+   <http://www.gnu.org/licenses/>.  */
077c9d
+
077c9d
+#if defined USE_MULTIARCH && IS_IN (libc)		\
077c9d
+  && ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
077c9d
+# define HAVE_MEMCHR_IFUNC	1
077c9d
+#else
077c9d
+# define HAVE_MEMCHR_IFUNC	0
077c9d
+#endif
077c9d
+
077c9d
+#ifdef HAVE_S390_VX_ASM_SUPPORT
077c9d
+# define HAVE_MEMCHR_IFUNC_AND_VX_SUPPORT HAVE_MEMCHR_IFUNC
077c9d
+#else
077c9d
+# define HAVE_MEMCHR_IFUNC_AND_VX_SUPPORT 0
077c9d
+#endif
077c9d
+
077c9d
+#if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
077c9d
+# define MEMCHR_DEFAULT		MEMCHR_Z13
077c9d
+# define HAVE_MEMCHR_Z900_G5	0
077c9d
+# define HAVE_MEMCHR_Z13	1
077c9d
+#else
077c9d
+# define MEMCHR_DEFAULT		MEMCHR_Z900_G5
077c9d
+# define HAVE_MEMCHR_Z900_G5	1
077c9d
+# define HAVE_MEMCHR_Z13	HAVE_MEMCHR_IFUNC_AND_VX_SUPPORT
077c9d
+#endif
077c9d
+
077c9d
+#if HAVE_MEMCHR_Z900_G5
077c9d
+# define MEMCHR_Z900_G5		__memchr_default
077c9d
+#else
077c9d
+# define MEMCHR_Z900_G5		NULL
077c9d
+#endif
077c9d
+
077c9d
+#if HAVE_MEMCHR_Z13
077c9d
+# define MEMCHR_Z13		__memchr_vx
077c9d
+#else
077c9d
+# define MEMCHR_Z13		NULL
077c9d
+#endif
077c9d
diff --git a/sysdeps/s390/multiarch/memchr-vx.S b/sysdeps/s390/memchr-vx.S
077c9d
similarity index 92%
077c9d
rename from sysdeps/s390/multiarch/memchr-vx.S
077c9d
rename to sysdeps/s390/memchr-vx.S
077c9d
index 77d31e0036915665..274e7971ca7e9413 100644
077c9d
--- a/sysdeps/s390/multiarch/memchr-vx.S
077c9d
+++ b/sysdeps/s390/memchr-vx.S
077c9d
@@ -16,7 +16,8 @@
077c9d
    License along with the GNU C Library; if not, see
077c9d
    <http://www.gnu.org/licenses/>.  */
077c9d
 
077c9d
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
077c9d
+#include <ifunc-memchr.h>
077c9d
+#if HAVE_MEMCHR_Z13
077c9d
 
077c9d
 # include "sysdep.h"
077c9d
 # include "asm-syntax.h"
077c9d
@@ -38,7 +39,7 @@
077c9d
    -v17=index of found c
077c9d
    -v18=c replicated
077c9d
 */
077c9d
-ENTRY(__memchr_vx)
077c9d
+ENTRY(MEMCHR_Z13)
077c9d
 
077c9d
 	.machine "z13"
077c9d
 	.machinemode "zarch_nohighgprs"
077c9d
@@ -149,11 +150,14 @@ ENTRY(__memchr_vx)
077c9d
 	clgrjl	%r0,%r4,.Lloop64
077c9d
 
077c9d
 	j	.Llt64
077c9d
-END(__memchr_vx)
077c9d
+END(MEMCHR_Z13)
077c9d
 
077c9d
-# define memchr __memchr_c
077c9d
-# undef libc_hidden_builtin_def
077c9d
-# define libc_hidden_builtin_def(name) strong_alias(__memchr_c, __GI_memchr)
077c9d
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
077c9d
+# if ! HAVE_MEMCHR_IFUNC
077c9d
+strong_alias (MEMCHR_Z13, __memchr)
077c9d
+weak_alias (__memchr, memchr)
077c9d
+# endif
077c9d
 
077c9d
-#include <memchr.S>
077c9d
+# if ! HAVE_MEMCHR_Z900_G5 && defined SHARED && IS_IN (libc)
077c9d
+strong_alias (MEMCHR_Z13, __GI_memchr)
077c9d
+# endif
077c9d
+#endif
077c9d
diff --git a/sysdeps/s390/s390-64/memchr.S b/sysdeps/s390/memchr-z900.S
077c9d
similarity index 63%
077c9d
rename from sysdeps/s390/s390-64/memchr.S
077c9d
rename to sysdeps/s390/memchr-z900.S
077c9d
index a19fcafa147dc338..c016bc41c61be2dc 100644
077c9d
--- a/sysdeps/s390/s390-64/memchr.S
077c9d
+++ b/sysdeps/s390/memchr-z900.S
077c9d
@@ -1,4 +1,4 @@
077c9d
-/* Search a character in a block of memory.  64 bit S/390 version.
077c9d
+/* Search a character in a block of memory.  31/64 bit S/390 version.
077c9d
    Copyright (C) 2001-2018 Free Software Foundation, Inc.
077c9d
    Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
077c9d
    This file is part of the GNU C Library.
077c9d
@@ -22,19 +22,42 @@
077c9d
      %r3 = character to find
077c9d
      %r4 = number of bytes to search.  */
077c9d
 
077c9d
+#include <ifunc-memchr.h>
077c9d
 #include "sysdep.h"
077c9d
 #include "asm-syntax.h"
077c9d
 
077c9d
+#if HAVE_MEMCHR_Z900_G5
077c9d
+# if defined __s390x__
077c9d
+#  define SLGR	slgr
077c9d
+#  define LGHI	lghi
077c9d
+#  define NGR	ngr
077c9d
+#  define LGR	lgr
077c9d
+# else
077c9d
+#  define SLGR	slr
077c9d
+#  define LGHI	lhi
077c9d
+#  define NGR	nr
077c9d
+#  define LGR	lr
077c9d
+# endif /* ! defined __s390x__  */
077c9d
+
077c9d
 	.text
077c9d
-ENTRY(memchr)
077c9d
-	lghi  %r0,0xff
077c9d
-	ngr   %r0,%r3
077c9d
-	lgr   %r1,%r2
077c9d
+ENTRY(MEMCHR_Z900_G5)
077c9d
+	LGHI  %r0,0xff
077c9d
+	NGR   %r0,%r3
077c9d
+	LGR   %r1,%r2
077c9d
 	la    %r2,0(%r4,%r1)
077c9d
 0:	srst  %r2,%r1
077c9d
 	jo    0b
077c9d
 	brc   13,1f
077c9d
-	slgr  %r2,%r2
077c9d
+	SLGR  %r2,%r2
077c9d
 1:	br    %r14
077c9d
-END(memchr)
077c9d
-libc_hidden_builtin_def (memchr)
077c9d
+END(MEMCHR_Z900_G5)
077c9d
+
077c9d
+# if ! HAVE_MEMCHR_IFUNC
077c9d
+strong_alias (MEMCHR_Z900_G5, __memchr)
077c9d
+weak_alias (__memchr, memchr)
077c9d
+# endif
077c9d
+
077c9d
+# if defined SHARED && IS_IN (libc)
077c9d
+strong_alias (MEMCHR_Z900_G5, __GI_memchr)
077c9d
+# endif
077c9d
+#endif
077c9d
diff --git a/sysdeps/s390/multiarch/memchr.c b/sysdeps/s390/memchr.c
077c9d
similarity index 68%
077c9d
rename from sysdeps/s390/multiarch/memchr.c
077c9d
rename to sysdeps/s390/memchr.c
077c9d
index 3885ebaa4d90ed1a..490f1b66002aae05 100644
077c9d
--- a/sysdeps/s390/multiarch/memchr.c
077c9d
+++ b/sysdeps/s390/memchr.c
077c9d
@@ -16,12 +16,26 @@
077c9d
    License along with the GNU C Library; if not, see
077c9d
    <http://www.gnu.org/licenses/>.  */
077c9d
 
077c9d
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
077c9d
+#include <ifunc-memchr.h>
077c9d
+
077c9d
+#if HAVE_MEMCHR_IFUNC
077c9d
 # define memchr __redirect_memchr
077c9d
 # include <string.h>
077c9d
 # undef memchr
077c9d
 # include <ifunc-resolve.h>
077c9d
 
077c9d
-s390_vx_libc_ifunc2_redirected (__redirect_memchr, __memchr, memchr)
077c9d
+# if HAVE_MEMCHR_Z900_G5
077c9d
+extern __typeof (__redirect_memchr) MEMCHR_Z900_G5 attribute_hidden;
077c9d
+# endif
077c9d
+
077c9d
+# if HAVE_MEMCHR_Z13
077c9d
+extern __typeof (__redirect_memchr) MEMCHR_Z13 attribute_hidden;
077c9d
+# endif
077c9d
 
077c9d
+s390_libc_ifunc_expr (__redirect_memchr, __memchr,
077c9d
+		      (HAVE_MEMCHR_Z13 && (hwcap & HWCAP_S390_VX))
077c9d
+		      ? MEMCHR_Z13
077c9d
+		      : MEMCHR_DEFAULT
077c9d
+		      )
077c9d
+weak_alias (__memchr, memchr)
077c9d
 #endif
077c9d
diff --git a/sysdeps/s390/multiarch/Makefile b/sysdeps/s390/multiarch/Makefile
077c9d
index 1578f21af4a1bd06..fa1f7b81db912be0 100644
077c9d
--- a/sysdeps/s390/multiarch/Makefile
077c9d
+++ b/sysdeps/s390/multiarch/Makefile
077c9d
@@ -1,6 +1,5 @@
077c9d
 ifeq ($(subdir),string)
077c9d
-sysdep_routines += memchr memchr-vx \
077c9d
-		   rawmemchr rawmemchr-vx rawmemchr-c \
077c9d
+sysdep_routines += rawmemchr rawmemchr-vx rawmemchr-c \
077c9d
 		   memccpy memccpy-vx memccpy-c \
077c9d
 		   memrchr memrchr-vx memrchr-c
077c9d
 endif
077c9d
diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
index 2d48c99c8d5663fe..b4be0140424aed69 100644
077c9d
--- a/sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
+++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
@@ -42,6 +42,7 @@
077c9d
 #include <ifunc-strspn.h>
077c9d
 #include <ifunc-strpbrk.h>
077c9d
 #include <ifunc-strcspn.h>
077c9d
+#include <ifunc-memchr.h>
077c9d
 
077c9d
 /* Maximum number of IFUNC implementations.  */
077c9d
 #define MAX_IFUNC	3
077c9d
@@ -372,6 +373,18 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
077c9d
 		)
077c9d
 #endif /* HAVE_STRCSPN_IFUNC  */
077c9d
 
077c9d
+#if HAVE_MEMCHR_IFUNC
077c9d
+    IFUNC_IMPL (i, name, memchr,
077c9d
+# if HAVE_MEMCHR_Z13
077c9d
+		IFUNC_IMPL_ADD (array, i, memchr,
077c9d
+				dl_hwcap & HWCAP_S390_VX, MEMCHR_Z13)
077c9d
+# endif
077c9d
+# if HAVE_MEMCHR_Z900_G5
077c9d
+		IFUNC_IMPL_ADD (array, i, memchr, 1, MEMCHR_Z900_G5)
077c9d
+# endif
077c9d
+		)
077c9d
+#endif /* HAVE_MEMCHR_IFUNC  */
077c9d
+
077c9d
 #ifdef HAVE_S390_VX_ASM_SUPPORT
077c9d
 
077c9d
 # define IFUNC_VX_IMPL(FUNC)						\
077c9d
@@ -412,7 +425,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
077c9d
 
077c9d
   IFUNC_VX_IMPL (wcscspn);
077c9d
 
077c9d
-  IFUNC_VX_IMPL (memchr);
077c9d
   IFUNC_VX_IMPL (wmemchr);
077c9d
   IFUNC_VX_IMPL (rawmemchr);
077c9d
 
077c9d
diff --git a/sysdeps/s390/s390-32/memchr.S b/sysdeps/s390/s390-32/memchr.S
077c9d
deleted file mode 100644
077c9d
index 54f9b85f578fa1c7..0000000000000000
077c9d
--- a/sysdeps/s390/s390-32/memchr.S
077c9d
+++ /dev/null
077c9d
@@ -1,41 +0,0 @@
077c9d
-/* Search a character in a block of memory.  For IBM S390
077c9d
-   Copyright (C) 2000-2018 Free Software Foundation, Inc.
077c9d
-   This file is part of the GNU C Library.
077c9d
-   Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
077c9d
-
077c9d
-   The GNU C Library is free software; you can redistribute it and/or
077c9d
-   modify it under the terms of the GNU Lesser General Public
077c9d
-   License as published by the Free Software Foundation; either
077c9d
-   version 2.1 of the License, or (at your option) any later version.
077c9d
-
077c9d
-   The GNU C Library is distributed in the hope that it will be useful,
077c9d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
-   Lesser General Public License for more details.
077c9d
-
077c9d
-   You should have received a copy of the GNU Lesser General Public
077c9d
-   License along with the GNU C Library; if not, see
077c9d
-   <http://www.gnu.org/licenses/>.  */
077c9d
-
077c9d
-/*
077c9d
- * R2 = address to memory area
077c9d
- * R3 = character to find
077c9d
- * R4 = number of bytes to search
077c9d
- */
077c9d
-
077c9d
-#include "sysdep.h"
077c9d
-#include "asm-syntax.h"
077c9d
-
077c9d
-	.text
077c9d
-ENTRY(memchr)
077c9d
-	lhi   %r0,0xff
077c9d
-	nr    %r0,%r3
077c9d
-	lr    %r1,%r2
077c9d
-	la    %r2,0(%r4,%r1)
077c9d
-0:      srst  %r2,%r1
077c9d
-	jo    0b
077c9d
-	brc   13,1f
077c9d
-	slr   %r2,%r2
077c9d
-1:      br    %r14
077c9d
-END(memchr)
077c9d
-libc_hidden_builtin_def (memchr)
077c9d
diff --git a/sysdeps/s390/s390-32/multiarch/memchr.c b/sysdeps/s390/s390-32/multiarch/memchr.c
077c9d
deleted file mode 100644
077c9d
index 5e1610afa43ee549..0000000000000000
077c9d
--- a/sysdeps/s390/s390-32/multiarch/memchr.c
077c9d
+++ /dev/null
077c9d
@@ -1,21 +0,0 @@
077c9d
-/* Multiple versions of memchr.
077c9d
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
077c9d
-   This file is part of the GNU C Library.
077c9d
-
077c9d
-   The GNU C Library is free software; you can redistribute it and/or
077c9d
-   modify it under the terms of the GNU Lesser General Public
077c9d
-   License as published by the Free Software Foundation; either
077c9d
-   version 2.1 of the License, or (at your option) any later version.
077c9d
-
077c9d
-   The GNU C Library is distributed in the hope that it will be useful,
077c9d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
-   Lesser General Public License for more details.
077c9d
-
077c9d
-   You should have received a copy of the GNU Lesser General Public
077c9d
-   License along with the GNU C Library; if not, see
077c9d
-   <http://www.gnu.org/licenses/>.  */
077c9d
-
077c9d
-/* This wrapper-file is needed, because otherwise file
077c9d
-   sysdeps/s390/s390-[32|64]/memchr.S will be used.  */
077c9d
-#include <sysdeps/s390/multiarch/memchr.c>
077c9d
diff --git a/sysdeps/s390/s390-64/multiarch/memchr.c b/sysdeps/s390/s390-64/multiarch/memchr.c
077c9d
deleted file mode 100644
077c9d
index 5e1610afa43ee549..0000000000000000
077c9d
--- a/sysdeps/s390/s390-64/multiarch/memchr.c
077c9d
+++ /dev/null
077c9d
@@ -1,21 +0,0 @@
077c9d
-/* Multiple versions of memchr.
077c9d
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
077c9d
-   This file is part of the GNU C Library.
077c9d
-
077c9d
-   The GNU C Library is free software; you can redistribute it and/or
077c9d
-   modify it under the terms of the GNU Lesser General Public
077c9d
-   License as published by the Free Software Foundation; either
077c9d
-   version 2.1 of the License, or (at your option) any later version.
077c9d
-
077c9d
-   The GNU C Library is distributed in the hope that it will be useful,
077c9d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
-   Lesser General Public License for more details.
077c9d
-
077c9d
-   You should have received a copy of the GNU Lesser General Public
077c9d
-   License along with the GNU C Library; if not, see
077c9d
-   <http://www.gnu.org/licenses/>.  */
077c9d
-
077c9d
-/* This wrapper-file is needed, because otherwise file
077c9d
-   sysdeps/s390/s390-[32|64]/memchr.S will be used.  */
077c9d
-#include <sysdeps/s390/multiarch/memchr.c>