nalika / rpms / grub2

Forked from rpms/grub2 2 years ago
Clone

Blame SOURCES/0529-misc-Format-string-for-grub_error-should-be-a-litera.patch

0ccc47
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
0ccc47
From: Glenn Washburn <development@efficientek.com>
0ccc47
Date: Thu, 4 Mar 2021 18:22:32 -0600
0ccc47
Subject: [PATCH] misc: Format string for grub_error() should be a literal
0ccc47
0ccc47
Signed-off-by: Glenn Washburn <development@efficientek.com>
0ccc47
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
0ccc47
(cherry-picked from commit 60875f4e15d704b875969b415501802b531c4db3)
0ccc47
---
0ccc47
 grub-core/loader/efi/chainloader.c | 2 +-
0ccc47
 grub-core/net/tftp.c               | 2 +-
0ccc47
 grub-core/script/lexer.c           | 2 +-
0ccc47
 3 files changed, 3 insertions(+), 3 deletions(-)
0ccc47
0ccc47
diff --git a/grub-core/loader/efi/chainloader.c b/grub-core/loader/efi/chainloader.c
0ccc47
index 720f6181e5..8e658f713e 100644
0ccc47
--- a/grub-core/loader/efi/chainloader.c
0ccc47
+++ b/grub-core/loader/efi/chainloader.c
0ccc47
@@ -79,7 +79,7 @@ grub_start_image (grub_efi_handle_t handle)
0ccc47
 	      *grub_utf16_to_utf8 ((grub_uint8_t *) buf,
0ccc47
 				   exit_data, exit_data_size) = 0;
0ccc47
 
0ccc47
-	      grub_error (GRUB_ERR_BAD_OS, buf);
0ccc47
+	      grub_error (GRUB_ERR_BAD_OS, "%s", buf);
0ccc47
 	      grub_free (buf);
0ccc47
 	    }
0ccc47
 	}
0ccc47
diff --git a/grub-core/net/tftp.c b/grub-core/net/tftp.c
0ccc47
index 85be965470..69a9ba6979 100644
0ccc47
--- a/grub-core/net/tftp.c
0ccc47
+++ b/grub-core/net/tftp.c
0ccc47
@@ -253,7 +253,7 @@ tftp_receive (grub_net_udp_socket_t sock __attribute__ ((unused)),
0ccc47
     case TFTP_ERROR:
0ccc47
       data->have_oack = 1;
0ccc47
       grub_netbuff_free (nb);
0ccc47
-      grub_error (GRUB_ERR_IO, (char *) tftph->u.err.errmsg);
0ccc47
+      grub_error (GRUB_ERR_IO, "%s", tftph->u.err.errmsg);
0ccc47
       grub_error_save (&data->save_err);
0ccc47
       return GRUB_ERR_NONE;
0ccc47
     default:
0ccc47
diff --git a/grub-core/script/lexer.c b/grub-core/script/lexer.c
0ccc47
index 5fb0cbd0bc..27daad791c 100644
0ccc47
--- a/grub-core/script/lexer.c
0ccc47
+++ b/grub-core/script/lexer.c
0ccc47
@@ -349,7 +349,7 @@ void
0ccc47
 grub_script_yyerror (struct grub_parser_param *state, char const *err)
0ccc47
 {
0ccc47
   if (err)
0ccc47
-    grub_error (GRUB_ERR_INVALID_COMMAND, err);
0ccc47
+    grub_error (GRUB_ERR_INVALID_COMMAND, "%s", err);
0ccc47
 
0ccc47
   grub_print_error ();
0ccc47
   state->err++;