|
 |
5593c8 |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
5593c8 |
From: Javier Martinez Canillas <javierm@redhat.com>
|
|
|
5593c8 |
Date: Tue, 26 May 2020 16:59:28 +0200
|
|
|
5593c8 |
Subject: [PATCH] x86-efi: Reduce maximum bounce buffer size to 16 MiB
|
|
|
5593c8 |
|
|
|
5593c8 |
The EFI linux loader allocates a bounce buffer to copy the initrd since in
|
|
|
5593c8 |
some machines doing DMA on addresses above 4GB is not possible during EFI.
|
|
|
5593c8 |
|
|
|
5593c8 |
But the verifiers framework also allocates a buffer to copy the initrd in
|
|
|
5593c8 |
its grub_file_open() handler. It does this since the data to verify has to
|
|
|
5593c8 |
be passed as a single chunk to modules that use the verifiers framework.
|
|
|
5593c8 |
|
|
|
5593c8 |
If the initrd image size is big there may not be enough memory in the heap
|
|
|
5593c8 |
to allocate two buffers of that size. This causes an allocation failure in
|
|
|
5593c8 |
the verifiers framework and leads to the initrd not being read.
|
|
|
5593c8 |
|
|
|
5593c8 |
To prevent these allocation failures, let's reduce the maximum size of the
|
|
|
5593c8 |
bounce buffer used in the EFI loader. Since the data read can be copied to
|
|
|
5593c8 |
the actual initrd address in multilple chunks.
|
|
|
5593c8 |
|
|
|
5593c8 |
Resolves: rhbz#1838633
|
|
|
5593c8 |
|
|
|
5593c8 |
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
|
|
|
5593c8 |
---
|
|
|
5593c8 |
grub-core/loader/i386/efi/linux.c | 2 +-
|
|
|
5593c8 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
5593c8 |
|
|
|
5593c8 |
diff --git a/grub-core/loader/i386/efi/linux.c b/grub-core/loader/i386/efi/linux.c
|
|
|
5593c8 |
index 6bc18d5aef5..15d40d6e35b 100644
|
|
|
5593c8 |
--- a/grub-core/loader/i386/efi/linux.c
|
|
|
5593c8 |
+++ b/grub-core/loader/i386/efi/linux.c
|
|
|
5593c8 |
@@ -144,7 +144,7 @@ grub_linuxefi_unload (void)
|
|
|
5593c8 |
return GRUB_ERR_NONE;
|
|
|
5593c8 |
}
|
|
|
5593c8 |
|
|
|
5593c8 |
-#define BOUNCE_BUFFER_MAX 0x10000000ull
|
|
|
5593c8 |
+#define BOUNCE_BUFFER_MAX 0x1000000ull
|
|
|
5593c8 |
|
|
|
5593c8 |
static grub_ssize_t
|
|
|
5593c8 |
read(grub_file_t file, grub_uint8_t *bufp, grub_size_t len)
|