|
 |
9fc0f6 |
From 91eda57764f26d3ebdbf8194a528d8d60d0f409a Mon Sep 17 00:00:00 2001
|
|
|
9fc0f6 |
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
|
|
|
9fc0f6 |
Date: Sat, 5 Oct 2013 22:47:52 -0400
|
|
|
9fc0f6 |
Subject: [PATCH] utf8: fix utf8_is_printable
|
|
|
9fc0f6 |
|
|
|
9fc0f6 |
---
|
|
|
9fc0f6 |
src/shared/utf8.c | 5 +++--
|
|
|
9fc0f6 |
src/test/test-utf8.c | 1 +
|
|
|
9fc0f6 |
2 files changed, 4 insertions(+), 2 deletions(-)
|
|
|
9fc0f6 |
|
|
|
9fc0f6 |
diff --git a/src/shared/utf8.c b/src/shared/utf8.c
|
|
|
9fc0f6 |
index a8e28ac..31120af 100644
|
|
|
9fc0f6 |
--- a/src/shared/utf8.c
|
|
|
9fc0f6 |
+++ b/src/shared/utf8.c
|
|
|
9fc0f6 |
@@ -141,14 +141,15 @@ bool utf8_is_printable(const char* str, size_t length) {
|
|
|
9fc0f6 |
|
|
|
9fc0f6 |
assert(str);
|
|
|
9fc0f6 |
|
|
|
9fc0f6 |
- for (p = (const uint8_t*) str; length; p++) {
|
|
|
9fc0f6 |
+ for (p = (const uint8_t*) str; length;) {
|
|
|
9fc0f6 |
int encoded_len = utf8_encoded_valid_unichar((const char *)p);
|
|
|
9fc0f6 |
- int32_t val = utf8_encoded_to_unichar((const char*)p);
|
|
|
9fc0f6 |
+ int val = utf8_encoded_to_unichar((const char*)p);
|
|
|
9fc0f6 |
|
|
|
9fc0f6 |
if (encoded_len < 0 || val < 0 || is_unicode_control(val))
|
|
|
9fc0f6 |
return false;
|
|
|
9fc0f6 |
|
|
|
9fc0f6 |
length -= encoded_len;
|
|
|
9fc0f6 |
+ p += encoded_len;
|
|
|
9fc0f6 |
}
|
|
|
9fc0f6 |
|
|
|
9fc0f6 |
return true;
|
|
|
9fc0f6 |
diff --git a/src/test/test-utf8.c b/src/test/test-utf8.c
|
|
|
9fc0f6 |
index 7bd0db1..f0182ee 100644
|
|
|
9fc0f6 |
--- a/src/test/test-utf8.c
|
|
|
9fc0f6 |
+++ b/src/test/test-utf8.c
|
|
|
9fc0f6 |
@@ -26,6 +26,7 @@ static void test_utf8_is_printable(void) {
|
|
|
9fc0f6 |
assert_se(utf8_is_printable("ascii is valid\tunicode", 22));
|
|
|
9fc0f6 |
assert_se(utf8_is_printable("\342\204\242", 3));
|
|
|
9fc0f6 |
assert_se(!utf8_is_printable("\341\204", 2));
|
|
|
9fc0f6 |
+ assert_se(utf8_is_printable("ąę", 4));
|
|
|
9fc0f6 |
}
|
|
|
9fc0f6 |
|
|
|
9fc0f6 |
static void test_utf8_is_valid(void) {
|