From edb4ae8d586a471c389d0a5e6a4b42cb5ce2f1a9 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Wed, 30 Mar 2016 16:43:20 +0200 Subject: [PATCH] tc: connmark, pedit: Rename BRANCH to CONTROL Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1275426 Upstream Status: iproute2.git commit 1672f42195406 Conflicts: - Connmark action does not exist in RHEL7. - Missing commit 32a121cba2579 ("tc: code cleanup") which itself causes many conflicts. commit 1672f42195406d2d4d8fb014b8ea2a59e59f2d6a Author: Phil Sutter Date: Tue Mar 22 15:48:33 2016 +0100 tc: connmark, pedit: Rename BRANCH to CONTROL As Jamal suggested, BRANCH is the wrong name, as these keywords go beyond simple branch control - e.g. loops are possible, too. Therefore rename the non-terminal to CONTROL instead which should be more appropriate. Signed-off-by: Phil Sutter Signed-off-by: Stephen Hemminger --- man/man8/tc-pedit.8 | 6 +++--- tc/m_pedit.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/man/man8/tc-pedit.8 b/man/man8/tc-pedit.8 index c30927e..c34520c 100644 --- a/man/man8/tc-pedit.8 +++ b/man/man8/tc-pedit.8 @@ -6,7 +6,7 @@ pedit - generic packet editor action .in +8 .ti -8 .BR tc " ... " "action pedit munge " { -.IR RAW_OP " | " LAYERED_OP " } [ " BRANCH " ]" +.IR RAW_OP " | " LAYERED_OP " } [ " CONTROL " ]" .ti -8 .IR RAW_OP " := " @@ -45,7 +45,7 @@ pedit - generic packet editor action .IR RVAL " ]" .ti -8 -.IR BRANCH " := {" +.IR CONTROL " := {" .BR reclassify " | " pipe " | " drop " | " shot " | " continue " | " pass " }" .SH DESCRIPTION The @@ -165,7 +165,7 @@ This optional extra part of .I CMD_SPEC allows to exclude bits from being changed. .TP -.I BRANCH +.I CONTROL The following keywords allow to control how the tree of qdisc, classes, filters and actions is further traversed after this action. .RS diff --git a/tc/m_pedit.c b/tc/m_pedit.c index 64a3eae..c8c0264 100644 --- a/tc/m_pedit.c +++ b/tc/m_pedit.c @@ -35,7 +35,7 @@ int pedit_debug = 1; static void explain(void) { - fprintf(stderr, "Usage: ... pedit munge []\n"); + fprintf(stderr, "Usage: ... pedit munge [CONTROL]\n"); fprintf(stderr, "Where: MUNGE := |\n" "\t:= [ATC]\n " @@ -47,7 +47,7 @@ explain(void) "\t\tCMD:= clear | invert | set | retain\n " "\t:= ip | ip6 \n " " \t\t| udp | tcp | icmp \n" - "\t:= reclassify | pipe | drop | continue | pass\n" + "\tCONTROL:= reclassify | pipe | drop | continue | pass\n" "For Example usage look at the examples directory\n"); } -- 1.8.3.1