naccyde / rpms / iproute

Forked from rpms/iproute 9 months ago
Clone

Blame SOURCES/0073-m_mirred-don-t-bail-if-the-control-action-is-missing.patch

8def76
From a298548e9cf58ea7dcaaefd29926bbbc4a1473b4 Mon Sep 17 00:00:00 2001
8def76
From: Andrea Claudi <aclaudi@redhat.com>
8def76
Date: Wed, 26 Jun 2019 18:18:04 +0200
8def76
Subject: [PATCH] m_mirred: don't bail if the control action is missing
8def76
8def76
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1711760
8def76
Upstream Status: iproute2.git commit 6eccf7ecdb010
8def76
8def76
commit 6eccf7ecdb010a90e5271942748ef4338ddb61ae
8def76
Author: Paolo Abeni <pabeni@redhat.com>
8def76
Date:   Mon May 20 11:56:52 2019 +0200
8def76
8def76
    m_mirred: don't bail if the control action is missing
8def76
8def76
    The mirred act admits an optional control action, defaulting
8def76
    to TC_ACT_PIPE. The parsing code currently emits an error message
8def76
    if the control action is not provided on the command line, even
8def76
    if the command itself completes with no error.
8def76
8def76
    This change shuts down the error message, using the appropriate
8def76
    parsing helper.
8def76
8def76
    Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control actions")
8def76
    Signed-off-by: Paolo Abeni <pabeni@redhat.com>
8def76
    Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
8def76
---
8def76
 tc/m_mirred.c | 3 ++-
8def76
 1 file changed, 2 insertions(+), 1 deletion(-)
8def76
8def76
diff --git a/tc/m_mirred.c b/tc/m_mirred.c
8def76
index c7f7318b8413f..23ba638a234d1 100644
8def76
--- a/tc/m_mirred.c
8def76
+++ b/tc/m_mirred.c
8def76
@@ -202,7 +202,8 @@ parse_direction(struct action_util *a, int *argc_p, char ***argv_p,
8def76
 
8def76
 
8def76
 	if (p.eaction == TCA_EGRESS_MIRROR || p.eaction == TCA_INGRESS_MIRROR)
8def76
-		parse_action_control(&argc, &argv, &p.action, false);
8def76
+		parse_action_control_dflt(&argc, &argv, &p.action, false,
8def76
+					  TC_ACT_PIPE);
8def76
 
8def76
 	if (argc) {
8def76
 		if (iok && matches(*argv, "index") == 0) {
8def76
-- 
8def76
2.20.1
8def76