|
 |
88ed35 |
From 0a250b280fbaf8e4d6ad173cf6d9e082658954b4 Mon Sep 17 00:00:00 2001
|
|
|
88ed35 |
Message-Id: <0a250b280fbaf8e4d6ad173cf6d9e082658954b4.1644243783.git.aclaudi@redhat.com>
|
|
|
88ed35 |
In-Reply-To: <b30268eda844bdebbb8e5e4f5735e3b1bb666368.1644243783.git.aclaudi@redhat.com>
|
|
|
88ed35 |
References: <b30268eda844bdebbb8e5e4f5735e3b1bb666368.1644243783.git.aclaudi@redhat.com>
|
|
|
88ed35 |
From: Andrea Claudi <aclaudi@redhat.com>
|
|
|
88ed35 |
Date: Mon, 7 Feb 2022 15:16:36 +0100
|
|
|
88ed35 |
Subject: [PATCH] tc: u32: add support for json output
|
|
|
88ed35 |
|
|
|
88ed35 |
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1989591
|
|
|
88ed35 |
Upstream Status: unknown commit c733722b
|
|
|
88ed35 |
|
|
|
88ed35 |
commit c733722b993cb82832722b1490cbc5002035fd20
|
|
|
88ed35 |
Author: Wen Liang <liangwen12year@gmail.com>
|
|
|
88ed35 |
Date: Wed Jan 26 14:44:47 2022 -0500
|
|
|
88ed35 |
|
|
|
88ed35 |
tc: u32: add support for json output
|
|
|
88ed35 |
|
|
|
88ed35 |
Currently u32 filter output does not support json. This commit uses
|
|
|
88ed35 |
proper json functions to add support for it.
|
|
|
88ed35 |
|
|
|
88ed35 |
`sprint_u32_handle` adds an extra space after the raw check, remove the
|
|
|
88ed35 |
extra space.
|
|
|
88ed35 |
|
|
|
88ed35 |
Signed-off-by: Wen Liang <liangwen12year@gmail.com>
|
|
|
88ed35 |
Tested-by: Victor Nogueira <victor@mojatatu.com>
|
|
|
88ed35 |
Signed-off-by: David Ahern <dsahern@kernel.org>
|
|
|
88ed35 |
---
|
|
|
88ed35 |
tc/f_u32.c | 83 ++++++++++++++++++++++++++++++------------------------
|
|
|
88ed35 |
1 file changed, 46 insertions(+), 37 deletions(-)
|
|
|
88ed35 |
|
|
|
88ed35 |
diff --git a/tc/f_u32.c b/tc/f_u32.c
|
|
|
88ed35 |
index a5747f67..11da202e 100644
|
|
|
88ed35 |
--- a/tc/f_u32.c
|
|
|
88ed35 |
+++ b/tc/f_u32.c
|
|
|
88ed35 |
@@ -109,7 +109,7 @@ static char *sprint_u32_handle(__u32 handle, char *buf)
|
|
|
88ed35 |
}
|
|
|
88ed35 |
}
|
|
|
88ed35 |
if (show_raw)
|
|
|
88ed35 |
- snprintf(b, bsize, "[%08x] ", handle);
|
|
|
88ed35 |
+ snprintf(b, bsize, "[%08x]", handle);
|
|
|
88ed35 |
return buf;
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
@@ -1213,11 +1213,11 @@ static int u32_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt,
|
|
|
88ed35 |
|
|
|
88ed35 |
if (handle) {
|
|
|
88ed35 |
SPRINT_BUF(b1);
|
|
|
88ed35 |
- fprintf(f, "fh %s ", sprint_u32_handle(handle, b1));
|
|
|
88ed35 |
+ print_string(PRINT_ANY, "fh", "fh %s ", sprint_u32_handle(handle, b1));
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
if (TC_U32_NODE(handle))
|
|
|
88ed35 |
- fprintf(f, "order %d ", TC_U32_NODE(handle));
|
|
|
88ed35 |
+ print_int(PRINT_ANY, "order", "order %d ", TC_U32_NODE(handle));
|
|
|
88ed35 |
|
|
|
88ed35 |
if (tb[TCA_U32_SEL]) {
|
|
|
88ed35 |
if (RTA_PAYLOAD(tb[TCA_U32_SEL]) < sizeof(*sel))
|
|
|
88ed35 |
@@ -1227,15 +1227,15 @@ static int u32_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt,
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
if (tb[TCA_U32_DIVISOR]) {
|
|
|
88ed35 |
- fprintf(f, "ht divisor %d ",
|
|
|
88ed35 |
- rta_getattr_u32(tb[TCA_U32_DIVISOR]));
|
|
|
88ed35 |
+ __u32 htdivisor = rta_getattr_u32(tb[TCA_U32_DIVISOR]);
|
|
|
88ed35 |
+
|
|
|
88ed35 |
+ print_int(PRINT_ANY, "ht_divisor", "ht divisor %d ", htdivisor);
|
|
|
88ed35 |
} else if (tb[TCA_U32_HASH]) {
|
|
|
88ed35 |
__u32 htid = rta_getattr_u32(tb[TCA_U32_HASH]);
|
|
|
88ed35 |
-
|
|
|
88ed35 |
- fprintf(f, "key ht %x bkt %x ", TC_U32_USERHTID(htid),
|
|
|
88ed35 |
- TC_U32_HASH(htid));
|
|
|
88ed35 |
+ print_hex(PRINT_ANY, "key_ht", "key ht %x ", TC_U32_USERHTID(htid));
|
|
|
88ed35 |
+ print_hex(PRINT_ANY, "bkt", "bkt %x ", TC_U32_HASH(htid));
|
|
|
88ed35 |
} else {
|
|
|
88ed35 |
- fprintf(f, "??? ");
|
|
|
88ed35 |
+ fprintf(stderr, "divisor and hash missing ");
|
|
|
88ed35 |
}
|
|
|
88ed35 |
if (tb[TCA_U32_CLASSID]) {
|
|
|
88ed35 |
SPRINT_BUF(b1);
|
|
|
88ed35 |
@@ -1244,27 +1244,27 @@ static int u32_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt,
|
|
|
88ed35 |
sprint_tc_classid(rta_getattr_u32(tb[TCA_U32_CLASSID]),
|
|
|
88ed35 |
b1));
|
|
|
88ed35 |
} else if (sel && sel->flags & TC_U32_TERMINAL) {
|
|
|
88ed35 |
- fprintf(f, "terminal flowid ??? ");
|
|
|
88ed35 |
+ print_string(PRINT_FP, NULL, "terminal flowid ", NULL);
|
|
|
88ed35 |
}
|
|
|
88ed35 |
if (tb[TCA_U32_LINK]) {
|
|
|
88ed35 |
SPRINT_BUF(b1);
|
|
|
88ed35 |
- fprintf(f, "link %s ",
|
|
|
88ed35 |
- sprint_u32_handle(rta_getattr_u32(tb[TCA_U32_LINK]),
|
|
|
88ed35 |
- b1));
|
|
|
88ed35 |
+ char *link = sprint_u32_handle(rta_getattr_u32(tb[TCA_U32_LINK]), b1);
|
|
|
88ed35 |
+
|
|
|
88ed35 |
+ print_string(PRINT_ANY, "link", "link %s ", link);
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
if (tb[TCA_U32_FLAGS]) {
|
|
|
88ed35 |
__u32 flags = rta_getattr_u32(tb[TCA_U32_FLAGS]);
|
|
|
88ed35 |
|
|
|
88ed35 |
if (flags & TCA_CLS_FLAGS_SKIP_HW)
|
|
|
88ed35 |
- fprintf(f, "skip_hw ");
|
|
|
88ed35 |
+ print_bool(PRINT_ANY, "skip_hw", "skip_hw ", true);
|
|
|
88ed35 |
if (flags & TCA_CLS_FLAGS_SKIP_SW)
|
|
|
88ed35 |
- fprintf(f, "skip_sw ");
|
|
|
88ed35 |
+ print_bool(PRINT_ANY, "skip_sw", "skip_sw ", true);
|
|
|
88ed35 |
|
|
|
88ed35 |
if (flags & TCA_CLS_FLAGS_IN_HW)
|
|
|
88ed35 |
- fprintf(f, "in_hw ");
|
|
|
88ed35 |
+ print_bool(PRINT_ANY, "in_hw", "in_hw ", true);
|
|
|
88ed35 |
else if (flags & TCA_CLS_FLAGS_NOT_IN_HW)
|
|
|
88ed35 |
- fprintf(f, "not_in_hw ");
|
|
|
88ed35 |
+ print_bool(PRINT_ANY, "not_in_hw", "not_in_hw ", true);
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
if (tb[TCA_U32_PCNT]) {
|
|
|
88ed35 |
@@ -1275,10 +1275,10 @@ static int u32_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt,
|
|
|
88ed35 |
pf = RTA_DATA(tb[TCA_U32_PCNT]);
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
- if (sel && show_stats && NULL != pf)
|
|
|
88ed35 |
- fprintf(f, " (rule hit %llu success %llu)",
|
|
|
88ed35 |
- (unsigned long long) pf->rcnt,
|
|
|
88ed35 |
- (unsigned long long) pf->rhit);
|
|
|
88ed35 |
+ if (sel && show_stats && NULL != pf) {
|
|
|
88ed35 |
+ print_u64(PRINT_ANY, "rule_hit", "(rule hit %llu ", pf->rcnt);
|
|
|
88ed35 |
+ print_u64(PRINT_ANY, "success", "success %llu)", pf->rhit);
|
|
|
88ed35 |
+ }
|
|
|
88ed35 |
|
|
|
88ed35 |
if (tb[TCA_U32_MARK]) {
|
|
|
88ed35 |
struct tc_u32_mark *mark = RTA_DATA(tb[TCA_U32_MARK]);
|
|
|
88ed35 |
@@ -1286,8 +1286,10 @@ static int u32_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt,
|
|
|
88ed35 |
if (RTA_PAYLOAD(tb[TCA_U32_MARK]) < sizeof(*mark)) {
|
|
|
88ed35 |
fprintf(f, "\n Invalid mark (kernel&iproute2 mismatch)\n");
|
|
|
88ed35 |
} else {
|
|
|
88ed35 |
- fprintf(f, "\n mark 0x%04x 0x%04x (success %d)",
|
|
|
88ed35 |
- mark->val, mark->mask, mark->success);
|
|
|
88ed35 |
+ print_nl();
|
|
|
88ed35 |
+ print_0xhex(PRINT_ANY, "fwmark_value", " mark 0x%04x ", mark->val);
|
|
|
88ed35 |
+ print_0xhex(PRINT_ANY, "fwmark_mask", "0x%04x ", mark->mask);
|
|
|
88ed35 |
+ print_int(PRINT_ANY, "fwmark_success", "(success %d)", mark->success);
|
|
|
88ed35 |
}
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
@@ -1298,38 +1300,45 @@ static int u32_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt,
|
|
|
88ed35 |
for (i = 0; i < sel->nkeys; i++) {
|
|
|
88ed35 |
show_keys(f, sel->keys + i);
|
|
|
88ed35 |
if (show_stats && NULL != pf)
|
|
|
88ed35 |
- fprintf(f, " (success %llu ) ",
|
|
|
88ed35 |
- (unsigned long long) pf->kcnts[i]);
|
|
|
88ed35 |
+ print_u64(PRINT_ANY, "success", " (success %llu ) ",
|
|
|
88ed35 |
+ pf->kcnts[i]);
|
|
|
88ed35 |
}
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
if (sel->flags & (TC_U32_VAROFFSET | TC_U32_OFFSET)) {
|
|
|
88ed35 |
- fprintf(f, "\n offset ");
|
|
|
88ed35 |
- if (sel->flags & TC_U32_VAROFFSET)
|
|
|
88ed35 |
- fprintf(f, "%04x>>%d at %d ",
|
|
|
88ed35 |
- ntohs(sel->offmask),
|
|
|
88ed35 |
- sel->offshift, sel->offoff);
|
|
|
88ed35 |
+ print_nl();
|
|
|
88ed35 |
+ print_string(PRINT_ANY, NULL, "%s", " offset ");
|
|
|
88ed35 |
+ if (sel->flags & TC_U32_VAROFFSET) {
|
|
|
88ed35 |
+ print_hex(PRINT_ANY, "offset_mask", "%04x", ntohs(sel->offmask));
|
|
|
88ed35 |
+ print_int(PRINT_ANY, "offset_shift", ">>%d ", sel->offshift);
|
|
|
88ed35 |
+ print_int(PRINT_ANY, "offset_off", "at %d ", sel->offoff);
|
|
|
88ed35 |
+ }
|
|
|
88ed35 |
if (sel->off)
|
|
|
88ed35 |
- fprintf(f, "plus %d ", sel->off);
|
|
|
88ed35 |
+ print_int(PRINT_ANY, "plus", "plus %d ", sel->off);
|
|
|
88ed35 |
}
|
|
|
88ed35 |
if (sel->flags & TC_U32_EAT)
|
|
|
88ed35 |
- fprintf(f, " eat ");
|
|
|
88ed35 |
+ print_string(PRINT_ANY, NULL, "%s", " eat ");
|
|
|
88ed35 |
|
|
|
88ed35 |
if (sel->hmask) {
|
|
|
88ed35 |
- fprintf(f, "\n hash mask %08x at %d ",
|
|
|
88ed35 |
- (unsigned int)htonl(sel->hmask), sel->hoff);
|
|
|
88ed35 |
+ print_nl();
|
|
|
88ed35 |
+ unsigned int hmask = (unsigned int)htonl(sel->hmask);
|
|
|
88ed35 |
+
|
|
|
88ed35 |
+ print_hex(PRINT_ANY, "hash_mask", " hash mask %08x ", hmask);
|
|
|
88ed35 |
+ print_int(PRINT_ANY, "hash_off", "at %d ", sel->hoff);
|
|
|
88ed35 |
}
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
if (tb[TCA_U32_POLICE]) {
|
|
|
88ed35 |
- fprintf(f, "\n");
|
|
|
88ed35 |
+ print_nl();
|
|
|
88ed35 |
tc_print_police(f, tb[TCA_U32_POLICE]);
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
if (tb[TCA_U32_INDEV]) {
|
|
|
88ed35 |
struct rtattr *idev = tb[TCA_U32_INDEV];
|
|
|
88ed35 |
-
|
|
|
88ed35 |
- fprintf(f, "\n input dev %s\n", rta_getattr_str(idev));
|
|
|
88ed35 |
+ print_nl();
|
|
|
88ed35 |
+ print_string(PRINT_ANY, "input_dev", " input dev %s",
|
|
|
88ed35 |
+ rta_getattr_str(idev));
|
|
|
88ed35 |
+ print_nl();
|
|
|
88ed35 |
}
|
|
|
88ed35 |
|
|
|
88ed35 |
if (tb[TCA_U32_ACT])
|
|
|
88ed35 |
--
|
|
|
88ed35 |
2.34.1
|
|
|
88ed35 |
|