mrc0mmand / rpms / openldap

Forked from rpms/openldap 3 years ago
Clone

Blame SOURCES/openldap-missing-unlock-in-accesslog-overlay.patch

103552
A mutex lock might not get unlocked when plausible
103552
103552
In the preceding if-statement a mutex may get locked. This is unlocked on
103552
'done' label, but not called when plausible. Based on the current code logic
103552
this seems to not be able to happen, but might when code gets changed at 
103552
some point in time. This patch fixes the issue.
103552
103552
The issue was found by Coverity scan 
103552
http://cov01.lab.eng.brq.redhat.com/covscanhub/waiving/11054/38577/
103552
103552
Author: Matus Honek <mhonek@redhat.com>
103552
Resolves: #1261003
103552
103552
--- a/servers/slapd/overlays/accesslog.c
103552
+++ b/servers/slapd/overlays/accesslog.c
103552
@@ -1519,7 +1519,7 @@ static int accesslog_response(Operation *op, SlapReply *rs) {
103552
 
103552
 	/* ignore these internal reads */
103552
 	if (( lo->mask & LOG_OP_READS ) && op->o_do_not_cache ) {
103552
-		return SLAP_CB_CONTINUE;
103552
+		goto done;
103552
 	}
103552
 
103552
 	if ( li->li_success && rs->sr_err != LDAP_SUCCESS )