test/shell/cache-single-options.sh | 2 +- tools/lvchange.c | 8 ++++++++ tools/lvconvert.c | 8 ++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/test/shell/cache-single-options.sh b/test/shell/cache-single-options.sh index da9cbba..6b71b2f 100644 --- a/test/shell/cache-single-options.sh +++ b/test/shell/cache-single-options.sh @@ -228,7 +228,7 @@ lvconvert -y --type cache --cachevol $lv2 $vg/$lv1 lvchange -ay $vg/$lv1 -lvchange --cachemode writeback $vg/$lv1 +lvchange -y --cachemode writeback $vg/$lv1 check lv_field $vg/$lv1 cachemode "writeback" diff --git a/tools/lvchange.c b/tools/lvchange.c index 7bdf997..92c6524 100644 --- a/tools/lvchange.c +++ b/tools/lvchange.c @@ -635,6 +635,14 @@ static int _lvchange_cache(struct cmd_context *cmd, if (!get_cache_params(cmd, &chunk_size, &format, &mode, &name, &settings)) goto_out; + if (seg_is_cache(seg) && lv_is_cache_vol(seg->pool_lv) && (mode == CACHE_MODE_WRITEBACK)) { + log_warn("WARNING: repairing a damaged cachevol is not yet possible."); + log_warn("WARNING: cache mode writethrough is suggested for safe operation."); + if (!arg_count(cmd, yes_ARG) && + yes_no_prompt("Continue using writeback without repair?") == 'n') + goto_out; + } + if ((mode != CACHE_MODE_UNSELECTED) && (mode != setting_seg->cache_mode) && lv_is_cache(lv)) { diff --git a/tools/lvconvert.c b/tools/lvconvert.c index 24db8d2..ebc2243 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -3401,6 +3401,14 @@ static int _cache_vol_attach(struct cmd_context *cmd, if (!cache_vol_set_params(cmd, cache_lv, lv_fast, poolmetadatasize, chunk_size, cache_metadata_format, cache_mode, policy_name, policy_settings)) goto_out; + if (cache_mode == CACHE_MODE_WRITEBACK) { + log_warn("WARNING: repairing a damaged cachevol is not yet possible."); + log_warn("WARNING: cache mode writethrough is suggested for safe operation."); + if (!arg_count(cmd, yes_ARG) && + yes_no_prompt("Continue using writeback without repair?") == 'n') + goto_out; + } + /* * lv/cache_lv keeps the same lockd lock it had before, the lock for * lv_fast is freed, and lv_corig has no lock.