|
 |
31f061 |
lib/metadata/cache_manip.c | 40 ++++++++++++++--------------------------
|
|
|
31f061 |
lib/metadata/metadata-exported.h | 1 +
|
|
|
31f061 |
tools/lvconvert.c | 1 +
|
|
|
31f061 |
tools/lvcreate.c | 1 +
|
|
|
31f061 |
4 files changed, 17 insertions(+), 26 deletions(-)
|
|
|
31f061 |
|
|
|
31f061 |
diff --git a/lib/metadata/cache_manip.c b/lib/metadata/cache_manip.c
|
|
|
31f061 |
index 2c4cc92..90ebd94 100644
|
|
|
31f061 |
--- a/lib/metadata/cache_manip.c
|
|
|
31f061 |
+++ b/lib/metadata/cache_manip.c
|
|
|
31f061 |
@@ -204,6 +204,7 @@ int update_cache_pool_params(struct cmd_context *cmd,
|
|
|
31f061 |
unsigned attr,
|
|
|
31f061 |
uint32_t pool_data_extents,
|
|
|
31f061 |
uint32_t *pool_metadata_extents,
|
|
|
31f061 |
+ struct logical_volume *metadata_lv,
|
|
|
31f061 |
int *chunk_size_calc_method, uint32_t *chunk_size)
|
|
|
31f061 |
{
|
|
|
31f061 |
uint64_t min_meta_size;
|
|
|
31f061 |
@@ -252,39 +253,26 @@ int update_cache_pool_params(struct cmd_context *cmd,
|
|
|
31f061 |
if (!validate_cache_chunk_size(cmd, *chunk_size))
|
|
|
31f061 |
return_0;
|
|
|
31f061 |
|
|
|
31f061 |
- min_meta_size = _cache_min_metadata_size((uint64_t) pool_data_extents * extent_size, *chunk_size);
|
|
|
31f061 |
+ if ((uint64_t) *chunk_size > (uint64_t) pool_data_extents * extent_size) {
|
|
|
31f061 |
+ log_error("Size of %s data volume cannot be smaller than chunk size %s.",
|
|
|
31f061 |
+ segtype->name, display_size(cmd, *chunk_size));
|
|
|
31f061 |
+ return 0;
|
|
|
31f061 |
+ }
|
|
|
31f061 |
|
|
|
31f061 |
- /* Round up to extent size */
|
|
|
31f061 |
- if (min_meta_size % extent_size)
|
|
|
31f061 |
- min_meta_size += extent_size - min_meta_size % extent_size;
|
|
|
31f061 |
+ min_meta_size = _cache_min_metadata_size((uint64_t) pool_data_extents * extent_size, *chunk_size);
|
|
|
31f061 |
+ min_meta_size = dm_round_up(min_meta_size, extent_size);
|
|
|
31f061 |
|
|
|
31f061 |
if (!pool_metadata_size)
|
|
|
31f061 |
pool_metadata_size = min_meta_size;
|
|
|
31f061 |
|
|
|
31f061 |
- if (pool_metadata_size > (2 * DEFAULT_CACHE_POOL_MAX_METADATA_SIZE)) {
|
|
|
31f061 |
- pool_metadata_size = 2 * DEFAULT_CACHE_POOL_MAX_METADATA_SIZE;
|
|
|
31f061 |
- if (*pool_metadata_extents)
|
|
|
31f061 |
- log_warn("WARNING: Maximum supported pool metadata size is %s.",
|
|
|
31f061 |
- display_size(cmd, pool_metadata_size));
|
|
|
31f061 |
- } else if (pool_metadata_size < min_meta_size) {
|
|
|
31f061 |
- if (*pool_metadata_extents)
|
|
|
31f061 |
- log_warn("WARNING: Minimum required pool metadata size is %s "
|
|
|
31f061 |
- "(needs extra %s).",
|
|
|
31f061 |
- display_size(cmd, min_meta_size),
|
|
|
31f061 |
- display_size(cmd, min_meta_size - pool_metadata_size));
|
|
|
31f061 |
- pool_metadata_size = min_meta_size;
|
|
|
31f061 |
- }
|
|
|
31f061 |
-
|
|
|
31f061 |
- if (!(*pool_metadata_extents =
|
|
|
31f061 |
- extents_from_size(cmd, pool_metadata_size, extent_size)))
|
|
|
31f061 |
+ if (!update_pool_metadata_min_max(cmd, extent_size,
|
|
|
31f061 |
+ min_meta_size,
|
|
|
31f061 |
+ (2 * DEFAULT_CACHE_POOL_MAX_METADATA_SIZE),
|
|
|
31f061 |
+ &pool_metadata_size,
|
|
|
31f061 |
+ metadata_lv,
|
|
|
31f061 |
+ pool_metadata_extents))
|
|
|
31f061 |
return_0;
|
|
|
31f061 |
|
|
|
31f061 |
- if ((uint64_t) *chunk_size > (uint64_t) pool_data_extents * extent_size) {
|
|
|
31f061 |
- log_error("Size of %s data volume cannot be smaller than chunk size %s.",
|
|
|
31f061 |
- segtype->name, display_size(cmd, *chunk_size));
|
|
|
31f061 |
- return 0;
|
|
|
31f061 |
- }
|
|
|
31f061 |
-
|
|
|
31f061 |
log_verbose("Preferred pool metadata size %s.",
|
|
|
31f061 |
display_size(cmd, (uint64_t)*pool_metadata_extents * extent_size));
|
|
|
31f061 |
|
|
|
31f061 |
diff --git a/lib/metadata/metadata-exported.h b/lib/metadata/metadata-exported.h
|
|
|
31f061 |
index 0e57722..c0fa564 100644
|
|
|
31f061 |
--- a/lib/metadata/metadata-exported.h
|
|
|
31f061 |
+++ b/lib/metadata/metadata-exported.h
|
|
|
31f061 |
@@ -1319,6 +1319,7 @@ int update_cache_pool_params(struct cmd_context *cmd,
|
|
|
31f061 |
unsigned attr,
|
|
|
31f061 |
uint32_t pool_data_extents,
|
|
|
31f061 |
uint32_t *pool_metadata_extents,
|
|
|
31f061 |
+ struct logical_volume *metadata_lv,
|
|
|
31f061 |
int *chunk_size_calc_method, uint32_t *chunk_size);
|
|
|
31f061 |
int validate_lv_cache_chunk_size(struct logical_volume *pool_lv, uint32_t chunk_size);
|
|
|
31f061 |
int validate_lv_cache_create_pool(const struct logical_volume *pool_lv);
|
|
|
31f061 |
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
|
|
|
31f061 |
index ce90279..416e8a7 100644
|
|
|
31f061 |
--- a/tools/lvconvert.c
|
|
|
31f061 |
+++ b/tools/lvconvert.c
|
|
|
31f061 |
@@ -3189,6 +3189,7 @@ static int _lvconvert_to_pool(struct cmd_context *cmd,
|
|
|
31f061 |
pool_segtype, target_attr,
|
|
|
31f061 |
lv->le_count,
|
|
|
31f061 |
&meta_extents,
|
|
|
31f061 |
+ metadata_lv,
|
|
|
31f061 |
&chunk_calc,
|
|
|
31f061 |
&chunk_size))
|
|
|
31f061 |
goto_bad;
|
|
|
31f061 |
diff --git a/tools/lvcreate.c b/tools/lvcreate.c
|
|
|
31f061 |
index 1ee9e14..1ce561f 100644
|
|
|
31f061 |
--- a/tools/lvcreate.c
|
|
|
31f061 |
+++ b/tools/lvcreate.c
|
|
|
31f061 |
@@ -403,6 +403,7 @@ static int _update_extents_params(struct volume_group *vg,
|
|
|
31f061 |
lp->segtype, lp->target_attr,
|
|
|
31f061 |
lp->extents,
|
|
|
31f061 |
&lp->pool_metadata_extents,
|
|
|
31f061 |
+ NULL,
|
|
|
31f061 |
&lp->thin_chunk_size_calc_policy,
|
|
|
31f061 |
&lp->chunk_size))
|
|
|
31f061 |
return_0;
|