mrc0mmand / rpms / libguestfs

Forked from rpms/libguestfs 3 years ago
Clone

Blame SOURCES/0057-v2v-o-rhv-upload-Make-oo-rhv-cafile-optional-in-all-.patch

5ce0c7
From fdf461e88c464de697c14adea2e8e61644811844 Mon Sep 17 00:00:00 2001
46b2f6
From: "Richard W.M. Jones" <rjones@redhat.com>
46b2f6
Date: Wed, 15 Jan 2020 11:12:17 +0000
46b2f6
Subject: [PATCH] v2v: -o rhv-upload: Make -oo rhv-cafile optional in all cases
46b2f6
 (RHBZ#1791240).
46b2f6
46b2f6
This is actually not required, because ovirtsdk4 will use the system's
46b2f6
global trust store if necessary.  Therefore we can make it optional in
46b2f6
all cases.
46b2f6
46b2f6
(cherry picked from commit 65ee9387d4be0e3c5cd214b967fef7a1a8841233
46b2f6
in virt-v2v)
46b2f6
---
46b2f6
 v2v/output_rhv_upload.ml    | 2 --
46b2f6
 v2v/virt-v2v-output-rhv.pod | 5 ++++-
46b2f6
 2 files changed, 4 insertions(+), 3 deletions(-)
46b2f6
46b2f6
diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml
46b2f6
index 2c8c18732..e1d06867b 100644
46b2f6
--- a/v2v/output_rhv_upload.ml
46b2f6
+++ b/v2v/output_rhv_upload.ml
46b2f6
@@ -81,8 +81,6 @@ let parse_output_options options =
46b2f6
   let rhv_direct = !rhv_direct in
46b2f6
   let rhv_verifypeer = !rhv_verifypeer in
46b2f6
   let rhv_disk_uuids = Option.map List.rev !rhv_disk_uuids in
46b2f6
-  if rhv_verifypeer && rhv_cafile = None then
46b2f6
-     error (f_"-o rhv-upload: must use ‘-oo rhv-cafile’ to supply the path to the oVirt or RHV user’s ‘ca.pem’ file");
46b2f6
 
46b2f6
   { rhv_cafile; rhv_cluster; rhv_direct; rhv_verifypeer; rhv_disk_uuids }
46b2f6
 
46b2f6
diff --git a/v2v/virt-v2v-output-rhv.pod b/v2v/virt-v2v-output-rhv.pod
46b2f6
index 04a894268..4520c9184 100644
46b2f6
--- a/v2v/virt-v2v-output-rhv.pod
46b2f6
+++ b/v2v/virt-v2v-output-rhv.pod
46b2f6
@@ -101,7 +101,10 @@ The storage domain.
46b2f6
 The F<ca.pem> file (Certificate Authority), copied from
46b2f6
 F</etc/pki/ovirt-engine/ca.pem> on the oVirt engine.
46b2f6
 
46b2f6
-This option must be specified if I<-oo rhv-verifypeer> is enabled.
46b2f6
+If I<-oo rhv-verifypeer> is enabled then this option can
46b2f6
+be used to control which CA is used to verify the client’s
46b2f6
+identity.  If this option is not used then the system’s
46b2f6
+global trust store is used.
46b2f6
 
46b2f6
 =item I<-oo rhv-cluster=>C<CLUSTERNAME>
46b2f6
 
46b2f6
-- 
5ce0c7
2.18.4
46b2f6