mrc0mmand / rpms / libguestfs

Forked from rpms/libguestfs 3 years ago
Clone

Blame SOURCES/0048-v2v-o-rhv-upload-Make-oo-rhv-cafile-optional-in-all-.patch

10436e
From 49623c945c93b878d13c0539eddf2d625f5aeb3c Mon Sep 17 00:00:00 2001
10436e
From: "Richard W.M. Jones" <rjones@redhat.com>
10436e
Date: Wed, 15 Jan 2020 11:12:17 +0000
10436e
Subject: [PATCH] v2v: -o rhv-upload: Make -oo rhv-cafile optional in all cases
10436e
 (RHBZ#1791240).
10436e
10436e
This is actually not required, because ovirtsdk4 will use the system's
10436e
global trust store if necessary.  Therefore we can make it optional in
10436e
all cases.
10436e
10436e
(cherry picked from commit 65ee9387d4be0e3c5cd214b967fef7a1a8841233
10436e
in virt-v2v)
10436e
---
10436e
 v2v/output_rhv_upload.ml    | 2 --
10436e
 v2v/virt-v2v-output-rhv.pod | 5 ++++-
10436e
 2 files changed, 4 insertions(+), 3 deletions(-)
10436e
10436e
diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml
10436e
index 2c8c18732..e1d06867b 100644
10436e
--- a/v2v/output_rhv_upload.ml
10436e
+++ b/v2v/output_rhv_upload.ml
10436e
@@ -81,8 +81,6 @@ let parse_output_options options =
10436e
   let rhv_direct = !rhv_direct in
10436e
   let rhv_verifypeer = !rhv_verifypeer in
10436e
   let rhv_disk_uuids = Option.map List.rev !rhv_disk_uuids in
10436e
-  if rhv_verifypeer && rhv_cafile = None then
10436e
-     error (f_"-o rhv-upload: must use ‘-oo rhv-cafile’ to supply the path to the oVirt or RHV user’s ‘ca.pem’ file");
10436e
 
10436e
   { rhv_cafile; rhv_cluster; rhv_direct; rhv_verifypeer; rhv_disk_uuids }
10436e
 
10436e
diff --git a/v2v/virt-v2v-output-rhv.pod b/v2v/virt-v2v-output-rhv.pod
10436e
index 04a894268..4520c9184 100644
10436e
--- a/v2v/virt-v2v-output-rhv.pod
10436e
+++ b/v2v/virt-v2v-output-rhv.pod
10436e
@@ -101,7 +101,10 @@ The storage domain.
10436e
 The F<ca.pem> file (Certificate Authority), copied from
10436e
 F</etc/pki/ovirt-engine/ca.pem> on the oVirt engine.
10436e
 
10436e
-This option must be specified if I<-oo rhv-verifypeer> is enabled.
10436e
+If I<-oo rhv-verifypeer> is enabled then this option can
10436e
+be used to control which CA is used to verify the client’s
10436e
+identity.  If this option is not used then the system’s
10436e
+global trust store is used.
10436e
 
10436e
 =item I<-oo rhv-cluster=>C<CLUSTERNAME>
10436e
 
10436e
-- 
10436e
2.26.2
10436e