|
 |
d84fc6 |
From 2cbf56b82a5102777b37c4f7f47c8cf058cea027 Mon Sep 17 00:00:00 2001
|
|
|
d84fc6 |
From: Peter Jones <pjones@redhat.com>
|
|
|
d84fc6 |
Date: Mon, 13 May 2019 16:34:35 -0400
|
|
|
d84fc6 |
Subject: [PATCH 32/62] Work around stuff -Waddress-of-packed-member finds.
|
|
|
d84fc6 |
MIME-Version: 1.0
|
|
|
d84fc6 |
Content-Type: text/plain; charset=UTF-8
|
|
|
d84fc6 |
Content-Transfer-Encoding: 8bit
|
|
|
d84fc6 |
|
|
|
d84fc6 |
In MokManager we get a lot of these:
|
|
|
d84fc6 |
|
|
|
d84fc6 |
../src/MokManager.c:1063:19: error: taking address of packed member of ‘struct <anonymous>’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
|
|
|
d84fc6 |
1063 | if (CompareGuid(&(list[i].Type), &X509_GUID) == 0)
|
|
|
d84fc6 |
| ^~~~~~~~~~~~~~~
|
|
|
d84fc6 |
|
|
|
d84fc6 |
The reason for this is that gnu-efi takes EFI_GUID * as its argument
|
|
|
d84fc6 |
instead of VOID *, and there's nothing telling the compiler that it
|
|
|
d84fc6 |
doesn't have alignment constraints on the input, so the compiler wants
|
|
|
d84fc6 |
it to have 16-byte alignment.
|
|
|
d84fc6 |
|
|
|
d84fc6 |
Just use CompareMem() for these, as that's all CompareGuid is calling
|
|
|
d84fc6 |
anyway.
|
|
|
d84fc6 |
|
|
|
d84fc6 |
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
|
d84fc6 |
Upstream-commit-id: 08c14376b59
|
|
|
d84fc6 |
---
|
|
|
d84fc6 |
MokManager.c | 12 +++++++-----
|
|
|
d84fc6 |
1 file changed, 7 insertions(+), 5 deletions(-)
|
|
|
d84fc6 |
|
|
|
d84fc6 |
diff --git a/MokManager.c b/MokManager.c
|
|
|
d84fc6 |
index df9b6fe6912..a1bd39a68e2 100644
|
|
|
d84fc6 |
--- a/MokManager.c
|
|
|
d84fc6 |
+++ b/MokManager.c
|
|
|
d84fc6 |
@@ -22,6 +22,8 @@
|
|
|
d84fc6 |
#define CERT_STRING L"Select an X509 certificate to enroll:\n\n"
|
|
|
d84fc6 |
#define HASH_STRING L"Select a file to trust:\n\n"
|
|
|
d84fc6 |
|
|
|
d84fc6 |
+#define CompareMemberGuid(x, y) CompareMem(x, y, sizeof(EFI_GUID))
|
|
|
d84fc6 |
+
|
|
|
d84fc6 |
typedef struct {
|
|
|
d84fc6 |
UINT32 MokSize;
|
|
|
d84fc6 |
UINT8 *Mok;
|
|
|
d84fc6 |
@@ -1077,7 +1079,7 @@ static EFI_STATUS write_back_mok_list(MokListNode * list, INTN key_num,
|
|
|
d84fc6 |
continue;
|
|
|
d84fc6 |
|
|
|
d84fc6 |
DataSize += sizeof(EFI_SIGNATURE_LIST);
|
|
|
d84fc6 |
- if (CompareGuid(&(list[i].Type), &X509_GUID) == 0)
|
|
|
d84fc6 |
+ if (CompareMemberGuid(&(list[i].Type), &X509_GUID) == 0)
|
|
|
d84fc6 |
DataSize += sizeof(EFI_GUID);
|
|
|
d84fc6 |
DataSize += list[i].MokSize;
|
|
|
d84fc6 |
}
|
|
|
d84fc6 |
@@ -1099,7 +1101,7 @@ static EFI_STATUS write_back_mok_list(MokListNode * list, INTN key_num,
|
|
|
d84fc6 |
CertList->SignatureType = list[i].Type;
|
|
|
d84fc6 |
CertList->SignatureHeaderSize = 0;
|
|
|
d84fc6 |
|
|
|
d84fc6 |
- if (CompareGuid(&(list[i].Type), &X509_GUID) == 0) {
|
|
|
d84fc6 |
+ if (CompareMemberGuid(&(list[i].Type), &X509_GUID) == 0) {
|
|
|
d84fc6 |
CertList->SignatureListSize = list[i].MokSize +
|
|
|
d84fc6 |
sizeof(EFI_SIGNATURE_LIST) + sizeof(EFI_GUID);
|
|
|
d84fc6 |
CertList->SignatureSize =
|
|
|
d84fc6 |
@@ -1140,7 +1142,7 @@ static void delete_cert(void *key, UINT32 key_size,
|
|
|
d84fc6 |
int i;
|
|
|
d84fc6 |
|
|
|
d84fc6 |
for (i = 0; i < mok_num; i++) {
|
|
|
d84fc6 |
- if (CompareGuid(&(mok[i].Type), &X509_GUID) != 0)
|
|
|
d84fc6 |
+ if (CompareMemberGuid(&(mok[i].Type), &X509_GUID) != 0)
|
|
|
d84fc6 |
continue;
|
|
|
d84fc6 |
|
|
|
d84fc6 |
if (mok[i].MokSize == key_size &&
|
|
|
d84fc6 |
@@ -1191,7 +1193,7 @@ static void delete_hash_in_list(EFI_GUID Type, UINT8 * hash, UINT32 hash_size,
|
|
|
d84fc6 |
sig_size = hash_size + sizeof(EFI_GUID);
|
|
|
d84fc6 |
|
|
|
d84fc6 |
for (i = 0; i < mok_num; i++) {
|
|
|
d84fc6 |
- if ((CompareGuid(&(mok[i].Type), &Type) != 0) ||
|
|
|
d84fc6 |
+ if ((CompareMemberGuid(&(mok[i].Type), &Type) != 0) ||
|
|
|
d84fc6 |
(mok[i].MokSize < sig_size))
|
|
|
d84fc6 |
continue;
|
|
|
d84fc6 |
|
|
|
d84fc6 |
@@ -1355,7 +1357,7 @@ static EFI_STATUS delete_keys(void *MokDel, UINTN MokDelSize, BOOLEAN MokX)
|
|
|
d84fc6 |
|
|
|
d84fc6 |
/* Search and destroy */
|
|
|
d84fc6 |
for (i = 0; i < del_num; i++) {
|
|
|
d84fc6 |
- if (CompareGuid(&(del_key[i].Type), &X509_GUID) == 0) {
|
|
|
d84fc6 |
+ if (CompareMemberGuid(&(del_key[i].Type), &X509_GUID) == 0) {
|
|
|
d84fc6 |
delete_cert(del_key[i].Mok, del_key[i].MokSize,
|
|
|
d84fc6 |
mok, mok_num);
|
|
|
d84fc6 |
} else if (is_sha2_hash(del_key[i].Type)) {
|
|
|
d84fc6 |
--
|
|
|
d84fc6 |
2.26.2
|
|
|
d84fc6 |
|