From 4f2c1ddd3e3b81d2d5146b883115371f1cada9f9 Mon Sep 17 00:00:00 2001 From: Jakub Filak Date: Wed, 15 Apr 2015 12:14:52 +0200 Subject: [ABRT PATCH] ccpp: do not read data from root directories Users are allowed to modify /proc/[pid]/root to any directory by running their own MOUNT namespace. Related: #1211835 Signed-off-by: Jakub Filak --- src/hooks/abrt-hook-ccpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c index 5694f84..0606519 100644 --- a/src/hooks/abrt-hook-ccpp.c +++ b/src/hooks/abrt-hook-ccpp.c @@ -678,7 +678,7 @@ int main(int argc, char** argv) { char *rootdir = get_rootdir(pid); - dd_create_basic_files(dd, fsuid, (rootdir && strcmp(rootdir, "/") != 0) ? rootdir : NULL); + dd_create_basic_files(dd, fsuid, NULL); char source_filename[sizeof("/proc/%lu/somewhat_long_name") + sizeof(long)*3]; int source_base_ofs = sprintf(source_filename, "/proc/%lu/smaps", (long)pid); -- 1.8.3.1