|
 |
8ecbbe |
From 818cd2018ca66e804ea30066c44572ca128a24a7 Mon Sep 17 00:00:00 2001
|
|
|
8ecbbe |
From: Karel Zak <kzak@redhat.com>
|
|
|
8ecbbe |
Date: Tue, 7 Jun 2022 09:11:56 +0200
|
|
|
8ecbbe |
Subject: lslogins: improve prefixes interpretation
|
|
|
8ecbbe |
|
|
|
8ecbbe |
It seems that for example 'passwd --lock' uses two exclamation marks
|
|
|
8ecbbe |
in password field. It seems better to assume arbitrary number of '!'
|
|
|
8ecbbe |
and '*' prefixes.
|
|
|
8ecbbe |
|
|
|
8ecbbe |
The patch also makes description of the PWD-EMPTY output field more
|
|
|
8ecbbe |
explicit.
|
|
|
8ecbbe |
|
|
|
8ecbbe |
Upstream: http://github.com/util-linux/util-linux/commit/c51cba1e838ae7e36a843ec785543492bb8737cd
|
|
|
8ecbbe |
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2093166
|
|
|
8ecbbe |
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
|
8ecbbe |
---
|
|
|
8ecbbe |
login-utils/lslogins.c | 31 +++++++++++++++++++++++++------
|
|
|
8ecbbe |
1 file changed, 25 insertions(+), 6 deletions(-)
|
|
|
8ecbbe |
|
|
|
8ecbbe |
diff --git a/login-utils/lslogins.c b/login-utils/lslogins.c
|
|
|
8ecbbe |
index 6f804aa35..b81afc6c7 100644
|
|
|
8ecbbe |
--- a/login-utils/lslogins.c
|
|
|
8ecbbe |
+++ b/login-utils/lslogins.c
|
|
|
8ecbbe |
@@ -216,7 +216,7 @@ static const struct lslogins_coldesc coldescs[] =
|
|
|
8ecbbe |
{
|
|
|
8ecbbe |
[COL_USER] = { "USER", N_("user name"), N_("Username"), 0.1, SCOLS_FL_NOEXTREMES },
|
|
|
8ecbbe |
[COL_UID] = { "UID", N_("user ID"), "UID", 1, SCOLS_FL_RIGHT},
|
|
|
8ecbbe |
- [COL_PWDEMPTY] = { "PWD-EMPTY", N_("password not required"), N_("Password not required"), 1, SCOLS_FL_RIGHT },
|
|
|
8ecbbe |
+ [COL_PWDEMPTY] = { "PWD-EMPTY", N_("password not defined"), N_("Password not required (empty)"), 1, SCOLS_FL_RIGHT },
|
|
|
8ecbbe |
[COL_PWDDENY] = { "PWD-DENY", N_("login by password disabled"), N_("Login by password disabled"), 1, SCOLS_FL_RIGHT },
|
|
|
8ecbbe |
[COL_PWDLOCK] = { "PWD-LOCK", N_("password defined, but locked"), N_("Password is locked"), 1, SCOLS_FL_RIGHT },
|
|
|
8ecbbe |
[COL_NOLOGIN] = { "NOLOGIN", N_("log in disabled by nologin(8) or pam_nologin(8)"), N_("No login"), 1, SCOLS_FL_RIGHT },
|
|
|
8ecbbe |
@@ -755,16 +755,24 @@ static struct lslogins_user *get_user_info(struct lslogins_control *ctl, const c
|
|
|
8ecbbe |
break;
|
|
|
8ecbbe |
case COL_PWDEMPTY:
|
|
|
8ecbbe |
if (shadow) {
|
|
|
8ecbbe |
- if (!*shadow->sp_pwdp) /* '\0' */
|
|
|
8ecbbe |
+ const char *p = shadow->sp_pwdp;
|
|
|
8ecbbe |
+
|
|
|
8ecbbe |
+ while (p && (*p == '!' || *p == '*'))
|
|
|
8ecbbe |
+ p++;
|
|
|
8ecbbe |
+
|
|
|
8ecbbe |
+ if (!p || !*p)
|
|
|
8ecbbe |
user->pwd_empty = STATUS_TRUE;
|
|
|
8ecbbe |
} else
|
|
|
8ecbbe |
user->pwd_empty = STATUS_UNKNOWN;
|
|
|
8ecbbe |
break;
|
|
|
8ecbbe |
case COL_PWDDENY:
|
|
|
8ecbbe |
if (shadow) {
|
|
|
8ecbbe |
- if ((*shadow->sp_pwdp == '!' ||
|
|
|
8ecbbe |
- *shadow->sp_pwdp == '*') &&
|
|
|
8ecbbe |
- !valid_pwd(shadow->sp_pwdp + 1))
|
|
|
8ecbbe |
+ const char *p = shadow->sp_pwdp;
|
|
|
8ecbbe |
+
|
|
|
8ecbbe |
+ while (p && (*p == '!' || *p == '*'))
|
|
|
8ecbbe |
+ p++;
|
|
|
8ecbbe |
+
|
|
|
8ecbbe |
+ if (p && *p && p != shadow->sp_pwdp && !valid_pwd(p))
|
|
|
8ecbbe |
user->pwd_deny = STATUS_TRUE;
|
|
|
8ecbbe |
} else
|
|
|
8ecbbe |
user->pwd_deny = STATUS_UNKNOWN;
|
|
|
8ecbbe |
@@ -772,7 +780,18 @@ static struct lslogins_user *get_user_info(struct lslogins_control *ctl, const c
|
|
|
8ecbbe |
|
|
|
8ecbbe |
case COL_PWDLOCK:
|
|
|
8ecbbe |
if (shadow) {
|
|
|
8ecbbe |
- if (*shadow->sp_pwdp == '!' && valid_pwd(shadow->sp_pwdp + 1))
|
|
|
8ecbbe |
+ const char *p = shadow->sp_pwdp;
|
|
|
8ecbbe |
+ int i = 0;
|
|
|
8ecbbe |
+
|
|
|
8ecbbe |
+ /* 'passwd --lock' uses two exclamation marks,
|
|
|
8ecbbe |
+ * shadow(5) describes the lock as "field which
|
|
|
8ecbbe |
+ * starts with an exclamation mark". Let's
|
|
|
8ecbbe |
+ * support more '!' ...
|
|
|
8ecbbe |
+ */
|
|
|
8ecbbe |
+ while (p && *p == '!')
|
|
|
8ecbbe |
+ p++, i++;
|
|
|
8ecbbe |
+
|
|
|
8ecbbe |
+ if (i != 0 && (!*p || valid_pwd(p)))
|
|
|
8ecbbe |
user->pwd_lock = STATUS_TRUE;
|
|
|
8ecbbe |
} else
|
|
|
8ecbbe |
user->pwd_lock = STATUS_UNKNOWN;
|
|
|
8ecbbe |
--
|
|
|
8ecbbe |
2.36.1
|
|
|
8ecbbe |
|